From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8DBB6C433EF for ; Mon, 18 Jul 2022 13:21:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CFggdvNbSEzOFNxBaHHgPDHcz4BRoJ8+tov+BkL1bpY=; b=K3LGzP4vczX+FJ STSBWSNlXVUQ0OqsA0JpcW+auoK4ypF8y0DufaMKVMeh7DiyhvcgwBKMrGv73+wlnPoGALDwCKoq5 RJyc9ODcUt0rSDenElcd/a4tRf6R2BKUvRqShwhjUh3M2FAwcOFBXnhJQ+arPYcS8qdH7Sfxx19BR M/WNwATedD0ob1wnO9nxNZWnyrM1lyyGm0v7uOMt3lRtavlPmxAW5HwR1WceqtzDdKTPdkcRf2m9y 2okoRejevdMpKOpwPVWWJNzVUJU5Uj/hkoGhmXkx+dpkHeTFK7OUZauRtriob7ShjbIS/R3qF+n7d W/tjLaHi5lIMHU6EfFiQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oDQf3-00Dfre-Cr; Mon, 18 Jul 2022 13:19:45 +0000 Received: from mail-pl1-x62a.google.com ([2607:f8b0:4864:20::62a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oDQf0-00Dfob-6x for linux-arm-kernel@lists.infradead.org; Mon, 18 Jul 2022 13:19:43 +0000 Received: by mail-pl1-x62a.google.com with SMTP id z1so8976458plb.1 for ; Mon, 18 Jul 2022 06:19:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=K6cOdwUYhhUlLCQ8OAKwhRXbgdqK2kdqyGhsdqgptvQ=; b=IxYllnS8mdNEqHx4KGUk9e7Uzj85Y9OLP0pOC2UsLb6btN8FRh9yoRZ5s4a81mm2GL sZhOMckV2sXy95vzHO0zrCQiAc8t1jIKzvH1/jDufyQnD2KcerT+zimf3yKRL0Yk2ZYJ OZVleS53+x1M3Snaa9mT85QMK37D/OMhCQgZluU+4mUjW4ukjJae8NSapw8B/t4U1Fah scNpyvRuz+qASZyGvNTcqu4jyfnx9RbfZUw+ny1+Vv86GnQ/wxo8VanKy5o72iDGuqB1 lJ32iBHoucs7cDtH/oHhCQL/WPaZ7H0jwpmGKDACVWqMyk2IfQwhFWJ2fdltbsT+40Ny s82w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=K6cOdwUYhhUlLCQ8OAKwhRXbgdqK2kdqyGhsdqgptvQ=; b=4VKShMLh1y8zR8McmB6822bQx3/5ggFnNXg8PDLrN4u3Pxa9JroYcAYq8hQ5DaC6SR pR2RCueDOWnDDU+05CgfIVMRb9mn230C8yjZG1Ym79pI4plNMMpwse8WCDuVV52pf/G9 VnOSrc4z1voN+lmckljJVTXOEAP9oP/B/DyYr4o+I4RP0l5xsKLEm7/EqYnrcrGGOlxe gG+nxJCjpX/aWHxhgLtGVkW5dEn30OyPnDez8C4b0xRJmqxRjJNPlUEfBB+VpyJHQ3vI +nDmOe3GMJWGUEnM3sDloHMa23UFC1Ub3GXh0fiORGZjZA+NRkcMY1+QBg0Po1ecEZCB LAUw== X-Gm-Message-State: AJIora9x6cucGDh4uokm3RJhNIN2bI4SnWjy4WoMMwOJDMCevWeDtRSk 1gh6eSa63aCL3ptCKwxgx68= X-Google-Smtp-Source: AGRyM1tEg45BncQglD1UOqVTnZaN6yxmDNrJBIfk2QKl4b1+kHAqbAQ4j1B2N/cFvA514dH67u/CvA== X-Received: by 2002:a17:90a:e7cd:b0:1f0:c82:c88f with SMTP id kb13-20020a17090ae7cd00b001f00c82c88fmr38290987pjb.100.1658150379172; Mon, 18 Jul 2022 06:19:39 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id jc14-20020a17090325ce00b0016be02d2a44sm9390076plb.133.2022.07.18.06.19.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Jul 2022 06:19:21 -0700 (PDT) Date: Mon, 18 Jul 2022 06:19:00 -0700 From: Guenter Roeck To: Richard Zhu Cc: l.stach@pengutronix.de, bhelgaas@google.com, robh+dt@kernel.org, broonie@kernel.org, lorenzo.pieralisi@arm.com, festevam@gmail.com, francesco.dolcini@toradex.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de, linux-imx@nxp.com Subject: Re: [PATCH v15 17/17] PCI: imx6: Reformat suspend callback to keep symmetric with resume Message-ID: <20220718131900.GA4002775@roeck-us.net> References: <1657783869-19194-1-git-send-email-hongxing.zhu@nxp.com> <1657783869-19194-18-git-send-email-hongxing.zhu@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1657783869-19194-18-git-send-email-hongxing.zhu@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220718_061942_290455_B23EE9C6 X-CRM114-Status: GOOD ( 10.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jul 14, 2022 at 03:31:09PM +0800, Richard Zhu wrote: > Create imx6_pcie_stop_link() and imx6_pcie_host_exit() functions. > Encapsulate clocks, regulators disables and PHY uninitialization into > imx6_pcie_host_exit(). > > To keep suspend/resume symmetric as much as possible, invoke these two > new created functions in suspend callback. > > To be symmetric with imx6_pcie_host_exit(), move imx6_pcie_clk_enable() > to imx6_pcie_host_init() from imx6_pcie_deassert_core_reset(). > > Link: https://lore.kernel.org/r/1656645935-1370-18-git-send-email-hongxing.zhu@nxp.com > Signed-off-by: Richard Zhu > Signed-off-by: Bjorn Helgaas > Reviewed-by: Lucas Stach If CONFIG_PM_SLEEP=n: Error log: drivers/pci/controller/dwc/pci-imx6.c:973:13: error: 'imx6_pcie_host_exit' defined but not used [-Werror=unused-function] 973 | static void imx6_pcie_host_exit(struct dw_pcie_rp *pp) | ^~~~~~~~~~~~~~~~~~~ drivers/pci/controller/dwc/pci-imx6.c:904:13: error: 'imx6_pcie_stop_link' defined but not used [-Werror=unused-function] 904 | static void imx6_pcie_stop_link(struct dw_pcie *pci) Guenter _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel