From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B5439C43334 for ; Mon, 18 Jul 2022 16:15:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=AFsjpQQLcTqO6ieYtoeihLje40IIP9ydF/S1/R1ox+o=; b=ucc1OcpYNGRDL0 I04wuv5gooGQJamflutmq4sJ1DZgrCE6tPEgw+7/H8tnbwicL5mvsoG2Yh0N50VMVcYD5sYoh9A9b gHz/3pTMBbrckgHGB4TX/cNHzv7QAWiZGl681Dr45Qza/zuXNsyjAPaQjVN9K5jjoXyqKMn+Cf8v6 nXOO+hQ5M1ysZj3mHO/0YDzw3R2HEdAmANBbAB2cmNFV5bxws0nH+5f4i5MH6UHd/XOCKKEf2UW27 Yczh6KgrI+Jmz+PVGX2i9gdTQ8eDnTugmnYOqwfTZL92wtpR6Be/NyLeLP8H0G4pJMcj1anSjk6ko p8DePebxk03yHiPF1+Tg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oDTOS-00GaWR-VQ; Mon, 18 Jul 2022 16:14:49 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oDTOP-00GaTD-1K for linux-arm-kernel@lists.infradead.org; Mon, 18 Jul 2022 16:14:46 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D7AA3B8167B; Mon, 18 Jul 2022 16:14:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5C2EEC341C0; Mon, 18 Jul 2022 16:14:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658160881; bh=s4BD8mdghSnJ9sX+cdo6zdbaTcPNDfDvBJGqCWlXkwM=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=eTJPbfeuhG54lKKjhcq4Zg8fuGz+sLEctjlpz2pf6RlFYTkHPG3IndqoG6scRCBof ZMhtte88JHAJWNmdPWAsZa7PHd52DlbuKkiBxdmZPZ6/hgF9U6gWkmU6qDB8frUW+5 7LMWiwCPiiJoDCb5DA3zoJaDABx//V/CGpZwUhzN+A5SViUtJztemvWu1r6NyD8Qvf 05bPbqyRIh2+E3Hdbl+PdO3Tj30y8qV/0IjKUBpLPmqCMaVUUELRIT0gVhyco+6zY4 FNHXyZ5NPIKQiqYPuNg1YG4LY4P0ADQzUok6+gvmudiLmGkDXc6DF0Ei7HmHhjMunr gme/IMt7QJuPg== Date: Mon, 18 Jul 2022 11:14:39 -0500 From: Bjorn Helgaas To: Arnd Bergmann Cc: "Sudip Mukherjee (Codethink)" , Richard Zhu , Lucas Stach , Lorenzo Pieralisi , Rob Herring , =?utf-8?Q?Wilczy=C5=84ski?= , Bjorn Helgaas , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Philipp Zabel , Liam Girdwood , Mark Brown , linux-pci , Linux ARM , Linux Kernel Mailing List , Linux-Next Mailing List Subject: Re: build failure of next-20220718 due to 'imx6_pcie_host_exit' defined but not used Message-ID: <20220718161439.GA1419930@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220718_091445_263599_81283AA0 X-CRM114-Status: GOOD ( 17.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 18, 2022 at 02:42:16PM +0200, Arnd Bergmann wrote: > On Mon, Jul 18, 2022 at 1:58 PM Sudip Mukherjee (Codethink) > wrote: > > > > Hi All, > > > > Not sure if it has been reported, builds of alpha, csky, xtensa, riscv, s390 allmodsconfig > > have failed to build next-20220718 with the error: > > > > > > drivers/pci/controller/dwc/pci-imx6.c:973:13: error: 'imx6_pcie_host_exit' defined but not used [-Werror=unused-function] > > 973 | static void imx6_pcie_host_exit(struct dw_pcie_rp *pp) > > | ^~~~~~~~~~~~~~~~~~~ > > drivers/pci/controller/dwc/pci-imx6.c:904:13: error: 'imx6_pcie_stop_link' defined but not used [-Werror=unused-function] > > 904 | static void imx6_pcie_stop_link(struct dw_pcie *pci) > > | ^~~~~~~~~~~~~~~~~~~ > > > > These are called from inside an "#ifdef CONFIG_PM_SLEEP" section. The best > fix is to remove the #ifdef and replace SET_NOIRQ_SYSTEM_SLEEP_PM_OPS() > with the new simpler NOIRQ_SYSTEM_SLEEP_PM_OPS(). Might be simpler, but wow, it's hard to keep up with all the permutations of sleep ops ;) Unfortunately 1a3c7bb08826 ("PM: core: Add new *_PM_OPS macros, deprecate old ones"), which added NOIRQ_SYSTEM_SLEEP_PM_OPS, didn't add any hints near SET_NOIRQ_SYSTEM_SLEEP_PM_OPS. We have several PCI controller drivers that use the "#ifdef CONFIG_PM_SLEEP" and SET_NOIRQ_SYSTEM_SLEEP_PM_OPS pattern or the "__maybe_unused" + SET_NOIRQ_SYSTEM_SLEEP_PM_OPS pattern. I guess we need to look at all of them and figure out the best practice. Bjorn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel