From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 89EF7C433EF for ; Mon, 18 Jul 2022 22:20:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oQSCQ4lrXmOwRMd4BntTeOrXguvcOeO1FbQ8cMEeLpw=; b=wfs9irmAk8ok0/ wNvuw5FjOxa2QdrWCphQ/3kTG9CkkuHQmiCZKGLakgmunURuCpiutJakZT4nTiFmZj0wu7U96nir8 V8qkR77cII+DeI4YmRdN1nKK+EF2gb38VtDIMknO4RI0g6zOSiuIPeR8GUuPPSNncY2RlJQc/zvPp PtrYLDTGsx/XWM2MBsiiC+FR8hEQoEp+h6niglwnZdD1IlRegVwAjW72MFTWilE/ozUSAdXEfcHCs DHI6Waso09estAzpi15zMLQvVhprrMz9wZ9AqAV+NLhheHqBe2OKNkHv6X8Jdenbhu3AV7nupe9nN ErVmZzZx6+pp0qRg3DNg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oDZ56-0023cg-Nh; Mon, 18 Jul 2022 22:19:12 +0000 Received: from madras.collabora.co.uk ([46.235.227.172]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oDZ52-0023Xd-M9 for linux-arm-kernel@lists.infradead.org; Mon, 18 Jul 2022 22:19:10 +0000 Received: from notapiano (pool-98-113-53-228.nycmny.fios.verizon.net [98.113.53.228]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madras.collabora.co.uk (Postfix) with ESMTPSA id 7A8A366019F3; Mon, 18 Jul 2022 23:19:01 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1658182742; bh=cpVbYxStkk0TBWfh3vWvgvkINPgtVFCpknaqG3L5bMU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Dse5PnL5X29rke4WJf6H2vO5GuMVfPClG3lZkbvKx+BXigza2knJVk+8uxcFG3+Nm DVDe2juLAnNjXr1s6JUVsg9z5EEdXAKQUtZ6trhIWlXE1fp1zrdcZsAP44BN7egHl3 F2NYsMgwxYObJ1/VHsHJ6j4do6ireEAM3+oppRVwslGpf3I028n+CgST8QYFsIgT0O 08p7peYZDEFsM7fpsj2oES2+1v/WtWDQIryOsgtzoCSOR+MMczJJuDSzYujjHZwz++ vDiQCbeRxkUe9pi1eIc06YdkLxAQBPzSiCcn8w/iJNk92uorvbIMKJbpbXf9HBObg0 5qUSCxAjMXxnQ== Date: Mon, 18 Jul 2022 18:18:57 -0400 From: =?utf-8?B?TsOtY29sYXMgRi4gUi4gQS4=?= Prado To: Chen-Yu Tsai Cc: Michael Turquette , Stephen Boyd , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, AngeloGioacchino Del Regno Subject: Re: [PATCH v2 1/2] clk: core: Honor CLK_OPS_PARENT_ENABLE for clk gate ops Message-ID: <20220718221857.7vgmsgqxozytkofa@notapiano> References: <20220713082111.2233016-1-wenst@chromium.org> <20220713082111.2233016-2-wenst@chromium.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220713082111.2233016-2-wenst@chromium.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220718_151908_907609_EC7A5364 X-CRM114-Status: GOOD ( 12.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jul 13, 2022 at 04:21:10PM +0800, Chen-Yu Tsai wrote: > In the previous commits that added CLK_OPS_PARENT_ENABLE, support for > this flag was only added to rate change operations (rate setting and > reparent) and disabling unused subtree. It was not added to the > clock gate related operations. Any hardware driver that needs it for > these operations will either see bogus results, or worse, hang. > = > This has been seen on MT8192 and MT8195, where the imp_ii2_* clk > drivers set this, but dumping debugfs clk_summary would cause it > to hang. > = > Fixes: fc8726a2c021 ("clk: core: support clocks which requires parents en= able (part 2)") > Fixes: a4b3518d146f ("clk: core: support clocks which requires parents en= able (part 1)") > Signed-off-by: Chen-Yu Tsai Reviewed-by: N=EDcolas F. R. A. Prado Tested-by: N=EDcolas F. R. A. Prado Tested that MT8192 no longer hangs when dumping clk_summary. Thanks, N=EDcolas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel