From: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>
To: Chen-Yu Tsai <wenst@chromium.org>
Cc: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>
Subject: Re: [PATCH v2 2/2] clk: core: Fix runtime PM sequence in clk_core_unprepare()
Date: Mon, 18 Jul 2022 18:22:32 -0400 [thread overview]
Message-ID: <20220718222232.lffgerc6qfi6jnha@notapiano> (raw)
In-Reply-To: <20220713082111.2233016-3-wenst@chromium.org>
On Wed, Jul 13, 2022 at 04:21:11PM +0800, Chen-Yu Tsai wrote:
> In the original commit 9a34b45397e5 ("clk: Add support for runtime PM"),
> the commit message mentioned that pm_runtime_put_sync() would be done
> at the end of clk_core_unprepare(). This mirrors the operations in
> clk_core_prepare() in the opposite order.
>
> However, the actual code that was added wasn't in the order the commit
> message described. Move clk_pm_runtime_put() to the end of
> clk_core_unprepare() so that it is in the correct order.
>
> Fixes: 9a34b45397e5 ("clk: Add support for runtime PM")
> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
Reviewed-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
Thanks,
Nícolas
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2022-07-18 22:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-13 8:21 [PATCH v2 0/2] clk: Fix CLK_OPS_PARENT_ENABLE and runtime PM Chen-Yu Tsai
2022-07-13 8:21 ` [PATCH v2 1/2] clk: core: Honor CLK_OPS_PARENT_ENABLE for clk gate ops Chen-Yu Tsai
2022-07-18 22:18 ` Nícolas F. R. A. Prado
2022-07-13 8:21 ` [PATCH v2 2/2] clk: core: Fix runtime PM sequence in clk_core_unprepare() Chen-Yu Tsai
2022-07-18 22:22 ` Nícolas F. R. A. Prado [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220718222232.lffgerc6qfi6jnha@notapiano \
--to=nfraprado@collabora.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox