From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0BCF1C433EF for ; Tue, 19 Jul 2022 13:38:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=U+qw9XJZaSwHINRxyx8jSKKgOrIaypTMpytqTEoHNuE=; b=O62s7jX75adl/+ RalAesH9N73T36EK5TZG0cbdwoOitsbJ1Hk4jXoUaSOc6H7L3qABXwWVGmDzPucY+ackZAsbLK0wF xmBLVZ+qr9paCJNkvSHyEPEai8q/GyfJ0j2Fj5I7XpNSpuWGCk868fuy4VgnsfUICnj07Cv9nphI9 2Bi5yHYB9KceZVu+ye4wt0nY4jBsoPwcJKP81aJeBUL144I+QC8v1xVSnS85ZRO/QU715qvmTmm2z LJYRD5IjMF/9wBJhmj1CNVF78tOPFA2jOm7NcAk7UEK5w00tS7nuS7bSXZeNVYSvccID7voa7QoXI PMIItQ36iK0yHEEtV1LQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oDnPH-009GV8-AQ; Tue, 19 Jul 2022 13:36:59 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oDnPE-009GTE-Ce for linux-arm-kernel@lists.infradead.org; Tue, 19 Jul 2022 13:36:58 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 16D69B81B10; Tue, 19 Jul 2022 13:36:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D5416C341C6; Tue, 19 Jul 2022 13:36:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658237812; bh=LgIus1vM08oJb7atpj/1Ixv/EE+zSIDg/3ScTjK636I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hc8opsDf62QaLIIbJ/8bhboVP/hhdbVhKBYx6dB3I94dx260mmGeQLkcDze6Gq6xI JXBxqA2ycpbxSD/4fyvcKM0qPo/o+JKPLAubROYEwZAjB+BKViK1xiYplGR1qidVdq 6dUcaV51IgrKQuzIStBgWxro57Iag2GgeuzVCSQ5FnewwcSZ6aEA1e0PQ3z43iLgH+ MrnO9upkv1JiDLCNxxBla63/46x+ttmowfsWhAnWF4w3Jid7rprrfXpHz4WyMD4pbq 02c+alBWnJuCYyzpIoxjY0iMNOuKBk90iM5QSm5ViMFIBGZu217ibq9PMmrvUx44M/ oV6ts8BZILgzw== Date: Tue, 19 Jul 2022 14:36:45 +0100 From: Will Deacon To: Kees Cook Cc: Sami Tolvanen , linux-kernel@vger.kernel.org, Josh Poimboeuf , Peter Zijlstra , x86@kernel.org, Catalin Marinas , Mark Rutland , Nathan Chancellor , Nick Desaulniers , Joao Moreira , Sedat Dilek , Steven Rostedt , linux-hardening@vger.kernel.org, linux-arm-kernel@lists.infradead.org, llvm@lists.linux.dev Subject: Re: [RFC PATCH v3 00/20] KCFI support Message-ID: <20220719133645.GA14089@willie-the-truck> References: <20220610233513.1798771-1-samitolvanen@google.com> <202206131001.6BA9933C@keescook> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <202206131001.6BA9933C@keescook> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220719_063656_636343_62E64F0C X-CRM114-Status: GOOD ( 21.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 13, 2022 at 10:04:12AM -0700, Kees Cook wrote: > On Fri, Jun 10, 2022 at 04:34:53PM -0700, Sami Tolvanen wrote: > > KCFI is a proposed forward-edge control-flow integrity scheme for > > Clang, which is more suitable for kernel use than the existing CFI > > scheme used by CONFIG_CFI_CLANG. KCFI doesn't require LTO, doesn't > > alter function references to point to a jump table, and won't break > > function address equality. The latest LLVM patch is here: > > > > https://reviews.llvm.org/D119296 > > > > This RFC series replaces the current arm64 CFI implementation with > > KCFI and adds support for x86_64. > > I think the "RFC" prefix for this series can be dropped. :) > > It looks to me like all of Peter's concerns have been addressed. I'd say > let's get the Clang side landed, and once that's done, land this via x86 > -tip? > > Peter and Will does this sound right to you? It touches arm64, so if > -tip isn't okay, I could take it in one of my trees? The arm64 bits look fine to me. Please just check if it conflicts horribly with -next so that we have a chance to figure out a shared branch if necessary. Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel