From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3CA82C433EF for ; Tue, 19 Jul 2022 15:06:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hQUsuYqF3tYVeJIUeRf63sDa7WrCHu3FBph6MACnemc=; b=rulmYPy29hmjKS c771Jv4mXKQVoth1fI3qU7rf74V0x4HCgfA88ai/V7ooORlYdfOAUswKpJta66yrL+7PpcqqKlYdZ bA7WVHeQY8DmVzYzb+vgmTxlt1wHNkKG22uTyZba0HqhhWVYX0oxgki8YePXJtSO1ki1sxYJ9uNAd 0wLPof2YKyICUTBDdNcnGJ+9oO9RPJIE1vVWlDyYYBoHpbKVyNxrk5kKNqbsXe6SE7+IN7Lcvv1Qj mFt09zazsigfC+e5BqwOZ1swLLVafPNACSOR6tC3fkUPI4BjP8hraL4pKfvDcePdjl41i/jg4OXKW M3FF6RRtB3PBJIXkg5sQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oDomq-009uOw-52; Tue, 19 Jul 2022 15:05:24 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oDomm-009uND-Mk; Tue, 19 Jul 2022 15:05:22 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CC52813D5; Tue, 19 Jul 2022 08:05:18 -0700 (PDT) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3948A3F70D; Tue, 19 Jul 2022 08:05:16 -0700 (PDT) Date: Tue, 19 Jul 2022 16:05:13 +0100 From: Sudeep Holla To: Conor Dooley Cc: Geert Uytterhoeven , Sudeep Holla , Linux Kernel Mailing List , Greg Kroah-Hartman , Conor Dooley , valentina.fernandezalanis@microchip.com, Vincent Guittot , Dietmar Eggemann , Qing Wang , Rob Herring , "Rafael J . Wysocki" , Ionela Voinescu , Pierre Gondois , Linux ARM , linux-riscv , Gavin Shan Subject: Re: [PATCH v6 09/21] arch_topology: Add support to parse and detect cache attributes Message-ID: <20220719150513.a525arh663qlhkob@bogus> References: <20220704101605.1318280-1-sudeep.holla@arm.com> <20220704101605.1318280-10-sudeep.holla@arm.com> <73f9d00c-b64c-7c70-c49f-99d3894fad24@conchuod.ie> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <73f9d00c-b64c-7c70-c49f-99d3894fad24@conchuod.ie> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220719_080520_810736_A8098E29 X-CRM114-Status: GOOD ( 16.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jul 19, 2022 at 03:37:22PM +0100, Conor Dooley wrote: > On 19/07/2022 15:22, Geert Uytterhoeven wrote: > > Hi Sudeep, > > > > Hey Geert, > [...] > > > > This is triggered > > > > Early cacheinfo failed, ret = -12 > > > > on all my RV64 platforms (K210, PolarFire, StarLight). > > This should be fixed by Sudeeps most recent patchset, at least > it was when I tested it! > https://lore.kernel.org/all/20220713133344.1201247-1-sudeep.holla@arm.com/ > Conor you beat me in the response speed :). > > -12 = -ENOMEM. > > > > The boot continues regardless, and the K210 even has enough spare > > RAM after boot to run "ls", unlike two weeks ago ;-) > > Yes Conor initially reported this and I suspected something to do with per-cpu allocation as the early cacheinfo failed but succeeded in device initcall level. However when fixing some hotplug issue, I moved the detection of cache attributes on all cpus from boot cpu to individual CPUs in the secondary startup which seem to fix the issue as I assume the per-cpu allocation is ready to use at that stage. However we still have one pending issue[0] to address even after [1], but that doesn't affect DT platforms. -- Regards, Sudeep [0] https://lore.kernel.org/all/20220718174151.GA462603@roeck-us.net/ [1] https://lore.kernel.org/all/20220715102609.2160689-1-sudeep.holla@arm.com/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel