From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D1721C433EF for ; Tue, 19 Jul 2022 15:39:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jj6j5RAkAZ3FDf9ImAcCBR1+7logVq0w4uD1NjOkwWg=; b=kopJoIDSwGPRow ptVtK03GUcUruJB2ELHaIz9f4TJ/G1zA9IWgrdtPN2YvRbaLRC0gU8NOKh7NlGAmlutN8m8OKNbE2 WU93BhxRHye6t193aQw3whqdwbZxMaWEkbsLpaQbOPcY8L1Poo7Wd43vcwh9W+0euBvwWz43yVNi0 QiFzzb+fsRG+fzeHHSFtCbfp7OoGDsGvPFMjNxwqtLvSt93AxtXt6QJyryv2waJQruL/BXbzD9Lyh cECQ9DmKcqnboRuNbDDyHGLidcMsiKuXaAy34WeNuN+RZp/+7yoPJhIOCkopIFv65dOeXwBOiOXa/ yHtEfbdbJgwWk6Nvty7g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oDpIk-00A98w-Cr; Tue, 19 Jul 2022 15:38:22 +0000 Received: from mail-ej1-x62d.google.com ([2a00:1450:4864:20::62d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oDpIg-00A96U-9a for linux-arm-kernel@lists.infradead.org; Tue, 19 Jul 2022 15:38:19 +0000 Received: by mail-ej1-x62d.google.com with SMTP id tk8so16553928ejc.7 for ; Tue, 19 Jul 2022 08:38:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=qnD9woDxfn+LSOscfoHzvBXGTCCBlK5kWUK/hmrm5mc=; b=Fk80keQB94yN1hbOFQ/8Ik5Dn9qiQizXFjlxyiFnOIDjj72zZryknDAIRwKat35COn +g0IvgCMxP7p10jhYIzT40U5BaoqkG0DTfQu17WaQl7LSW8FbPLWr5beE0bClHN7vfI5 QX0wRoDtYjxJn3mp/8Utao5/XI+8/wOB29nWOvd5Mof/UnO/Pv3D4ytDzD2qfzp0Kbe8 aDhWld/Pid6oLQ2LEXnCXrybVDU0psRQKzsCromDxv98lw1l2FKTcgPkGgRuG7QQhIW1 kfs6zo4Tzg+qSTSQep4w+4prkaQm2Lx2E3nx4DiI6udE/ynQaH1Hc7VAfFKu8qGrudA3 jygA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=qnD9woDxfn+LSOscfoHzvBXGTCCBlK5kWUK/hmrm5mc=; b=lHb382Nytsa0T8C2hzgR4T+cZVl6fVZ/nQWjlT97Ae7atb1zNLr6qS4dfj/6smFbAr Bd/7H6IxNWcLtQyPVKFbas0V1PQMz366rz5g5VXTBBNmyaUk4+7FyYnRMH/OYOjhb71a QoqsdE2KeH00I8ghJc0iBdAWVOj64unQXDqYdZzjZyLLeBmKA5D/UJBZfNVf0vu7QVpj Qxp7V4mOKcmVYC6tbjc6YReCEUUAhthNn8Z41SA0qXShmDqQ1F9xdGbLMCyIbGrDr+ci fwCWNt0EXPP0OLj0ki0uPc6alp6XGuR/BwmkhlKSfPsbMpOsMZxvFm7W5geUrtwEciU0 m/2Q== X-Gm-Message-State: AJIora94qlMGwo2Z+SmGwn4Dad7C5fmq5bdLK8Xj5O+idJ8F9md1yuSp +1BzHkzu9lO+lcgDVPG2t6M= X-Google-Smtp-Source: AGRyM1sF+tywVSO3QfunBktfmfaVi0fddzmm/dxFRUi3UiykwFMhU7B4f2YxJkBqXVs7l0XmJXPUNw== X-Received: by 2002:a17:907:16ab:b0:72c:7533:7262 with SMTP id hc43-20020a17090716ab00b0072c75337262mr29330300ejc.288.1658245095723; Tue, 19 Jul 2022 08:38:15 -0700 (PDT) Received: from skbuf ([188.27.185.104]) by smtp.gmail.com with ESMTPSA id s9-20020a170906a18900b00722e5b234basm6939832ejy.179.2022.07.19.08.38.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Jul 2022 08:38:14 -0700 (PDT) Date: Tue, 19 Jul 2022 18:38:11 +0300 From: Vladimir Oltean To: Sean Anderson Cc: Heiner Kallweit , Russell King , netdev@vger.kernel.org, Jakub Kicinski , Madalin Bucur , "David S . Miller" , Paolo Abeni , Ioana Ciornei , linux-kernel@vger.kernel.org, Eric Dumazet , Andrew Lunn , Alexandre Belloni , Benjamin Herrenschmidt , Claudiu Manoil , Florian Fainelli , Frank Rowand , Krzysztof Kozlowski , Li Yang , Michael Ellerman , Paul Mackerras , Rob Herring , Saravana Kannan , Shawn Guo , UNGLinuxDriver@microchip.com, Vivien Didelot , Vladimir Oltean , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [RFC PATCH net-next 0/9] net: pcs: Add support for devices probed in the "usual" manner Message-ID: <20220719153811.izue2q7qff7fjyru@skbuf> References: <20220711160519.741990-1-sean.anderson@seco.com> <20220719152539.i43kdp7nolbp2vnp@skbuf> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220719_083818_380923_18EC3103 X-CRM114-Status: GOOD ( 31.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jul 19, 2022 at 11:28:42AM -0400, Sean Anderson wrote: > Hi Vladimir, > > On 7/19/22 11:25 AM, Vladimir Oltean wrote: > > Hi Sean, > > > > On Mon, Jul 11, 2022 at 12:05:10PM -0400, Sean Anderson wrote: > >> For a long time, PCSs have been tightly coupled with their MACs. For > >> this reason, the MAC creates the "phy" or mdio device, and then passes > >> it to the PCS to initialize. This has a few disadvantages: > >> > >> - Each MAC must re-implement the same steps to look up/create a PCS > >> - The PCS cannot use functions tied to device lifetime, such as devm_*. > >> - Generally, the PCS does not have easy access to its device tree node > >> > >> I'm not sure if these are terribly large disadvantages. In fact, I'm not > >> sure if this series provides any benefit which could not be achieved > >> with judicious use of helper functions. In any case, here it is. > >> > >> NB: Several (later) patches in this series should not be applied. See > >> the notes in each commit for details on when they can be applied. > > > > Sorry to burst your bubble, but the networking drivers on NXP LS1028A > > (device tree at arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi, drivers > > at drivers/net/ethernet/freescale/enetc/ and drivers/net/dsa/ocelot/) > > do not use the Lynx PCS through a pcs-handle, because the Lynx PCS in > > fact has no backing OF node there, nor do the internal MDIO buses of the > > ENETC and of the switch. > > > > It seems that I need to point this out explicitly: you need to provide > > at least a working migration path to your PCS driver model. Currently > > there isn't one, and as a result, networking is broken on the LS1028A > > with this patch set. > > > > Please refer to patches 4, 5, and 6. I don't understand, could you be more clear? Are you saying that I shouldn't have applied patch 9 while testing? When would be a good moment to apply patch 9? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel