From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 49E02C433EF for ; Wed, 20 Jul 2022 01:08:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wfPMsomYUCqgDBnT7X91ViVw6uPE9pWSwTQyrvFUrIE=; b=d2FC316de1KulR Fzuz1yC1c+ynQVeDz9DGyC3FlYAOXGFQ/e810lOssyY2EDkZ7vM+S7vgTQBOr+GRSIo5TcZLm4Jxm 2+byzcwWNY3O9t9NlHCK+RaarNMOwFVRLZrj0mow0lLBiCfVGyYAo2bMXv2ciajgwTQd+310NprH2 x4yAgAl7HG53/UuuZIbeG6eK3BsSL9cnBBXzz5z567ZKDx0o58YUSjXExFbIfqjPQvk4F7lmLdjwW niFVyMV1zhDrNgX8+lkisdOMvoDDypNm41rvT3gXQ0LqVvZhE6wDC80AEV/ysXwIuGwAvwRy7JFST lZ5CT4Ykv8k0ktwbLCfA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oDyBC-00FKyV-6a; Wed, 20 Jul 2022 01:07:10 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oDyB9-00FKwI-Py for linux-arm-kernel@lists.infradead.org; Wed, 20 Jul 2022 01:07:08 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2A1BD61724; Wed, 20 Jul 2022 01:07:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 26920C341CA; Wed, 20 Jul 2022 01:07:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658279226; bh=VZKQyUqkgOyxor/CL4FV3kbbmHu2L+VLW6W/lsqp7cU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ecce4uPTOaJ7kVbgFxANyF8ec/qlzYu22XOUCG8lM6f6LZmPKb0D098n+do+fLQWi TWUCc0v2qMOkPdEXf4nJ79DrdbyZaCDY6PWVkieUkH9wsv9l4KeOZS4rErVA0PKJtX CDhQlBc73y4KlP4UeThiBzOZj3bG0BKF+ZG0s9PWGxDvW0XZ4UjSackLrDeEWVVyno Qx9K0ZKUUQcHtFaxdCET2qNY7ImAHhZz6JBXBRMA0GOk3CHok+sNu8wuyO5dsP0Zmn OQp3dkMorYONzOH8Gll/+0GYtWXhg/GSKyXwGkfBm05ODVfBVveVe5xeFxei3cT9g9 R7InpEGCGkcHg== Date: Tue, 19 Jul 2022 18:07:05 -0700 From: Jakub Kicinski To: Christian Marangi Cc: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , Paolo Abeni , Maxime Coquelin , Russell King , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [net-next PATCH v4 4/5] net: ethernet: stmicro: stmmac: generate stmmac dma conf before open Message-ID: <20220719180705.45208cb0@kernel.org> In-Reply-To: <20220719013219.11843-5-ansuelsmth@gmail.com> References: <20220719013219.11843-1-ansuelsmth@gmail.com> <20220719013219.11843-5-ansuelsmth@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220719_180707_914050_77441B3C X-CRM114-Status: GOOD ( 13.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 19 Jul 2022 03:32:18 +0200 Christian Marangi wrote: > Rework the driver to generate the stmmac dma_conf before stmmac_open. > This permits a function to first check if it's possible to allocate a > new dma_config and then pass it directly to __stmmac_open and "open" the > interface with the new configuration. You missed one kdoc: > @@ -1711,9 +1744,11 @@ static int init_dma_rx_desc_rings(struct net_device *dev, gfp_t flags) > * and allocates the socket buffers. It supports the chained and ring > * modes. > */ > -static int __init_dma_tx_desc_rings(struct stmmac_priv *priv, u32 queue) > +static int __init_dma_tx_desc_rings(struct stmmac_priv *priv, > + struct stmmac_dma_conf *dma_conf, > + u32 queue) > { drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:1750: warning: Function parameter or member 'dma_conf' not described in '__init_dma_tx_desc_rings' _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel