From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E9E16C43334 for ; Tue, 19 Jul 2022 21:48:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=KQ0wFN7T8siibTe5KdT7kWFMQETP0vytLMeIHOUC3Fs=; b=cZudXLYje1ndQV T9lo6euosoWpnUzIvEZ/Tq8+H01p6FDRhskOUTDz7muOUT6sBFm9IIQY98/KkjDXDBOpKp+AYxMMj 5bpDK3NjAkT2ENjWvqRRN8jzESzU6DoVokGpWU2ViBpP2qKOS9j9khMtGGutEOwsUzLnzWHpnrWAM TsVT1cnWd9p7IEuCX+G/m62euEFWqhJrpptOVWa1Q4mqAZzUQI2DFfZEXG2NMJ9XhGYQ4MMLgjvuY yXvocXpd33ajFc0XS/WeCe5GzZctnGVftIlA4wa4djudGFIU899xDL9Y5/26U9NASAud3hGn/yHS8 /v/rRlmrobSaexVU/NRw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oDv48-00DNch-FF; Tue, 19 Jul 2022 21:47:40 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oDv44-00DNZb-Kw for linux-arm-kernel@lists.infradead.org; Tue, 19 Jul 2022 21:47:38 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 5E097B81D41; Tue, 19 Jul 2022 21:47:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D677AC341C6; Tue, 19 Jul 2022 21:47:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658267253; bh=O42Z258w1PIvhpxARBaZzfdZtfjXU2aRWZ6tg2rNQOQ=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=B9oF9d15v/hGpyZDpEV+SpZWCp9lZrWaF9C+BJRV383twPU0WAoq/O/BYEWsHIT99 kWGXGLdw7ijk6H0bJzVjEZNMZzLwTp/29GERcg7smrYFW/GdYxvrYCRaydyFUOUaR7 GZxwxZTHOfpN9+W31pS4mvfyHiAhlLPirFtsLVsh1M8GmUrTQzlIn3BAnyo1Im4sTy XkXB4bfP7TfdbbRssRn1TYKwmIxMaFGfKX9EVeNfKRMreenc0Ibe62lbI2AN2G/NCU kMdQoWnYUSP/P/81B8PUMvwmOhXUQ5/YpGahMbzRWN+K64zi28k5GhZTlmtZMEcLTZ UnVw0QFbptxGg== Date: Tue, 19 Jul 2022 16:47:31 -0500 From: Bjorn Helgaas To: Arnd Bergmann Cc: "Sudip Mukherjee (Codethink)" , Richard Zhu , Lucas Stach , Lorenzo Pieralisi , Rob Herring , =?utf-8?Q?Wilczy=C5=84ski?= , Bjorn Helgaas , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Philipp Zabel , Liam Girdwood , Mark Brown , linux-pci , Linux ARM , Linux Kernel Mailing List , Linux-Next Mailing List Subject: Re: build failure of next-20220718 due to 'imx6_pcie_host_exit' defined but not used Message-ID: <20220719214731.GA1582549@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220719_144736_970137_FD1DEB67 X-CRM114-Status: GOOD ( 15.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jul 19, 2022 at 11:16:40PM +0200, Arnd Bergmann wrote: > On Tue, Jul 19, 2022 at 11:04 PM Bjorn Helgaas wrote: > > > > commit 0e4daeaa52ca ("PCI: imx6: Convert to NOIRQ_SYSTEM_SLEEP_PM_OPS()") > > Author: Bjorn Helgaas > > Date: Tue Jul 19 15:50:18 2022 -0500 > > > > PCI: imx6: Convert to NOIRQ_SYSTEM_SLEEP_PM_OPS() > > > > Replace SET_NOIRQ_SYSTEM_SLEEP_PM_OPS() with NOIRQ_SYSTEM_SLEEP_PM_OPS(), > > which has the advantage that the compiler always sees the PM callbacks as > > referenced, so they don't need to be wrapped with "#ifdef CONFIG_PM_SLEEP" > > or tagged with "__maybe_unused" to avoid "defined but not used" warnings. > > > > See 1a3c7bb08826 ("PM: core: Add new *_PM_OPS macros, deprecate old ones"). > > > > Signed-off-by: Bjorn Helgaas > > Reviewed-by: Arnd Bergmann Thanks! And sorry about being crabby earlier. If this allows us to get rid of those #ifdefs and __maybe_unused, it's a great improvement! Bjorn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel