From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6B15CC433EF for ; Tue, 19 Jul 2022 23:12:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=9/YKaFflKfchL7Ifn0tw/erzSEb7wdy9tGNYWRZQ/Zs=; b=kfCcBC+Ag1hQ7u Mp611pLPHC+Df8RGgINZ14z/15skj/4uX4uHI/RXn8VTOUJdgRhXFq0ttAwhMqJDGUk11I5uUNTEK So/0iPZEgZJj4ZAAP6r/h9adXbLDCC+UiNvCJdNk5XbJPDIjDUlGNDIO5wK9QhN3b2IZhMsaGRgGq I+M6LbJM3ByLMm8TYipx1pQzKnMy+URE+Md7D54mchVEpx5kxzeiiQGAlIEGrqJ9tn2i3H2uUG2v/ ObfQAd5eIpNRB+2Nw/p35oYvlQlCGOEMe1bF8hbhXlviu75TKjIe8bMezX1UhvZNXnRIp68y8ngkh Qind4npDzg5fwsjsM8mA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oDwMt-00EI7R-Bu; Tue, 19 Jul 2022 23:11:07 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oDwMp-00EI4y-Ut for linux-arm-kernel@lists.infradead.org; Tue, 19 Jul 2022 23:11:05 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 672FEB81D0D; Tue, 19 Jul 2022 23:11:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DC9EAC341C6; Tue, 19 Jul 2022 23:11:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658272261; bh=SILE2Uf05N+hXwooEnGRd9dVKavfRJ4L+hm1oY80Jow=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=bspYiaxgsVhdVPLVSuLrqojP/Sa/fCUWvaUwM8wfSa2d9mphEFlKitZv6oE8CRZvE asworTjG0vWTKG3B8qo0IzpECWCLOC33txj0F3MXA8fZyywh1vQIFpcv1metKcR7Cl z+hWenwuWcYKkMJlK7sOaPQTGFj2e4C5pP14p6EIfnKo3Fsha5LLgG82KUBOk+yJv1 brSkHXqlkD9xe97C0hIlWkbPcrAglqF8OxtMHWET0XC5vagTKdZmZcIYPR5AzaN7Dy lIFSpV27D/LsjepSLOpnfv2B+G3klSsHHAjsAaZZ/BXfsIEMR586l8pC4Sa6CVuud+ cejevhtQ0QQTA== Date: Tue, 19 Jul 2022 18:10:59 -0500 From: Bjorn Helgaas To: Guenter Roeck Cc: Richard Zhu , l.stach@pengutronix.de, bhelgaas@google.com, robh+dt@kernel.org, broonie@kernel.org, lorenzo.pieralisi@arm.com, festevam@gmail.com, francesco.dolcini@toradex.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de, linux-imx@nxp.com Subject: Re: [PATCH v15 17/17] PCI: imx6: Reformat suspend callback to keep symmetric with resume Message-ID: <20220719231059.GA1590187@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220718131900.GA4002775@roeck-us.net> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220719_161104_155985_67D00D8F X-CRM114-Status: GOOD ( 13.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 18, 2022 at 06:19:00AM -0700, Guenter Roeck wrote: > On Thu, Jul 14, 2022 at 03:31:09PM +0800, Richard Zhu wrote: > > Create imx6_pcie_stop_link() and imx6_pcie_host_exit() functions. > > Encapsulate clocks, regulators disables and PHY uninitialization into > > imx6_pcie_host_exit(). > > > > To keep suspend/resume symmetric as much as possible, invoke these two > > new created functions in suspend callback. > > > > To be symmetric with imx6_pcie_host_exit(), move imx6_pcie_clk_enable() > > to imx6_pcie_host_init() from imx6_pcie_deassert_core_reset(). > > > > Link: https://lore.kernel.org/r/1656645935-1370-18-git-send-email-hongxing.zhu@nxp.com > > Signed-off-by: Richard Zhu > > Signed-off-by: Bjorn Helgaas > > Reviewed-by: Lucas Stach > > If CONFIG_PM_SLEEP=n: > > Error log: > drivers/pci/controller/dwc/pci-imx6.c:973:13: error: 'imx6_pcie_host_exit' defined but not used [-Werror=unused-function] > 973 | static void imx6_pcie_host_exit(struct dw_pcie_rp *pp) > | ^~~~~~~~~~~~~~~~~~~ > drivers/pci/controller/dwc/pci-imx6.c:904:13: error: 'imx6_pcie_stop_link' defined but not used [-Werror=unused-function] > 904 | static void imx6_pcie_stop_link(struct dw_pcie *pci) Thanks, Guenter, I added a patch that should fix this: https://lore.kernel.org/r/20220719210427.GA1568454@bhelgaas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel