From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D942EC433EF for ; Wed, 20 Jul 2022 22:09:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=xXKWBvr7404GPm/xVNeh43iaOYfvNIS2uQ9CkBSY1Yw=; b=jF6xDuwbAdUvJC 7ObKegYukcbfbfhLhSuoq4+LpbmJ9Cq08sxqQbJTCjsCLw1DAJ43lT/XysaBW6OjVcq6pprk4nm6M PX0laOiuPBtBBq1Y3zNkNBoN33yGTozqysxjNp2ASWh8bGSdiqEgIxuVsL/US6qhMz9AT1cyMLOuL tsPZqt9bi5zL0ltGOAoLILgXX7gtN+Fql49ljyP3x5XHq96o0WTq3k/syq73MOz5PIQARPZbRk2Rb YZ1+x5Rdf9mTixotCjbMC1NeuOjIHGWrzez8XBjNBVC96NtAXCvirih/HSXCX3pOQWWlYeTfsoVAe hB57yMe1VbFsCtA7dJ1A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oEHs7-00C5gn-O7; Wed, 20 Jul 2022 22:08:47 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oEHs4-00C5TS-RR; Wed, 20 Jul 2022 22:08:46 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6E47A61D26; Wed, 20 Jul 2022 22:08:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A0374C341C7; Wed, 20 Jul 2022 22:08:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658354921; bh=6NPJbp8qd++ZJMzUvD/xwkV8ieUhuhN8noME2rFU4ao=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=vImESz6H+FmCQBQFGg6RwGB1qUexGM88QKZgQo2j6EKPY9DUkTE6WFlJPsdKOsCWi tQgqkpnO/efA4PMFoBcERZacJUh+sxI/8da7uS/J3ZLjQBaH14ge3TBLfQ84Quu8N2 Qa53LZ9RqK3fgLnWTzhKfjknNgTBxaZrDNSO/+m9rFQMvTj8DyA7FFqpKQIBhfOzlq 1I3rb8cNi9M3B7g3A8kyb+fnHdVoocE9k42ZA9u6WalZammMd5HRfK/qiJu7Ei2KB0 uxQfIc4IfRU2n7z27cZgp3L70A5knqsvG9bc0ifZ8OxsFfZY9lVJ/0gXMNTPo92m+d k4LfG3JnkObvg== Date: Wed, 20 Jul 2022 17:08:40 -0500 From: Bjorn Helgaas To: Jim Quinlan Cc: linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Bjorn Helgaas , Lorenzo Pieralisi , Cyril Brulebois , bcm-kernel-feedback-list@broadcom.com, james.quinlan@broadcom.com, Florian Fainelli , Lorenzo Pieralisi , Rob Herring , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , open list Subject: Re: [PATCH v2 3/6] PCI: brcmstb: Add "refusal mode" to preclude PCIe-induced CPU aborts Message-ID: <20220720220840.GA1663326@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220716222454.29914-4-jim2101024@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220720_150844_946198_CB9008E7 X-CRM114-Status: GOOD ( 11.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Jul 16, 2022 at 06:24:50PM -0400, Jim Quinlan wrote: > Our PCIe RC HW has an atypical behavior: if it does not have PCIe link > established between itself and downstream, any subsequent config space > access causes a CPU abort. This commit sets a "refusal mode" if the PCIe > link-up fails, and this has our pci_ops map_bus function returning a NULL > address, which in turn precludes the access from happening. > @@ -687,6 +688,19 @@ static void __iomem *brcm_pcie_map_conf(struct pci_bus *bus, unsigned int devfn, Oh, and I forgot to mention that brcmstb is one of the few drivers that doesn't name these functions ".*_map_bus()". It's helpful when they all match a simple grep pattern. Maybe a patch at the end could fix this. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel