From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 45B71C433EF for ; Wed, 20 Jul 2022 22:43:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=YRDnGhgu8Sbm1laE7XDaJJQIurrc5PKmfKNH/tMoBJU=; b=F/gEtbRz2NZygE YTx/V7yJ97rSE4SZklhXnbuJtDH6LzUg9RrJSrMc3FN91IJy7jG+cAKpYhLwxt1L6DOPodnIGrfgJ ZVJMgRksFbDToYmUtiiyD3rb+fdZIO2w3JJvb6y75snE7KKw4+IYJr0naqoVgLIYNkgRO7Zmrd/TS d7HxHU3V5KXE/iYbjt4Dr+OHfEd1+Y3QRbBxpcia/9xP65RL35fnzNnjXuZf4UM6uT8y0GjApynOS lPG1AqDhOCoZ2gArgldIuxu4c+6cTYtQD2ZaW/8vfOmcW6bBbn1pHulJPPgOKkxsrb9fOnO42kufS xPphp701LCGLuRxpblqA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oEIP1-00CahN-4Y; Wed, 20 Jul 2022 22:42:47 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oEIOx-00CaeJ-Dl; Wed, 20 Jul 2022 22:42:44 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C53F8B82210; Wed, 20 Jul 2022 22:42:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2933FC341C7; Wed, 20 Jul 2022 22:42:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658356960; bh=1V98A2z1F38fHHvrHBoo3HaWj6yGKB/FnX3vGN/AvvA=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=m79q/3nOeKxO56yGLe38LNngUjS5YlwsOdqK12cNE9FC0rQpA5M2cKg/8rHwh60Z5 BPAAVPRoJ5JJmqHBUcAX4ttH61aNg6RrVZ65eqZElDOUIG3z1nT5nL8QdLrXM/RAi5 y0YlLlcHVolcpqBmOq/O70j4oT9+v54KkULa09nMFF0etcuRk2rnIcjvozDv+tp+OV rqo9SjfsM4FuruB28UMpLNS7Oru40GeOfbHjKn3kYTXRQo98BK6Z3F6sfIuqGEW7Ik eCHm/TKEeRLSeVUFF5Bf/qzKi+i6Dt2/JQShBjFekRlJOmVNQaQUA+aekpY3hRDynf 2QFzdbfgbYpxg== Date: Wed, 20 Jul 2022 17:42:38 -0500 From: Bjorn Helgaas To: Stafford Horne Cc: LKML , Arnd Bergmann , Pierre Morel , Geert Uytterhoeven , Catalin Marinas , Will Deacon , Guo Ren , Paul Walmsley , Palmer Dabbelt , Albert Ou , Richard Weinberger , Anton Ivanov , Johannes Berg , Bjorn Helgaas , linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-riscv@lists.infradead.org, linux-um@lists.infradead.org, linux-pci@vger.kernel.org, linux-arch@vger.kernel.org Subject: Re: [PATCH v4 3/3] asm-generic: Add new pci.h and use it Message-ID: <20220720224238.GA1666095@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220720131934.373932-4-shorne@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220720_154243_630485_FD8E9CD7 X-CRM114-Status: GOOD ( 13.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jul 20, 2022 at 10:19:34PM +0900, Stafford Horne wrote: > The asm/pci.h used for many newer architectures share similar > definitions. Move the common parts to asm-generic/pci.h to allow for > sharing code. > > One thing to note: > > - ARCH_GENERIC_PCI_MMAP_RESOURCE, csky does not define this so we > undefine it after including asm-generic/pci.h. Why doesn't csky > define it? > > Suggested-by: Arnd Bergmann > Link: https://lore.kernel.org/lkml/CAK8P3a0JmPeczfmMBE__vn=Jbvf=nkbpVaZCycyv40pZNCJJXQ@mail.gmail.com/ > Acked-by: Pierre Morel > Acked-by: Geert Uytterhoeven > Signed-off-by: Stafford Horne > diff --git a/arch/arm64/include/asm/pci.h b/arch/arm64/include/asm/pci.h > index 0aebc3488c32..016eb6b46dc0 100644 > --- a/arch/arm64/include/asm/pci.h > +++ b/arch/arm64/include/asm/pci.h > -extern int isa_dma_bridge_buggy; Shouldn't this go in the previous patch? The only definition of a isa_dma_bridge_buggy variable is in drivers/pci/pci.c, and it's under #ifdef CONFIG_X86_32. Same for csky, riscv, um? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel