From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 03602C433EF for ; Thu, 21 Jul 2022 07:10:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EyVXpNdeaPeebecFsiP1y9YWDtgfPnaeDEFACDa+nHU=; b=O9U9f4W/R42Spp P1DgRNhDH2D3KuIVR7Zel5ay4wNHJKibb1Rj6uXcnJyYVEBg26IYjmRgLjH5a4weFcPLAfT5Jsr02 vKcoHELyBZfyLIKIUGa+v8JG5U5CH2okAor5GQa4iZp5IVZbMspR1eTXYUzv2QEk6Tds0s3+gnPBk HyxFAOyzR1BUJETsf3P9UrGtIhBFhIUdvkOphGVoea6L4bSrjbJlOdvjBYSp7UApBtbIxubLucT0c BzY/TUYfa5XoIjHeXVMeF5TbBVDXP3MJabtNO3MVorj2Bl9n0+h3cmF8sQTeQcyLuZqVwrBY0YEjW tNkjb+qEgOSE6XblZdhQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oEQJO-001VMH-GV; Thu, 21 Jul 2022 07:09:30 +0000 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oEQJJ-001VEO-L3 for linux-arm-kernel@lists.infradead.org; Thu, 21 Jul 2022 07:09:28 +0000 Received: by mail-wr1-x42b.google.com with SMTP id k11so453180wrx.5 for ; Thu, 21 Jul 2022 00:09:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=VXozGTkBuN1pc/ZCQCCgyPsWzMv13rxWxDP+7tq7TJw=; b=D4clmYGbwyS4ogHfjdMc0g0hg0J9Quux7dEE5ZiwsDNyFKCENhfLWl0lPlCnZZWCQJ ADYbbcZ2MSNLjFOnls9NFk+73wCzHxH5smZAn8ihwNtOfRTJu9p0uf+fKfJIxoDoqoR4 BuNi+gA4dFpgVVQeyCkI8CnQhWjHYdWLjjK8xN9/NNiHL4EKaQgZ7oZxRWqRVfYmb7dn WdFkNHm92qb2xcXSG21B2sNdPmAixmmvn1Yw0m4SXab3b95hkN8uwO1grTDLXTeqwYcF fg825u2vNg0tXdjqsM2uh/mDNSNRUXHVm/VgmUVz76t6u9QsIzhxnzpu0W4D+wXRCNRb DUsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=VXozGTkBuN1pc/ZCQCCgyPsWzMv13rxWxDP+7tq7TJw=; b=KrljZnpkcAV17fnuuOxQzYe2OGF+dSyMLe5iad7xnx/hsYChOM9jVG2+9Z9nkgIVWE sbRscC74IVmlDzk6XM/ciZPHi+g272S7j3FDll/u1o0bkiPHwB26sJm2f1x8+x1o95Y0 DbNxmAUNgUyu0HYMKScflCD7UPxBThGPT5t2GXeKbNGy/qKnjOGIW8U5+KKZ3ESfMpHh rL0pM3sLpRwR5vqofIqL3Ju7/dLXcHpvwKDT6vibbKKWoYfuewbcl1WiLCpSrxfvE/29 8xIQM6re8WLiX/6z38FSYYyugJcr78fXm6/i3CcL46Bwc4FpGhPJSMvuULDrLJIEXEgS Yn9Q== X-Gm-Message-State: AJIora/SlvxONmYzD1uXEmGLakU/B46v5MI074NXwkOD4tLvyhQtGUcs 3UhLaTVmKr2WDOVmdaLYwrcmXn5MEi9IUw== X-Google-Smtp-Source: AGRyM1uimq2XmA1Z+1x9bodyzH3DDOeO/EH1oMDau48adGSTkIKD3g2y2p5VAb0Pt5outtsag+HW1w== X-Received: by 2002:adf:ee0f:0:b0:21d:6e3b:d262 with SMTP id y15-20020adfee0f000000b0021d6e3bd262mr32237238wrn.687.1658387362894; Thu, 21 Jul 2022 00:09:22 -0700 (PDT) Received: from blmsp ([2001:4090:a243:806e:25e7:daa:8208:ceb]) by smtp.gmail.com with ESMTPSA id y3-20020a7bcd83000000b003a3253b706esm4713951wmj.34.2022.07.21.00.09.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Jul 2022 00:09:21 -0700 (PDT) Date: Thu, 21 Jul 2022 09:09:20 +0200 From: Markus Schneider-Pargmann To: Rob Herring Cc: Jerome Neanne , lgirdwood@gmail.com, broonie@kernel.org, nm@ti.com, kristo@kernel.org, khilman@baylibre.com, narmstrong@baylibre.com, j-keerthy@ti.c, lee.jones@linaro.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v1 04/14] regulator: dt-bindings: tps65219: Add power-button property Message-ID: <20220721070920.dymqnh25dtqysooe@blmsp> References: <20220719091742.3221-1-jneanne@baylibre.com> <20220719091742.3221-5-jneanne@baylibre.com> <20220720233906.GB4187584-robh@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220720233906.GB4187584-robh@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220721_000925_938765_C7D4864D X-CRM114-Status: GOOD ( 19.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Rob, On Wed, Jul 20, 2022 at 05:39:06PM -0600, Rob Herring wrote: > On Tue, Jul 19, 2022 at 11:17:32AM +0200, Jerome Neanne wrote: > > From: Markus Schneider-Pargmann > > > > Add a power-button property to configure the EN/PB/VSENSE pin as a > > powerbutton. > > Belongs in the first binding patch. > > > > > Signed-off-by: Markus Schneider-Pargmann > > Signed-off-by: Jerome Neanne > > --- > > Documentation/devicetree/bindings/regulator/ti,tps65219.yaml | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/regulator/ti,tps65219.yaml b/Documentation/devicetree/bindings/regulator/ti,tps65219.yaml > > index 6a60e62a313c..3f7f4c0280c3 100644 > > --- a/Documentation/devicetree/bindings/regulator/ti,tps65219.yaml > > +++ b/Documentation/devicetree/bindings/regulator/ti,tps65219.yaml > > @@ -36,6 +36,11 @@ properties: > > include/dt-bindings/interrupt-controller/irq.h > > const: 1 > > > > + power-button: > > ti,power-button > > Though doesn't 'system-power-controller' imply this? No, there is a difference between system-power-controller and power-button. If you ask, my description is probably not clear enough. Let me try a new one: TPS65219 has a multipurpose pin called EN/PB/VSENSE that can be either EN in which case it functions as an enable pin. It can be VSENSE which compares the voltages and triggers an automatic on/off request. And it can be PB in which case it can be configured to trigger an interrupt to the SoC. ti,power-button reflects exactly the last one of those options where the board has a button wired to the pin and triggers an interrupt on pressing it. I hope that answers your question. We will fix the description in v2. Thanks, Markus > > > + type: boolean > > + description: Optional property that sets the EN/PB/VSENSE pin to be a > > + power-button. > > + > > patternProperties: > > "^buck[1-3]-supply$": > > description: Input supply phandle of one regulator. > > -- > > 2.17.1 > > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel