From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BB03BC433EF for ; Fri, 22 Jul 2022 17:39:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SnhXlIjsmRApuXtDkCBM8i49Dxq3chRQwSZBxKG0lCg=; b=ck8AqvCu6gey2N IotJGYpxora8yTQRp2arp616bRYHmLUxROjxehU8i2eYycxYqM5Ddk1V0TOMZtvoj1XbUolxuzWlp EQFsBmxuTvVQMYbelobno3n58Ir23xELsUoNyv1GGbErB4el9UUBm6+1hKSHR4sQMisHuVV8+EKow UgKfQps7IyFPPnxiD5EjUHn306MmMDcl223i3YqLg6qr6wiWfTqv/Qa+UmCt8tAmH4iJIsr7aFwRZ cHaK0ACj9tZRJp3hUoOkyVux5bAxTjn/5pUvXL4Nz8viBmvlPgMp7yrInxj6xkGLh9XEvCnMLA7zl /S0DO6gRfqS9lB0KLE6A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oEwbf-008V68-Lz; Fri, 22 Jul 2022 17:38:31 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oEwbd-008V50-Bv for linux-arm-kernel@lists.infradead.org; Fri, 22 Jul 2022 17:38:30 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0BA7562287; Fri, 22 Jul 2022 17:38:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 31926C341C6; Fri, 22 Jul 2022 17:38:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658511507; bh=I4xtFbTC9+FvdLTlAPDqElcspjawidIlSWv8SE4cu6o=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=O7Ef9u8o24UQkTByh3bfFO43xD9UNXfc/QtpZB2FPAtSDyZTXFNpfelZDglhE4+i+ h06GMWTQ1qGmIFUeeiTzPaLxcmumOhQLtj/Udl1Mb1ns/h/VaI9vZ7xplM1e0Dfu/O 3h7h2/zwi27WOPFexMZFTZrRG5EIUVSYgAG7wIbEvta1Cg6H9NNoZsRk382uiw21j8 Fiuo10fa5UVCFCDYuJjNYb+myvlq7s6HCfB9VsuM4LMb5Dmmdk3fxbDAdkyrvK99F3 Bd6JIMdEEViOLCRLITGcGiEcLt4C0acQyf/2KnMTH1feIAVUYb6HYSpQ47cVqbCXeh /qyLfmuvhMyZA== Date: Fri, 22 Jul 2022 10:38:26 -0700 From: Jakub Kicinski To: Liang He Cc: sgoutham@marvell.com, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] net: thunder_bgx: Fix refcount leak bug in bgx_init_of_phy() Message-ID: <20220722103826.6a059a69@kernel.org> In-Reply-To: <20220722152048.1310499-1-windhl@126.com> References: <20220722152048.1310499-1-windhl@126.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220722_103829_471870_8F9DC85E X-CRM114-Status: UNSURE ( 9.74 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 22 Jul 2022 23:20:48 +0800 Liang He wrote: > We should call of_node_put() for the reference returned by > of_parse_phandle() in fail path or when it is not used > anymore. > > Fixes: eee326fd8334 ("net: thunderx: bgx: Use standard firmware node infrastructure.") > Signed-off-by: Liang He cc netdev@ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel