From: Horatiu Vultur - M31836 <Horatiu.Vultur@microchip.com>
To: Kavyasree Kotagiri - I30978 <Kavyasree.Kotagiri@microchip.com>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"alexandre.belloni@bootlin.com" <alexandre.belloni@bootlin.com>,
"arnd@arndb.de" <arnd@arndb.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
UNGLinuxDriver <UNGLinuxDriver@microchip.com>,
"soc@kernel.org" <soc@kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"olof@lixom.net" <olof@lixom.net>,
"maxime.chevallier@bootlin.com" <maxime.chevallier@bootlin.com>,
Claudiu Beznea - M18063 <Claudiu.Beznea@microchip.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 2/2] ARM: dts: lan966x: add support for pcb8309
Date: Fri, 22 Jul 2022 14:46:20 +0200 [thread overview]
Message-ID: <20220722124620.khueuxinijmwgot5@soft-dev3-1.localhost> (raw)
In-Reply-To: <CO1PR11MB4865A1118ACB74B06408BBC792919@CO1PR11MB4865.namprd11.prod.outlook.com>
The 07/21/2022 06:08, Kavyasree Kotagiri - I30978 wrote:
> > + i2c-mux {
> > + compatible = "i2c-mux";
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + mux-controls = <&mux>;
> > + i2c-parent = <&i2c4>;
> > +
> > + i2c102: i2c-sfp@1 {
> > + reg = <1>;
> > + #address-cells = <1>;
> > + #size-cells = <0>;
>
> Why do you need #address-cells and #size-cells here?
> > + };
> > +
> > + i2c103: i2c-sfp@2 {
> > + reg = <2>;
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> Same here
> > + };
> > + };
They are not needed. I will remove them in the next version.
> > +
> > + mux: mux-controller {
> > + compatible = "gpio-mux";
> > + #mux-control-cells = <0>;
> > +
> > + mux-gpios = <&sgpio_out 11 0 GPIO_ACTIVE_HIGH>, /*
> > p11b0 */
> > + <&sgpio_out 11 1 GPIO_ACTIVE_HIGH>; /* p11b1
> > */
> > + };
...
> > +&i2c4 {
> > + compatible = "microchip,sam9x60-i2c";
> > + reg = <0x600 0x200>;
> > + interrupts = <GIC_SPI 52 IRQ_TYPE_LEVEL_HIGH>;
> > + #address-cells = <1>;
> > + #size-cells = <0>;
>
> Same here
>
Also here.
--
/Horatiu
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-07-22 12:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-20 19:49 [PATCH 0/2] ARM: add support for pcb8309 Horatiu Vultur
2022-07-20 19:49 ` [PATCH 1/2] dt-bindings: arm: at91: add lan966 pcb8309 board Horatiu Vultur
2022-07-21 6:46 ` Krzysztof Kozlowski
2022-07-22 12:52 ` Horatiu Vultur
2022-07-20 19:49 ` [PATCH 2/2] ARM: dts: lan966x: add support for pcb8309 Horatiu Vultur
2022-07-21 6:08 ` Kavyasree.Kotagiri
2022-07-22 12:46 ` Horatiu Vultur - M31836 [this message]
2022-07-21 7:39 ` Claudiu.Beznea
2022-07-22 12:48 ` Horatiu Vultur - M31836
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220722124620.khueuxinijmwgot5@soft-dev3-1.localhost \
--to=horatiu.vultur@microchip.com \
--cc=Claudiu.Beznea@microchip.com \
--cc=Kavyasree.Kotagiri@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
--cc=soc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox