From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 35AE4C43334 for ; Fri, 22 Jul 2022 12:43:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pjPxGEOUW509ATJA9uXqrND6xFW8E5VvHGKV93/sDqQ=; b=idR+VHUzwYaNcb PcmfrnGujgdZhXlyWoLL4fKVVTyVgCXlxr8ukTLiZdauSlivW0/Kj0a5XFhwYON73NEgkJ6/SabDD gnYk8KtgPaGPMyISix8+1AzuTrwydhGiytf9FtCCiNV44r3nKmRZL8eCRoSVNodWo7CO+CTt0Qz1+ JZprUneeQeAeWMRLUUzvEdB1SZ7Sa5/STn/I1DH37LwsiLxZC1boyf/ofLVXcorwrGfKad7BPegSQ cl8mo12wA5KgO+CoTOAOhOiQdMj3VPfFZ9iJLhpi71YFyNfL+3L0q0x99eR4SUCywX8NLdk8W1jRo qfJzBF/xO2oxDUZ8cCpA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oErzB-004Pkw-H5; Fri, 22 Jul 2022 12:42:29 +0000 Received: from esa.microchip.iphmx.com ([68.232.154.123]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oErz6-004PZz-38 for linux-arm-kernel@lists.infradead.org; Fri, 22 Jul 2022 12:42:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1658493743; x=1690029743; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=khPSA7SdeZvexVlLJVFq2jEQ1fN3eCp5D1jxG3kOEnY=; b=2kefDYKT2okZ64J2PsQj2uODv/H0Ozej1pXR0v3Ud4+trBFALHNPkIVy pbxFD2pq6/vtT5uNSykVNESSRq3+4fWcPYEejWMdDW/aIE/VV4u0w8jo/ 0/wW4NMtE6OyJRJr0/71WlGOzDvb7sHGqntjDiJu4C+gCKzRmJP7fFbI8 EeaDOZ5X17eitF53sDT9xUwfdW+zuQbjdf9ibceaaiOWKCmAARiQjEsyO /5cze8Ud6OVlnbefYQfSxmUgoczg4r9rh0yxKoESoX+tp8eHrpZYfOPru WCnyulozisrekUdrrOdipLbYP04vgv4FsBsto4T2mwtrrm2uBB3CMMU1W g==; X-IronPort-AV: E=Sophos;i="5.93,185,1654585200"; d="scan'208";a="169063672" Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa2.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 22 Jul 2022 05:42:13 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17; Fri, 22 Jul 2022 05:42:12 -0700 Received: from localhost (10.10.115.15) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server id 15.1.2375.17 via Frontend Transport; Fri, 22 Jul 2022 05:42:12 -0700 Date: Fri, 22 Jul 2022 14:46:20 +0200 From: Horatiu Vultur - M31836 To: Kavyasree Kotagiri - I30978 Subject: Re: [PATCH 2/2] ARM: dts: lan966x: add support for pcb8309 Message-ID: <20220722124620.khueuxinijmwgot5@soft-dev3-1.localhost> References: <20220720194904.2025384-1-horatiu.vultur@microchip.com> <20220720194904.2025384-3-horatiu.vultur@microchip.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220722_054224_245664_4FD5A1C5 X-CRM114-Status: UNSURE ( 9.59 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devicetree@vger.kernel.org" , "alexandre.belloni@bootlin.com" , "arnd@arndb.de" , "linux-kernel@vger.kernel.org" , UNGLinuxDriver , "soc@kernel.org" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "olof@lixom.net" , "maxime.chevallier@bootlin.com" , Claudiu Beznea - M18063 , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The 07/21/2022 06:08, Kavyasree Kotagiri - I30978 wrote: > > + i2c-mux { > > + compatible = "i2c-mux"; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + mux-controls = <&mux>; > > + i2c-parent = <&i2c4>; > > + > > + i2c102: i2c-sfp@1 { > > + reg = <1>; > > + #address-cells = <1>; > > + #size-cells = <0>; > > Why do you need #address-cells and #size-cells here? > > + }; > > + > > + i2c103: i2c-sfp@2 { > > + reg = <2>; > > + #address-cells = <1>; > > + #size-cells = <0>; > Same here > > + }; > > + }; They are not needed. I will remove them in the next version. > > + > > + mux: mux-controller { > > + compatible = "gpio-mux"; > > + #mux-control-cells = <0>; > > + > > + mux-gpios = <&sgpio_out 11 0 GPIO_ACTIVE_HIGH>, /* > > p11b0 */ > > + <&sgpio_out 11 1 GPIO_ACTIVE_HIGH>; /* p11b1 > > */ > > + }; ... > > +&i2c4 { > > + compatible = "microchip,sam9x60-i2c"; > > + reg = <0x600 0x200>; > > + interrupts = ; > > + #address-cells = <1>; > > + #size-cells = <0>; > > Same here > Also here. -- /Horatiu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel