From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3DBA3C433EF for ; Tue, 26 Jul 2022 06:31:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GMLOthReND7RdI8Ad4v7j4xQqUPToc6Pj4dqL33bORM=; b=vsGGJvD2HxHA6U GmNOjxI+NfYrGO+4xGH8cpXEXIjZQAfIPQzrJNy91V2ygg+AkfTYheTHBI5R6j52gqBMEwwL7uDBn jJd+EdTBKIzT2jMBusx8QcC+hhUTYH4/9f1qAhCuaMBBug+UL+d4wSD+yDrj0dLzGaeRelzzgdsuV wdxUUpflmZ4OKG5kiLkk6C9VwYGxZaxtJtIRfmJkN/DElHeafnBvCd9gbQctxJxDNN0svKNrMQ7qy SEf42MNEqhaBVJUI2645sxhiF/RqBhNxPFeknenQQg1Uus65RszkYTGsEpB0GfTuFS9j5zGWFf341 S9QATzNhmtFNZ0tADQfw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oGE5F-008s8k-7P; Tue, 26 Jul 2022 06:30:21 +0000 Received: from smtp28.bhosted.nl ([2a02:9e0:8000::40]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oGE5B-008s0X-Fp for linux-arm-kernel@lists.infradead.org; Tue, 26 Jul 2022 06:30:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonic.nl; s=202111; h=content-transfer-encoding:content-type:mime-version:references:in-reply-to: message-id:subject:cc:to:from:date:from; bh=QVIS0e/Pgyjm/UeHloB3YzmyfAb0KD91LCWzYjWV8Kw=; b=NoGCHGPHhgtT8otrzY+UiHQE0y309ougCSpmiwh2wyt5UvTABhWhXno5jJp3bGLMmzK3TvuFPGLVD +nSJd5egxlnRx8dduRd2IC1lW0xMoIHxglV0ExcSu72O9EKFosqmwLk7+y1YYJq2s69wh4nofbumwu lKqfWiF0DTV5w4QTw3dTJz81eUQ/YUFdWQxfNt8uqSyw0Vu7Dk4M97hTptXvHuNjtp/tkekQzba2fV GqdGIF1uHd3Ul8rhxemf0nkBnr8nL9zzz0HujhJvwaHcVn04+aNoAoP+1Ion85gqTGLqH4sItFy/8W WKAo73j9tdT/elM2wd12z+TGWYg/6RA== X-MSG-ID: 63f9ca3c-0cac-11ed-8a45-0050569d11ae Date: Tue, 26 Jul 2022 08:30:06 +0200 From: David Jander To: Krzysztof Kozlowski Cc: Rob Herring , Krzysztof Kozlowski , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Oleksij Rempel , Fabio Estevam , NXP Linux Team , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm: dts: imx6qdl-vicut1.dtsi: Add backlight-isb node Message-ID: <20220726083006.5c65b597@erd992> In-Reply-To: References: <20220725124813.1001032-1-david@protonic.nl> Organization: Protonic Holland X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220725_233017_983995_E319B7E2 X-CRM114-Status: GOOD ( 20.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 25 Jul 2022 22:33:12 +0200 Krzysztof Kozlowski wrote: > On 25/07/2022 14:48, David Jander wrote: > > On some older hardware models this is needed. It will do no harm if used > > with newer models though. > > > > Signed-off-by: David Jander > > --- > > arch/arm/boot/dts/imx6qdl-vicut1.dtsi | 22 ++++++++++++++++++++++ > > 1 file changed, 22 insertions(+) > > > > diff --git a/arch/arm/boot/dts/imx6qdl-vicut1.dtsi b/arch/arm/boot/dts/imx6qdl-vicut1.dtsi > > index a1676b5d2980..08d425020088 100644 > > --- a/arch/arm/boot/dts/imx6qdl-vicut1.dtsi > > +++ b/arch/arm/boot/dts/imx6qdl-vicut1.dtsi > > @@ -37,6 +37,16 @@ backlight_led: backlight_led { > > power-supply = <®_3v3>; > > }; > > > > + /* only for backwards compatibility with old HW */ > > + backlight_isb: backlight_isb { > > Node name: backlight-isb > > I know that other node had underscore, but these are not correct for names. I know the names are not correct, but they are in the style of existing node names in the same file. Do you want me to change them all, or just this one? This change would break existing user-space software though, which is something I prefer not to do. Unfortunately both names are relied upon by user-space software for almost 10 years now, and changing them will force me to maintain off-tree patches that revert these changes. I understand the reason for the change though, and if you insist I will do it. Best regards, -- David Jander _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel