From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 59DA9C433EF for ; Tue, 26 Jul 2022 12:57:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WLlPiJxievqhbSG5qx8VZCP2UvvyFiFXHO31By5SLLw=; b=di8za0lZGtaOeL zlZkB96yLYxzK0/ujUaMjGw8rzrNALAvgkY4z513oyzIl72yo52LhsUNoAtinabMM8JToVKbtDRU1 10/mVfqIkZBI0zYXN6iG/GcjinSRopAkg3DyhzdYOsjo1v8xQK6LnOfeQn1iPEAWWcEMWyYf8cz6l kJe5hPJKJWM37NCOr4iGIEQl31VhxRYjWvNmcJGih5UcGUYPFIDCtDP08uQJTR2vfmeKgnNlu/jrS fniqec7np/LW03HfuZLPi+ax7tFY1/DCVtDsSbLMOXMbtrjBCuI/FixRm1N5HbX9OVGC9atPfPB9p xNae7pRHZI8QiBZcn0eQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oGK6j-00H8TA-Cn; Tue, 26 Jul 2022 12:56:17 +0000 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oGK6f-00H8OW-Eq for linux-arm-kernel@lists.infradead.org; Tue, 26 Jul 2022 12:56:16 +0000 Received: by mail-wm1-x330.google.com with SMTP id r188-20020a1c44c5000000b003a34ac64bdfso4368938wma.1 for ; Tue, 26 Jul 2022 05:56:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ILtpMzX3VY8k59M2BJDRJGfQpuHK3RZfnXCOjBm8eTY=; b=Idx1cyBcJSvQO3qJZY9/aAkWS39UYbRrrvFmReLWAdgOk77gC96Fms5dd93efjpID+ SQ2cZMwICM1Dea4y48jvewtcgj6nXOOw5ldBOIcTeW1eIvMogAm1zEw12cbKJ+DM4Fgs wHlb2ykYPd2GlQZxjNsRMSazXBLqe9y+i5cIwGYjkC+yvwGNUkGrMNTFcC36YMnjm6IR xGt5LDLtwbPYpPU4vyZLL1TcFE6BxbFAfe6KoC9E0nPJVbVuChQP7pqvZu+ofLO86Bel Qc5N3OSUXrm35zzIxWP2ZMJhhW6WyO6XJ1ch/A2YysgUwhW9mxP0C9CLKoe6Cewfo1TJ DGfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ILtpMzX3VY8k59M2BJDRJGfQpuHK3RZfnXCOjBm8eTY=; b=PteGs9zEs0klth6Jm/q+q48HXSsM8MnV9npzxT/S2D6OLlPDjsF+g+a3QFRpxMwup4 gIu4vKOrxv74MEzcR37+TRS9busr0ML0N+mcHBC2F70GF/JtlNVkJvu9PwXPzOjRgHaB Bugvf2NiE7EGWgAnPiLnG5znsNzZ8DMq6Rt5JDkrGKOizbpyOiEhWWBRZYXu/65/c7QE XuJ+uiXTpZw7Xa0rb9a4rL9GhLJUvY3za+akD38GasoKgNxjENLlqAMjIimZgtN76nRr NL8bvx3yr0U2yuIRskU5lyTfdcQ/pap5ui/Ft5TkwRd4owfNsvJXwGPRgpAjz4R7FyfP F03Q== X-Gm-Message-State: AJIora807OiagiUGkqhTsI4icSXV3SqDs0jRFgE/ewDsrgmDfLIkP7Dg xhaLOOO1BklPILBemkIyigtz6g== X-Google-Smtp-Source: AGRyM1ukOx2aF9TBjUKq17lWfVED7ORwA752wJog+hPij7ufp+0vmCFhu2SrCpEmVz1IreQKIux2RQ== X-Received: by 2002:a05:600c:6002:b0:3a3:5453:bcbe with SMTP id az2-20020a05600c600200b003a35453bcbemr8829006wmb.190.1658840168574; Tue, 26 Jul 2022 05:56:08 -0700 (PDT) Received: from blmsp ([2001:4090:a243:806e:25e7:daa:8208:ceb]) by smtp.gmail.com with ESMTPSA id a9-20020adfeec9000000b0021dfacfdf0dsm14944421wrp.33.2022.07.26.05.56.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Jul 2022 05:56:08 -0700 (PDT) Date: Tue, 26 Jul 2022 14:56:06 +0200 From: Markus Schneider-Pargmann To: Jerome Neanne Cc: lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org, nm@ti.com, kristo@kernel.org, khilman@baylibre.com, narmstrong@baylibre.com, j-keerthy@ti.com, lee.jones@linaro.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 05/11] regulator: dt-bindings: Add TI TPS65219 PMIC bindings Message-ID: <20220726125606.kzpzlfeg57ufuhiv@blmsp> References: <20220726103355.17684-1-jneanne@baylibre.com> <20220726103355.17684-6-jneanne@baylibre.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220726103355.17684-6-jneanne@baylibre.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220726_055613_752414_A7B807C8 X-CRM114-Status: GOOD ( 23.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Jerome, On Tue, Jul 26, 2022 at 12:33:49PM +0200, Jerome Neanne wrote: > Add TPS65219 PMIC bindings using json-schema. > > Describe required properties and regname-supply. > regname-supply is required when bypass mode is used for a regulator. > Describes regulator topology. > Interrupts support. > Add a power-button property to configure the EN/PB/VSENSE pin as a > powerbutton: > > TPS65219 has a multipurpose pin called EN/PB/VSENSE that can be either: > - EN in which case it functions as an enable pin. > - VSENSE which compares the voltages and triggers an automatic > on/off request. > - PB in which case it can be configured to trigger an interrupt > to the SoC. > ti,power-button reflects the last one of those options > where the board has a button wired to the pin and triggers > an interrupt on pressing it. > > Signed-off-by: Markus Schneider-Pargmann > Signed-off-by: Jerome Neanne > --- > .../bindings/regulator/ti,tps65219.yaml | 164 ++++++++++++++++++ > 1 file changed, 164 insertions(+) > create mode 100644 Documentation/devicetree/bindings/regulator/ti,tps65219.yaml > > diff --git a/Documentation/devicetree/bindings/regulator/ti,tps65219.yaml b/Documentation/devicetree/bindings/regulator/ti,tps65219.yaml > new file mode 100644 > index 000000000000..8fca4db6c64c > --- /dev/null > +++ b/Documentation/devicetree/bindings/regulator/ti,tps65219.yaml ... > + > + power-button: > + type: boolean > + description: Optional property that sets the EN/PB/VSENSE pin to be a > + power-button. It seems something went wrong here. This should have been ti,power-button and have a similar description as the commit message, right? Best, Markus > + > +patternProperties: > + "^buck[1-3]-supply$": > + description: Input supply phandle of one regulator. > + > + "^ldo[1-4]-supply$": > + description: Input supply phandle of one regulator. > + > + regulators: > + type: object > + description: | > + list of regulators provided by this controller > + > + patternProperties: > + "^ldo[1-4]$": > + type: object > + $ref: regulator.yaml# > + description: > + Properties for single LDO regulator. > + > + unevaluatedProperties: false > + > + "^buck[1-3]$": > + type: object > + $ref: regulator.yaml# > + description: > + Properties for single BUCK regulator. > + > + unevaluatedProperties: false > + > + additionalProperties: false > + > +required: > + - compatible > + - reg > + - interrupts > + - regulators > + > +additionalProperties: false > + > +examples: > + - | > + #include > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + tps65219: pmic@30 { > + compatible = "ti,tps65219"; > + reg = <0x30>; > + buck1-supply = <&vcc_3v3_sys>; > + buck2-supply = <&vcc_3v3_sys>; > + buck3-supply = <&vcc_3v3_sys>; > + ldo1-supply = <&vcc_3v3_sys>; > + ldo2-supply = <&buck2_reg>; > + ldo3-supply = <&vcc_3v3_sys>; > + ldo4-supply = <&vcc_3v3_sys>; > + > + pinctrl-0 = <&pmic_irq_pins_default>; > + > + interrupt-parent = <&gic500>; > + interrupts = ; > + interrupt-controller; > + #interrupt-cells = <1>; > + > + regulators { > + buck1_reg: buck1 { > + regulator-name = "VDD_CORE"; > + regulator-min-microvolt = <750000>; > + regulator-max-microvolt = <750000>; > + regulator-boot-on; > + regulator-always-on; > + }; > + > + buck2_reg: buck2 { > + regulator-name = "VCC1V8"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + regulator-boot-on; > + regulator-always-on; > + }; > + > + buck3_reg: buck3 { > + regulator-name = "VDD_LPDDR4"; > + regulator-min-microvolt = <1100000>; > + regulator-max-microvolt = <1100000>; > + regulator-boot-on; > + regulator-always-on; > + }; > + > + ldo1_reg: ldo1 { > + regulator-name = "VDDSHV_SD_IO_PMIC"; > + regulator-min-microvolt = <33000000>; > + regulator-max-microvolt = <33000000>; > + }; > + > + ldo2_reg: ldo2 { > + regulator-name = "VDDAR_CORE"; > + regulator-min-microvolt = <850000>; > + regulator-max-microvolt = <850000>; > + regulator-boot-on; > + regulator-always-on; > + }; > + > + ldo3_reg: ldo3 { > + regulator-name = "VDDA_1V8"; > + regulator-min-microvolt = <18000000>; > + regulator-max-microvolt = <18000000>; > + regulator-boot-on; > + regulator-always-on; > + }; > + > + ldo4_reg: ldo4 { > + regulator-name = "VDD_PHY_2V5"; > + regulator-min-microvolt = <25000000>; > + regulator-max-microvolt = <25000000>; > + regulator-boot-on; > + regulator-always-on; > + }; > + }; > + }; > + }; > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel