From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8EFECC00144 for ; Tue, 26 Jul 2022 22:04:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=0dA0vldtXDK0YizRSVk4fQaiLwdqdLh0LJ+qYhh6f5Y=; b=TgrwHmA4OkHK/N miquMqWV3D0xl9jeb2vz/I5cArBAHCbT51Hplh/aYIOM7oWuJ5jG9TR9EtQt7i9AKAAk3UzC/iWuF QtMk9lbrd3H5cmeK2JtFLrW9/LK/mGZV+U6ByTtb5eTxRD6ykVee6IHmOARn5KCU7c9k3S84NECA+ 53lpjxii/82v8aMIzmvsWsgdc/6N4gewJRHb37xAQkWakHLacw0j02kEY9vUfMgnz76kA1hNACVs4 niZXn490JAz/nW60EepG8Zrqq2q+oQIwJhu4P33uzEOFJMHtGNlHjaVKSMxcWKWmGGyU16j9Fzkwl B9yIhpglvm+zGFdl2RBw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oGSe2-004Y64-MO; Tue, 26 Jul 2022 22:03:14 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oGSdy-004Y14-NL; Tue, 26 Jul 2022 22:03:12 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 339F5B80C63; Tue, 26 Jul 2022 22:03:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 674ADC433C1; Tue, 26 Jul 2022 22:03:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658872986; bh=YAlRM5ikZwskDhCxJ6jfhkvNahSdq2ZlIn13XXhrgyE=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=bWSUQjxOLmeiTDVyaWQXbxsvaJc0NkZiZCCGTU+s/0G7/hH1eBFUvYeK3UgF7yTZN vPjVY4+Ua9s7K99AtQh85O/4Y3TRGsyjLbl73BSGFv8HA233TmxKgQq6KJwJ6bCQPK auAL2TDnVse4/KCxoyYhQGc93j/phThxMNfPxf4qvYWOcv0R6ZARQYpcqwrLDTqagB EDiFzXmG3KK9BP9m2FRp417wR3iBQtM5t/VvZFZXz7t+M1xz24VgGDgUFcL55c4sb3 Mz45Q7LPh37mgXQZICRsD4beuAoNM+UQh94r+FofbJGvf+DV1c1kbP5YIofy8uHNLT uDW2yt1aPEfhw== Date: Tue, 26 Jul 2022 17:03:03 -0500 From: Bjorn Helgaas To: Jim Quinlan Cc: linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Bjorn Helgaas , Lorenzo Pieralisi , Cyril Brulebois , bcm-kernel-feedback-list@broadcom.com, james.quinlan@broadcom.com, Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , open list , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , Rob Herring Subject: Re: [PATCH v3 0/7] PCI: brcmstb: Re-submit reverted patchset Message-ID: <20220726220303.GA109624@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220725151258.42574-1-jim2101024@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220726_150311_090828_8C0F51B1 X-CRM114-Status: GOOD ( 17.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 25, 2022 at 11:12:49AM -0400, Jim Quinlan wrote: > ... > Jim Quinlan (7): > PCI: brcmstb: Remove unnecessary forward declarations > PCI: brcmstb: Split brcm_pcie_setup() into two funcs > PCI: brcmstb: Gate config space access on link status > PCI: brcmstb: Add mechanism to turn on subdev regulators > PCI: brcmstb: Add control of subdevice voltage regulators > PCI: brcmstb: Do not turn off WOL regulators on suspend > PCI: brcmstb: Have .map_bus function names end with 'map_bus' > > drivers/pci/controller/pcie-brcmstb.c | 476 ++++++++++++++++++-------- > 1 file changed, 341 insertions(+), 135 deletions(-) I reworked these and put them on pci/ctrl/brcm for v5.20. This is a proposal, not something set in stone. But time is of the essence to figure out how we want to proceed. I changed a lot of stuff and it's likely I broke something in the process, so please take a look and test this out. Here's an outline of what I changed: - Moved the config access "link up" check earlier because it's not related to the power regulator patches. - Changed config access "link up" checks to use PCIE_ECAM_REG() instead of hard-coding 0xfff masks. The 32-bit accessors already mask out the low two bits, so we don't need to do that here. - Squashed pci_subdev_regulators_add_bus() directly into brcm_pcie_add_bus() for readability. Similarly for pci_subdev_regulators_remove_bus(). - This makes a clear split between: * A patch that adds get/enable of regulators, and starting the link after enabling regulators, and * A patch that disables/enables regulators for suspend/resume. - Since we only support one set of subregulator info (for one Root Port, and brcm_pcie_suspend_noirq() depends on this since it uses the pcie->sr pointer), use pcie->sr always instead of dev->driver_data. - Squashed wakeup device checking into the suspend/resume patch so there's not a time when suspend might turn off power to a wakeup device. - Renamed brcm_pcie_map_bus32() to brcm7425_pcie_map_bus() so it ends in "_map_bus()" like other drivers. Also, brcm7425_pcie_map_bus() doesn't actually depend on the 32-bitness. Bjorn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel