From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 16B66C00144 for ; Wed, 27 Jul 2022 01:35:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:Mime-Version: Message-Id:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=zFuTh0vxqooaxqPlvrRaBskS9jOUGCbCKDMNIqKD2xk=; b=joC iOJ1oCbLiX7X9n0O2F6PRIhR1Iwok86AUUDFtR8zwIT0Fx4GncjnUO78B6mreVkoPDuplD1M0vvdJ NGRoCPRZEnEzOtsmSJG6vbsp5QurKA2h1CSl2EBODtRNKPdP1pUq+LKWF09fxavW/6PHThmi/rvtc ufBZu6qYzPJ/55cl7ZQW6a1OhMObML3g26INdhiRXqyP7KDMqgNy7M2/f87QHLyHxv5iH/YLRsGWO JIXZqdiBySqtl5LTEFPMbbbQEDSVRCDfl4G4S8y4qEgG2/d2zKikiXF4b2G4yEqZ8ylW+N9OKtEiY b0A8WjE5StWERZ92CGWa4S0vlcZailQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oGVvz-007I1x-Os; Wed, 27 Jul 2022 01:33:59 +0000 Received: from mail-pl1-x649.google.com ([2607:f8b0:4864:20::649]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oGVvw-007Hxn-38 for linux-arm-kernel@lists.infradead.org; Wed, 27 Jul 2022 01:33:57 +0000 Received: by mail-pl1-x649.google.com with SMTP id p8-20020a170902e74800b0016d5e43bd99so5506610plf.16 for ; Tue, 26 Jul 2022 18:33:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:message-id:mime-version:subject:from:to:cc; bh=1N3h8/3xSQWX6SxOF5BPCgS/YJL4wXTsZ8CkYeFIT3M=; b=QpSGMoTn06o1HCqJaequgVUCWVDL6y7V2pJAXhgcZslE7hepnB5qO5bhCsayf8BgZT ioAnJDRO4dHDHZqT9epxdMWWuTHPxYpYQv7N9ry1QlIk5/V+cdUycj6fXPdRo+zdPUo4 +0Z324w4ZR5jGLPTe46w9q+JE1ZZ5ABziZoQBzBQTrwwhqWlRBOLEcHVBm9L7dK5/Xdi xfKd8NoIGd/LYe/RpZOiwPs5NxYvdylykP+HFfsBwc/HIFJB2XohGmZzvFpXtiCPc2sI KLyTgTV/B/ZJi0VZmQ1yZMC9+h2YpRh2EOANQBwbCIdYGeqvIQFkcbdQymaE9OuWqLHy Y7lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=1N3h8/3xSQWX6SxOF5BPCgS/YJL4wXTsZ8CkYeFIT3M=; b=10r2TC13hKtP0EbW5cJeGyCO09qy3jBnqkHu94PR8UiM6TAfFQGPyTBoYPriDT2oMP t4djOAtUEXvUR07LglB589K1HNN0phe2YiBrExRalqDTKqa0lM7PxD/b4KuNn8Trcc1C FB/ilO3HOXBY5SjeI074jIJN6/vIVE1zkPWbxNdSa7SL7ki7FmHQ/qeSrm4KFCFGaOrd Fvd+/4AlUwPrkNGLindDKQim0pmoquJG81j34i0cdGwmAODwM27golJ0hA1hPefOzte8 U1v3NLHbCuIZ0Rl+R63Km2wupDLHNjwPx3fh+a9o88V8KeRiXeeMtUE6yFO93l65+xu+ vrFg== X-Gm-Message-State: AJIora8lkhEHmSKUZz/8SjCx8F+Z1O4RDdimDnDhfsb5Q8wvfKB7nopd +BlXwjaRHTxezswU+8f4/1cFG2vSq4sZZAI= X-Google-Smtp-Source: AGRyM1tNXxJJfexei0sXfG1FBir9ecawTKSUmr8oBmd7eGPMiF6IiFNkyG65ifGlltihpNEjyyTucthrEgJjoHc= X-Received: from saravanak.san.corp.google.com ([2620:15c:2d:3:f771:727:f95a:5335]) (user=saravanak job=sendgmr) by 2002:a17:90a:6b45:b0:1e3:3cfa:3104 with SMTP id x5-20020a17090a6b4500b001e33cfa3104mr1862493pjl.113.1658885633796; Tue, 26 Jul 2022 18:33:53 -0700 (PDT) Date: Tue, 26 Jul 2022 18:33:48 -0700 Message-Id: <20220727013349.3056826-1-saravanak@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.37.1.359.gd136c6c3e2-goog Subject: [PATCH v1] pinctrl: samsung: Finish initializing the gpios before registering them From: Saravana Kannan To: Tomasz Figa , Krzysztof Kozlowski , Sylwester Nawrocki , Alim Akhtar , Linus Walleij Cc: Saravana Kannan , kernel-team@android.com, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220726_183356_157395_1985C279 X-CRM114-Status: GOOD ( 12.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org As soon as a gpio is registered, it should be usable by a consumer. So, do all the initialization before registering the gpios. Without this change, a consumer can request a GPIO IRQ and have the gpio to IRQ mapping fail. Signed-off-by: Saravana Kannan --- drivers/pinctrl/samsung/pinctrl-samsung.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/pinctrl/samsung/pinctrl-samsung.c b/drivers/pinctrl/samsung/pinctrl-samsung.c index 26d309d2516d..a302b38a63a8 100644 --- a/drivers/pinctrl/samsung/pinctrl-samsung.c +++ b/drivers/pinctrl/samsung/pinctrl-samsung.c @@ -1168,15 +1168,15 @@ static int samsung_pinctrl_probe(struct platform_device *pdev) if (ret) goto err_put_banks; - ret = samsung_gpiolib_register(pdev, drvdata); - if (ret) - goto err_unregister; - if (ctrl->eint_gpio_init) ctrl->eint_gpio_init(drvdata); if (ctrl->eint_wkup_init) ctrl->eint_wkup_init(drvdata); + ret = samsung_gpiolib_register(pdev, drvdata); + if (ret) + goto err_unregister; + platform_set_drvdata(pdev, drvdata); return 0; -- 2.37.1.359.gd136c6c3e2-goog _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel