* [PATCH] ARM: dts: turris-omnia: Add ethernet aliases
@ 2022-07-27 13:09 Pali Rohár
2022-07-27 13:15 ` Pali Rohár
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Pali Rohár @ 2022-07-27 13:09 UTC (permalink / raw)
To: Andrew Lunn, Gregory Clement, Sebastian Hesselbarth, Rob Herring
Cc: Marek Behún, linux-arm-kernel, linux-kernel
This allows bootloader to correctly pass MAC addresses used by bootloader
to individual interfaces into kernel device tree.
Signed-off-by: Pali Rohár <pali@kernel.org>
---
arch/arm/boot/dts/armada-385-turris-omnia.dts | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/arm/boot/dts/armada-385-turris-omnia.dts b/arch/arm/boot/dts/armada-385-turris-omnia.dts
index f4eb6898aa6b..d2afa466e29a 100644
--- a/arch/arm/boot/dts/armada-385-turris-omnia.dts
+++ b/arch/arm/boot/dts/armada-385-turris-omnia.dts
@@ -23,6 +23,12 @@
stdout-path = &uart0;
};
+ aliases {
+ ethernet0 = ð0;
+ ethernet1 = ð1;
+ ethernet2 = ð2;
+ };
+
memory {
device_type = "memory";
reg = <0x00000000 0x40000000>; /* 1024 MB */
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] ARM: dts: turris-omnia: Add ethernet aliases
2022-07-27 13:09 [PATCH] ARM: dts: turris-omnia: Add ethernet aliases Pali Rohár
@ 2022-07-27 13:15 ` Pali Rohár
2022-08-09 20:28 ` Andrew Lunn
2022-09-24 12:13 ` Pali Rohár
2022-11-27 23:57 ` Gregory CLEMENT
2 siblings, 1 reply; 8+ messages in thread
From: Pali Rohár @ 2022-07-27 13:15 UTC (permalink / raw)
To: Andrew Lunn, Gregory Clement, Sebastian Hesselbarth, Rob Herring
Cc: Marek Behún, linux-arm-kernel, linux-kernel
On Wednesday 27 July 2022 15:09:26 Pali Rohár wrote:
> This allows bootloader to correctly pass MAC addresses used by bootloader
> to individual interfaces into kernel device tree.
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
> ---
Maybe this should have Fixes line?
Fixes: 26ca8b52d6e1 ("ARM: dts: add support for Turris Omnia")
> arch/arm/boot/dts/armada-385-turris-omnia.dts | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm/boot/dts/armada-385-turris-omnia.dts b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> index f4eb6898aa6b..d2afa466e29a 100644
> --- a/arch/arm/boot/dts/armada-385-turris-omnia.dts
> +++ b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> @@ -23,6 +23,12 @@
> stdout-path = &uart0;
> };
>
> + aliases {
> + ethernet0 = ð0;
> + ethernet1 = ð1;
> + ethernet2 = ð2;
> + };
> +
> memory {
> device_type = "memory";
> reg = <0x00000000 0x40000000>; /* 1024 MB */
> --
> 2.20.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] ARM: dts: turris-omnia: Add ethernet aliases
2022-07-27 13:15 ` Pali Rohár
@ 2022-08-09 20:28 ` Andrew Lunn
2022-08-09 20:45 ` Pali Rohár
0 siblings, 1 reply; 8+ messages in thread
From: Andrew Lunn @ 2022-08-09 20:28 UTC (permalink / raw)
To: Pali Rohár
Cc: Gregory Clement, Sebastian Hesselbarth, Rob Herring,
Marek Behún, linux-arm-kernel, linux-kernel
On Wed, Jul 27, 2022 at 03:15:04PM +0200, Pali Rohár wrote:
> On Wednesday 27 July 2022 15:09:26 Pali Rohár wrote:
> > This allows bootloader to correctly pass MAC addresses used by bootloader
> > to individual interfaces into kernel device tree.
> >
> > Signed-off-by: Pali Rohár <pali@kernel.org>
> > ---
>
> Maybe this should have Fixes line?
>
> Fixes: 26ca8b52d6e1 ("ARM: dts: add support for Turris Omnia")
Is it broken with older kernels? That is a big part of Fixes: to
indicate it needs back porting. Is this a new u-boot feature?
Andrew
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] ARM: dts: turris-omnia: Add ethernet aliases
2022-08-09 20:28 ` Andrew Lunn
@ 2022-08-09 20:45 ` Pali Rohár
0 siblings, 0 replies; 8+ messages in thread
From: Pali Rohár @ 2022-08-09 20:45 UTC (permalink / raw)
To: Andrew Lunn
Cc: Gregory Clement, Sebastian Hesselbarth, Rob Herring,
Marek Behún, linux-arm-kernel, linux-kernel
On Tuesday 09 August 2022 22:28:51 Andrew Lunn wrote:
> On Wed, Jul 27, 2022 at 03:15:04PM +0200, Pali Rohár wrote:
> > On Wednesday 27 July 2022 15:09:26 Pali Rohár wrote:
> > > This allows bootloader to correctly pass MAC addresses used by bootloader
> > > to individual interfaces into kernel device tree.
> > >
> > > Signed-off-by: Pali Rohár <pali@kernel.org>
> > > ---
> >
> > Maybe this should have Fixes line?
> >
> > Fixes: 26ca8b52d6e1 ("ARM: dts: add support for Turris Omnia")
>
> Is it broken with older kernels? That is a big part of Fixes: to
> indicate it needs back porting. Is this a new u-boot feature?
>
> Andrew
This is old u-boot feature. I was investigating why u-boot is not able
to correctly modify loaded omnia dtb file when booting linux kernel and
I found out that it is because it cannot due to missing ethernet
aliases.
Also there is a new u-boot feature for omnia to correctly put
phy-reset-gpios property into eth 2 node based on board hw revision. So
this is another purpose for which we should have those aliases, to allow
kernel to correctly reset wan (eth 2) PHY.
I would suggest this change for backporting into stable.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: dts: turris-omnia: Add ethernet aliases
2022-07-27 13:09 [PATCH] ARM: dts: turris-omnia: Add ethernet aliases Pali Rohár
2022-07-27 13:15 ` Pali Rohár
@ 2022-09-24 12:13 ` Pali Rohár
2022-10-09 11:46 ` Pali Rohár
2022-11-27 23:57 ` Gregory CLEMENT
2 siblings, 1 reply; 8+ messages in thread
From: Pali Rohár @ 2022-09-24 12:13 UTC (permalink / raw)
To: Andrew Lunn, Gregory Clement, Sebastian Hesselbarth, Rob Herring
Cc: Marek Behún, linux-arm-kernel, linux-kernel
PING?
On Wednesday 27 July 2022 15:09:26 Pali Rohár wrote:
> This allows bootloader to correctly pass MAC addresses used by bootloader
> to individual interfaces into kernel device tree.
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
> ---
> arch/arm/boot/dts/armada-385-turris-omnia.dts | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm/boot/dts/armada-385-turris-omnia.dts b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> index f4eb6898aa6b..d2afa466e29a 100644
> --- a/arch/arm/boot/dts/armada-385-turris-omnia.dts
> +++ b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> @@ -23,6 +23,12 @@
> stdout-path = &uart0;
> };
>
> + aliases {
> + ethernet0 = ð0;
> + ethernet1 = ð1;
> + ethernet2 = ð2;
> + };
> +
> memory {
> device_type = "memory";
> reg = <0x00000000 0x40000000>; /* 1024 MB */
> --
> 2.20.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] ARM: dts: turris-omnia: Add ethernet aliases
2022-09-24 12:13 ` Pali Rohár
@ 2022-10-09 11:46 ` Pali Rohár
2022-11-01 22:39 ` Pali Rohár
0 siblings, 1 reply; 8+ messages in thread
From: Pali Rohár @ 2022-10-09 11:46 UTC (permalink / raw)
To: Gregory Clement; +Cc: linux-arm-kernel, linux-kernel
Gregory: PING?
On Saturday 24 September 2022 14:13:02 Pali Rohár wrote:
> PING?
>
> On Wednesday 27 July 2022 15:09:26 Pali Rohár wrote:
> > This allows bootloader to correctly pass MAC addresses used by bootloader
> > to individual interfaces into kernel device tree.
> >
> > Signed-off-by: Pali Rohár <pali@kernel.org>
> > ---
> > arch/arm/boot/dts/armada-385-turris-omnia.dts | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/armada-385-turris-omnia.dts b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> > index f4eb6898aa6b..d2afa466e29a 100644
> > --- a/arch/arm/boot/dts/armada-385-turris-omnia.dts
> > +++ b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> > @@ -23,6 +23,12 @@
> > stdout-path = &uart0;
> > };
> >
> > + aliases {
> > + ethernet0 = ð0;
> > + ethernet1 = ð1;
> > + ethernet2 = ð2;
> > + };
> > +
> > memory {
> > device_type = "memory";
> > reg = <0x00000000 0x40000000>; /* 1024 MB */
> > --
> > 2.20.1
> >
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] ARM: dts: turris-omnia: Add ethernet aliases
2022-10-09 11:46 ` Pali Rohár
@ 2022-11-01 22:39 ` Pali Rohár
0 siblings, 0 replies; 8+ messages in thread
From: Pali Rohár @ 2022-11-01 22:39 UTC (permalink / raw)
To: Gregory Clement; +Cc: linux-arm-kernel, linux-kernel
PING?
On Sunday 09 October 2022 13:46:59 Pali Rohár wrote:
> Gregory: PING?
>
> On Saturday 24 September 2022 14:13:02 Pali Rohár wrote:
> > PING?
> >
> > On Wednesday 27 July 2022 15:09:26 Pali Rohár wrote:
> > > This allows bootloader to correctly pass MAC addresses used by bootloader
> > > to individual interfaces into kernel device tree.
> > >
> > > Signed-off-by: Pali Rohár <pali@kernel.org>
> > > ---
> > > arch/arm/boot/dts/armada-385-turris-omnia.dts | 6 ++++++
> > > 1 file changed, 6 insertions(+)
> > >
> > > diff --git a/arch/arm/boot/dts/armada-385-turris-omnia.dts b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> > > index f4eb6898aa6b..d2afa466e29a 100644
> > > --- a/arch/arm/boot/dts/armada-385-turris-omnia.dts
> > > +++ b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> > > @@ -23,6 +23,12 @@
> > > stdout-path = &uart0;
> > > };
> > >
> > > + aliases {
> > > + ethernet0 = ð0;
> > > + ethernet1 = ð1;
> > > + ethernet2 = ð2;
> > > + };
> > > +
> > > memory {
> > > device_type = "memory";
> > > reg = <0x00000000 0x40000000>; /* 1024 MB */
> > > --
> > > 2.20.1
> > >
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: dts: turris-omnia: Add ethernet aliases
2022-07-27 13:09 [PATCH] ARM: dts: turris-omnia: Add ethernet aliases Pali Rohár
2022-07-27 13:15 ` Pali Rohár
2022-09-24 12:13 ` Pali Rohár
@ 2022-11-27 23:57 ` Gregory CLEMENT
2 siblings, 0 replies; 8+ messages in thread
From: Gregory CLEMENT @ 2022-11-27 23:57 UTC (permalink / raw)
To: Pali Rohár, Andrew Lunn, Sebastian Hesselbarth, Rob Herring
Cc: Marek Behún, linux-arm-kernel, linux-kernel
Pali Rohár <pali@kernel.org> writes:
> This allows bootloader to correctly pass MAC addresses used by bootloader
> to individual interfaces into kernel device tree.
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
Applied on mvebu/dt
Thanks,
Gregory
> ---
> arch/arm/boot/dts/armada-385-turris-omnia.dts | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm/boot/dts/armada-385-turris-omnia.dts b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> index f4eb6898aa6b..d2afa466e29a 100644
> --- a/arch/arm/boot/dts/armada-385-turris-omnia.dts
> +++ b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> @@ -23,6 +23,12 @@
> stdout-path = &uart0;
> };
>
> + aliases {
> + ethernet0 = ð0;
> + ethernet1 = ð1;
> + ethernet2 = ð2;
> + };
> +
> memory {
> device_type = "memory";
> reg = <0x00000000 0x40000000>; /* 1024 MB */
> --
> 2.20.1
>
--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-11-27 23:58 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-27 13:09 [PATCH] ARM: dts: turris-omnia: Add ethernet aliases Pali Rohár
2022-07-27 13:15 ` Pali Rohár
2022-08-09 20:28 ` Andrew Lunn
2022-08-09 20:45 ` Pali Rohár
2022-09-24 12:13 ` Pali Rohár
2022-10-09 11:46 ` Pali Rohár
2022-11-01 22:39 ` Pali Rohár
2022-11-27 23:57 ` Gregory CLEMENT
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).