From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 187B0C19F29 for ; Wed, 27 Jul 2022 23:48:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:To:Cc:From:Subject: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NLfnKR5wJ/tCXz5sw7usKBT8frH/M86sH6UjoqSmTdc=; b=jV7RQRg/RfEMN4 Ixwl22h99kSpbW8zEpWGNpwyGKqHQl/YVwcR94TKeIzcPewYA+KdMW4uwFXJSwixCKYYreXRuvIRO +r2Ntka4BKKUWiEZRkTzQMljbY/AHch6Tg8x5ptgBCnbHzWy96BWo0KwWz/WQiblXFTEYB2Xh5tsh cAXTkKMc9/XXG7ledMPalUIiKv1PDu3zfCJloVD4GKfn/EIwehvpOmhmkOgPG+HNhV1adBzAYl3iu AI39/5g9tBoOkyoS+MDrgqxaB3H1EMNlu2yuzvMxZpOGFIE1WlLS0k0sP8v9COofIwXFgRMYklJhA ZPP3sb3EvKGLUUyuFphg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oGqkU-001bh6-P3; Wed, 27 Jul 2022 23:47:30 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oGqkQ-001bcE-Vs for linux-arm-kernel@lists.infradead.org; Wed, 27 Jul 2022 23:47:28 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 99A85B821BC; Wed, 27 Jul 2022 23:47:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 501BFC433D6; Wed, 27 Jul 2022 23:47:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658965639; bh=lbu5zPdYF9W+kJoFAZzKphWhxdbHEfKvdS1DNBnOYnI=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=R/x9nvQSQSU1hdiddXhKn5BkYFHBFZ4RTZ8QlBUzryOuUJ2CPL03lx8qdcXdjin4t 44DD45N6nP9ooPjHjsgP1mZqmcfreULSW3tmdfKgoqnJ4qW04M4fHXTeYYfucf+7O2 IGojEBrHPpCJ7eKuLE5kAgQ/DbkkubgxXDb3Otlhbnecw8AUxbs+ERhvv3DqWMS81E Tu92L//5zU4Vus7kEHlg3Yl5fwCM0Cz8Uptdzq3u7JZ4dCKalChJkPLN1+T9B6kHfy 0KPW+VAIxUi9TD98Ig9G9b9IoQCaYQkJVmd1Rqc1ENDBkS0t7RjtxiC8EQKRBPxft6 ahlGhhIt13ApA== MIME-Version: 1.0 In-Reply-To: <20220719183725.2605141-1-jernej.skrabec@gmail.com> References: <20220719183725.2605141-1-jernej.skrabec@gmail.com> Subject: Re: [PATCH] clk: sunxi-ng: Fix H6 RTC clock definition From: Stephen Boyd Cc: mturquette@baylibre.com, andre.przywara@arm.com, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Jernej Skrabec To: Jernej Skrabec , samuel@sholland.org, wens@csie.org Date: Wed, 27 Jul 2022 16:47:17 -0700 User-Agent: alot/0.10 Message-Id: <20220727234719.501BFC433D6@smtp.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220727_164727_358538_C3D8656A X-CRM114-Status: UNSURE ( 7.61 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Jernej Skrabec (2022-07-19 11:37:25) > While RTC clock was added in H616 ccu_common list, it was not in H6 > list. That caused invalid pointer dereference like this: > > Unable to handle kernel NULL pointer dereference at virtual address 000000000000020c > Mem abort info: > ESR = 0x96000004 > EC = 0x25: DABT (current EL), IL = 32 bits > SET = 0, FnV = 0 > EA = 0, S1PTW = 0 > FSC = 0x04: level 0 translation fault > Data abort info: > ISV = 0, ISS = 0x00000004 > CM = 0, WnR = 0 > user pgtable: 4k pages, 48-bit VAs, pgdp=000000004d574000 > [000000000000020c] pgd=0000000000000000, p4d=0000000000000000 > Internal error: Oops: 96000004 [#1] PREEMPT SMP > CPU: 3 PID: 339 Comm: cat Tainted: G B 5.18.0-rc1+ #1352 > Hardware name: Tanix TX6 (DT) > pstate: 00000005 (nzcv daif -PAN -UAO -TCO -DIT -SSBS BTYPE=--) > pc : ccu_gate_is_enabled+0x48/0x74 > lr : ccu_gate_is_enabled+0x40/0x74 > sp : ffff80000c0b76d0 > x29: ffff80000c0b76d0 x28: 00000000016e3600 x27: 0000000000000000 > x26: 0000000000000000 x25: 0000000000000002 x24: ffff00000952fe08 > x23: ffff800009611400 x22: ffff00000952fe79 x21: 0000000000000000 > x20: 0000000000000001 x19: ffff80000aad6f08 x18: 0000000000000000 > x17: 2d2d2d2d2d2d2d2d x16: 2d2d2d2d2d2d2d2d x15: 2d2d2d2d2d2d2d2d > x14: 0000000000000000 x13: 00000000f2f2f2f2 x12: ffff700001816e89 > x11: 1ffff00001816e88 x10: ffff700001816e88 x9 : dfff800000000000 > x8 : ffff80000c0b7447 x7 : 0000000000000001 x6 : ffff700001816e88 > x5 : ffff80000c0b7440 x4 : 0000000000000001 x3 : ffff800008935c50 > x2 : dfff800000000000 x1 : 0000000000000000 x0 : 000000000000020c > Call trace: > ccu_gate_is_enabled+0x48/0x74 > clk_core_is_enabled+0x7c/0x1c0 > clk_summary_show_subtree+0x1dc/0x334 > clk_summary_show_subtree+0x250/0x334 > clk_summary_show_subtree+0x250/0x334 > clk_summary_show_subtree+0x250/0x334 > clk_summary_show_subtree+0x250/0x334 > clk_summary_show+0x90/0xdc > seq_read_iter+0x248/0x6d4 > seq_read+0x17c/0x1fc > full_proxy_read+0x90/0xf0 > vfs_read+0xdc/0x28c > ksys_read+0xc8/0x174 > __arm64_sys_read+0x44/0x5c > invoke_syscall+0x60/0x190 > el0_svc_common.constprop.0+0x7c/0x160 > do_el0_svc+0x38/0xa0 > el0_svc+0x68/0x160 > el0t_64_sync_handler+0x10c/0x140 > el0t_64_sync+0x18c/0x190 > Code: d1006260 97e5c981 785e8260 8b0002a0 (b9400000) > ---[ end trace 0000000000000000 ]--- Applied to clk-fixes _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel