From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AFAEFC00144 for ; Fri, 29 Jul 2022 22:57:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:To:Cc:From:Subject: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=N9J49GFQp7las429V3L3dwVHrEzwHb5oXqSTqZ5ZDlk=; b=HNaxUnITttK906 Xn0eJVGyumI1BtMzJpPpad53CeUswWS+nBfAx2DrLkztdCY3RP8lP8vsr8fOoLsgn8bsXUu4HNufr b89O34BghypVagGTtFYMUxZcC3hq5CX1eRdaH/22kstH1OYyWpo+Sll4tLNA4kWktDtQz/voIXAXA J6IH8PX8pDIPmhDZVbrXgU8p0iISWFM+pmgzFP49QwPA8lo2UjrratW/f4mn1w4OcCXoLND5M7g0n aRBmX/1pUrh2KiolmYqeGfm8l/2Sp8+96SKWvOrMQKTID1li1xnbjP+RyQbFFwcQbQ+ZwhbdgYI1M xVHcGRU5xu/VtGtyWyTA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oHYtt-00DV8E-C3; Fri, 29 Jul 2022 22:56:09 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oHYtq-00DV1u-HJ for linux-arm-kernel@lists.infradead.org; Fri, 29 Jul 2022 22:56:08 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 5C6CCB829FE; Fri, 29 Jul 2022 22:56:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 12528C433D6; Fri, 29 Jul 2022 22:56:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1659135363; bh=zk29gmNkOWKkDPAyPj1KjLUZzxwFt6lvMvWIi2eO2Lc=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=QfcqUVGobKwRR3DAPC3w8Y/kVCpprAGZdplH6sAVBNMroIEmwLYn9rQ2TUd+lg4x7 jkTqCFSFnU+THaJGobcDJ0gav0im3GXsUM5hrG4Z3UaD2HfBBLT5LENuAs3gkYFCKd MqO3B7iD1p5gxL9cGRphF5rzi27JXEErT+flJzx+vlX0XjXx2dUmFeFVZdsmNO4dAr 7o+GXFViDrxwcDMM19aeb8JVsHTNFl+vjJzIQxdKbsBz8+CY+0wX7T4BolRiNJ0c3p /FJ6w6TBUItx3/TaF1kitcByu4ufl2RUZUJasoEBGlx/IvP2/nADsB7hMGK3b5VaAK 7o68VE9qS5kpg== MIME-Version: 1.0 In-Reply-To: References: <20220711123519.217219-1-tmaimon77@gmail.com> <20220711123519.217219-5-tmaimon77@gmail.com> <20220711195544.70A30C34115@smtp.kernel.org> <20220718191454.5B5D3C341C0@smtp.kernel.org> <20220723030226.8E43CC341C6@smtp.kernel.org> Subject: Re: [PATCH v8 04/16] clk: npcm8xx: add clock controller From: Stephen Boyd Cc: Arnd Bergmann , Avi Fishman , Benjamin Fair , Biju Das , Bjorn Andersson , Catalin Marinas , Daniel Lezcano , Geert Uytterhoeven , Greg KH , Jonathan =?utf-8?q?Neusch=C3=A4fer?= , Jiri Slaby , Joel Stanley , Krzysztof Kozlowski , Guenter Roeck , Lubomir Rintel , Marcel Ziswiler , Michael Turquette , Nobuhiro Iwamatsu , Olof Johansson , Philipp Zabel , Robert Hancock , Rob Herring , Shawn Guo , Tali Perry , Thomas G leixner , Patrick Venture , Vinod Koul , Will Deacon , Wim Van Sebroeck , Nancy Yuen , devicetree , Linux Kernel Mailing List , linux-clk , SERIAL DRIVERS , LINUXWATCHDOG , Linux ARM To: Tomer Maimon Date: Fri, 29 Jul 2022 15:56:01 -0700 User-Agent: alot/0.10 Message-Id: <20220729225603.12528C433D6@smtp.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220729_155606_921274_729A5FE6 X-CRM114-Status: GOOD ( 19.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Tomer Maimon (2022-07-24 02:06:54) > On Sat, 23 Jul 2022 at 06:02, Stephen Boyd wrote: > > Furthermore, in DT, reg properties aren't supposed to overlap. When that > > happens it usually indicates the DT is being written to describe driver > > structure instead of the IP blocks that are delivered by the hardware > > engineer. In this case it sounds like a combined clk and reset IP block > > because they piled all the SoC glue stuff into a register range. Are > > there more features in this IO range? > > No, this range only combined the reset and clock together, but it > combined in a way that we cannot split it to two or even three > different registers... Because it is jumbled in some range? > > I do see a way to combine the clock and the reset driver, the NPCM > reset driver is serving other NPCM BMC's. > Should we use regmap to handle the clock registers instead of ioremap? Sure? Using regmap or not looks like a parallel discussion. How does it help use platform APIs? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel