From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4108BC19F2A for ; Sat, 30 Jul 2022 21:52:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qYCWWtPztQXuELeAMBb34HaKkEeagZNTzqCXtU9XF9M=; b=YYzKAVWVh2kuFc 0iNTQEE7IBa9+6qqBc58JV3DvgilA2Qn9cOHuos/focM9PQkYaXx0RKxJ/v5oVqyM62ZJpEuA08ue TBqx9CP6O0rgONAlNH62APq1uP5/dGiNBVflvjrZooCzshLSN+zJ2aTSEelObeaqt0mAoLFSZb+i9 NuKVDhtlwsXAMtyRSnRB8tA1JxxHoUjIqv0TRw3iJo6WE6WyxHQcCZqWi2bgErSeO4u/i7VYbyfwV jhQ5OPvej/aWU/36Ju74IzGZGpVKNEhEhR2YK0QrCA3bjqynP8bZRHXrwZo2jIKZacIXCkqfYGuZ3 3MpzYfFn2z6/GirsfMGg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oHuMN-004pF4-SM; Sat, 30 Jul 2022 21:50:59 +0000 Received: from mga14.intel.com ([192.55.52.115]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oHuMK-004pAU-Be for linux-arm-kernel@lists.infradead.org; Sat, 30 Jul 2022 21:50:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1659217856; x=1690753856; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=rND8XXV4IHwYTrk9ylOpb5YEXKqPDzYplKhRlcJ1akw=; b=MTzyMHnyQVf+wBmm0etCHp14DXQd5IBnB5HiSZo2Er2azv+7qTnS9ytX cX2W3hMcbHhnA3R1O+xFMC/09hK+wT4kdvbx9JKXebZzgQDMBHRfWCo9h s5W9l6TNireXmYfWbr7xDSVg8lO/DMISjKYuZDN0MaPB/cPwRibvo1VuV 8aO1YwN42M863eWuJN71eVIdshFpQv5oP5eSVksnLEzc1fulzztSdFGwJ yRd+BdMcnsRrApyLVzsLQnnP6MbHwcDyLRUh3NFg/JkpUmwY0N/bIQRN1 HhnOxeUTfHfAO4c1AOKPA3nZvjkuaw7Ulj4rCC5Gq3Usx2jNXQGk2hcGP A==; X-IronPort-AV: E=McAfee;i="6400,9594,10424"; a="288962530" X-IronPort-AV: E=Sophos;i="5.93,205,1654585200"; d="scan'208";a="288962530" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jul 2022 14:50:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,205,1654585200"; d="scan'208";a="704554267" Received: from lkp-server01.sh.intel.com (HELO e0eace57cfef) ([10.239.97.150]) by fmsmga002.fm.intel.com with ESMTP; 30 Jul 2022 14:50:49 -0700 Received: from kbuild by e0eace57cfef with local (Exim 4.96) (envelope-from ) id 1oHuMC-000DNX-1N; Sat, 30 Jul 2022 21:50:48 +0000 Date: Sun, 31 Jul 2022 05:50:22 +0800 From: kernel test robot To: Christophe JAILLET , andriy.shevchenko@linux.intel.com, vee.khee.wong@intel.com, weifeng.voon@intel.com, Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Joakim Zhang , Andrew Lunn Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/2] stmmac: intel: Add a missing clk_disable_unprepare() call in intel_eth_pci_remove() Message-ID: <202207310545.hHU5SagS-lkp@intel.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220730_145056_489833_B5CBF337 X-CRM114-Status: GOOD ( 15.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Christophe, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.19-rc8 next-20220728] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Christophe-JAILLET/stmmac-intel-Add-a-missing-clk_disable_unprepare-call-in-intel_eth_pci_remove/20220731-022139 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 620725263f4222b3c94d4ee19846835feec0ad69 config: x86_64-randconfig-a016 (https://download.01.org/0day-ci/archive/20220731/202207310545.hHU5SagS-lkp@intel.com/config) compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 52cd00cabf479aa7eb6dbb063b7ba41ea57bce9e) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/2d1d09034cc62ee19f799b92bb67640ba86ca557 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Christophe-JAILLET/stmmac-intel-Add-a-missing-clk_disable_unprepare-call-in-intel_eth_pci_remove/20220731-022139 git checkout 2d1d09034cc62ee19f799b92bb67640ba86ca557 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot All errors (new ones prefixed by >>): >> drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c:1107:24: error: use of undeclared identifier 'plat' clk_disable_unprepare(plat->stmmac_clk); ^ 1 error generated. vim +/plat +1107 drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c 1092 1093 /** 1094 * intel_eth_pci_remove 1095 * 1096 * @pdev: pci device pointer 1097 * Description: this function calls the main to free the net resources 1098 * and releases the PCI resources. 1099 */ 1100 static void intel_eth_pci_remove(struct pci_dev *pdev) 1101 { 1102 struct net_device *ndev = dev_get_drvdata(&pdev->dev); 1103 struct stmmac_priv *priv = netdev_priv(ndev); 1104 1105 stmmac_dvr_remove(&pdev->dev); 1106 > 1107 clk_disable_unprepare(plat->stmmac_clk); 1108 clk_unregister_fixed_rate(priv->plat->stmmac_clk); 1109 1110 pcim_iounmap_regions(pdev, BIT(0)); 1111 } 1112 -- 0-DAY CI Kernel Test Service https://01.org/lkp _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel