From: Samuel Holland <samuel@sholland.org>
To: Chen-Yu Tsai <wens@csie.org>, Jernej Skrabec <jernej.skrabec@gmail.com>
Cc: Samuel Holland <samuel@sholland.org>,
Arnd Bergmann <arnd@arndb.de>,
Hans de Goede <hdegoede@redhat.com>,
Icenowy Zheng <icenowy@aosc.io>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Maxime Ripard <mripard@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev
Subject: [PATCH 3/9] soc: sunxi: sram: Prevent the driver from being unbound
Date: Sun, 31 Jul 2022 22:05:03 -0500 [thread overview]
Message-ID: <20220801030509.21966-4-samuel@sholland.org> (raw)
In-Reply-To: <20220801030509.21966-1-samuel@sholland.org>
This driver exports a regmap tied to the platform device (as opposed to
a syscon, which exports a regmap tied to the OF node). Because of this,
the driver can never be unbound, as that would destroy the regmap. Use
builtin_platform_driver_probe() to enforce this limitation.
Fixes: 5828729bebbb ("soc: sunxi: export a regmap for EMAC clock reg on A64")
Signed-off-by: Samuel Holland <samuel@sholland.org>
---
drivers/soc/sunxi/sunxi_sram.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/soc/sunxi/sunxi_sram.c b/drivers/soc/sunxi/sunxi_sram.c
index f3d3f9259df9..a858a37fcdd4 100644
--- a/drivers/soc/sunxi/sunxi_sram.c
+++ b/drivers/soc/sunxi/sunxi_sram.c
@@ -330,7 +330,7 @@ static struct regmap_config sunxi_sram_emac_clock_regmap = {
.writeable_reg = sunxi_sram_regmap_accessible_reg,
};
-static int sunxi_sram_probe(struct platform_device *pdev)
+static int __init sunxi_sram_probe(struct platform_device *pdev)
{
struct dentry *d;
struct regmap *emac_clock;
@@ -410,9 +410,8 @@ static struct platform_driver sunxi_sram_driver = {
.name = "sunxi-sram",
.of_match_table = sunxi_sram_dt_match,
},
- .probe = sunxi_sram_probe,
};
-module_platform_driver(sunxi_sram_driver);
+builtin_platform_driver_probe(sunxi_sram_driver, sunxi_sram_probe);
MODULE_AUTHOR("Maxime Ripard <maxime.ripard@free-electrons.com>");
MODULE_DESCRIPTION("Allwinner sunXi SRAM Controller Driver");
--
2.35.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-08-01 3:07 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-01 3:05 [PATCH 0/9] soc: sunxi: sram: Fixes and D1 support Samuel Holland
2022-08-01 3:05 ` [PATCH 1/9] dt-bindings: sram: sunxi-sram: Add D1 compatible string Samuel Holland
2022-08-02 9:03 ` Krzysztof Kozlowski
2022-08-01 3:05 ` [PATCH 2/9] soc: sunxi: sram: Actually claim SRAM regions Samuel Holland
2022-08-14 10:21 ` Jernej Škrabec
2022-08-01 3:05 ` Samuel Holland [this message]
2022-08-14 10:26 ` [PATCH 3/9] soc: sunxi: sram: Prevent the driver from being unbound Jernej Škrabec
2022-08-01 3:05 ` [PATCH 4/9] soc: sunxi: sram: Fix probe function ordering issues Samuel Holland
2022-08-14 10:34 ` Jernej Škrabec
2022-08-01 3:05 ` [PATCH 5/9] soc: sunxi: sram: Fix debugfs info for A64 SRAM C Samuel Holland
2022-08-14 18:28 ` Jernej Škrabec
2022-08-01 3:05 ` [PATCH 6/9] soc: sunxi: sram: Return void from the release function Samuel Holland
2022-08-14 18:29 ` Jernej Škrabec
2022-08-01 3:05 ` [PATCH 7/9] soc: sunxi: sram: Save a pointer to the OF match data Samuel Holland
2022-08-14 18:29 ` Jernej Škrabec
2022-08-01 3:05 ` [PATCH 8/9] soc: sunxi: sram: Export the LDO control register Samuel Holland
2022-08-14 18:32 ` Jernej Škrabec
2022-08-01 3:05 ` [PATCH 9/9] soc: sunxi: sram: Add support for the D1 system control Samuel Holland
2022-08-14 18:33 ` Jernej Škrabec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220801030509.21966-4-samuel@sholland.org \
--to=samuel@sholland.org \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=hdegoede@redhat.com \
--cc=icenowy@aosc.io \
--cc=jernej.skrabec@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=mripard@kernel.org \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox