From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CC712C00140 for ; Mon, 1 Aug 2022 03:08:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0ziOO2YLs+jCeUKW1e6JlG4HX49+YTLievTXpbOWGH4=; b=kfU7OH9RLjiaho dErc8PejoDcAHzEHOaJXlaSgY1bHiqLfvM/8JNLGNkEbIZQUVVDuvVHvBGqhbFfuTUQfbwCn9PU3U 4Fj1feDQ7l3Nn+db/Rws+iX7wEMm2+IiWDIQfrrNRIGrXfJEi0XfuMbQO8rSH48e3yIbQhEggdEY1 FmZ+jLz9Xccz7a+rrDYjHs14JAz8VKouDtJX0JdbhatrkdVNl4XOwGxQvBvd7Vn+NlXMC+cXLMMmy LCgjxtjvmWCQlDeHWdsXcWcoirXdlGuggd9gr6FfzWbVAV1Chl5BqLHn68TA9r0TMkxuCbU6pRTO4 mDh/pWRoNOws+Y1VmQFg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oILmN-00136F-Ed; Mon, 01 Aug 2022 03:07:39 +0000 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oILkL-00122R-5Z for linux-arm-kernel@lists.infradead.org; Mon, 01 Aug 2022 03:05:34 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 81D5232007D7; Sun, 31 Jul 2022 23:05:31 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Sun, 31 Jul 2022 23:05:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sholland.org; h= cc:cc:content-transfer-encoding:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm1; t=1659323131; x=1659409531; bh=h3 4Ry2Qbm+JLSCIksskiScGwT/NymQyvjDKTXtJKZns=; b=YiywAwXiZXmSrasDvP dZrZpGxisYNG+ohJ3JzQbBGMGlDu5syc5x2UlBNH2hrrLZ0z8zUDJRrNOb6gFHQY 9P694EqS1/30Oq4Lbv+svTzebq2UBa6tHt+BrGJNFJXj1wiE33A3JIiENuxCvqGm T6+koEFAdysIaXcOBC7b0x6tylAaN5LEF58VUtMlnTnaf+SiKO3PkLGlnUVO+ZTe UsYuFMH6tJlL8kVjl+dhf0nqlf9ymxkVCAsZgIarqYm5/1xyCxKt73F/ridl2L0M u1fHdLMrGFaiknWtUh2tAUQF8FarvsZiziYWV9ydfrI2P3ZtYfJ9mtWsa26EoLO6 5Z8g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1659323131; x=1659409531; bh=h34Ry2Qbm+JLS CIksskiScGwT/NymQyvjDKTXtJKZns=; b=Jx7fvcr2/I3/hALlklGMX87ed38aC N9o5PHjS13LbfNXvkYhVMnNN7LY16vqBtKsRAfFeAp329yZgvx0OZDnFxDWh3NE7 va6gJZ+R3dFHam/WwUkKv+oZgWz8Vp8E8mdB9/EejFnis8T2ZDpy+NDRooWYXrnP NS9pqiPNeidcUaPxkKEWP6+UCXLYdjKlr55RjhDSmbgZ0GRpuGuBKkkf1JhYU56r I/uwNFQpQ4dVafnUltw1cVAzs98bQ+J0katfFNDjWCumvqkcRxAPZD05SyhNzke/ pWMQOScWJBPzY5A9LiMGALZSdVVrLCgFgv/O3wjVQQeYU062xkUI1mpmA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvddvvddgheejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhgggfestdekredtredttdenucfhrhhomhepufgrmhhu vghlucfjohhllhgrnhguuceoshgrmhhuvghlsehshhholhhlrghnugdrohhrgheqnecugg ftrfgrthhtvghrnhepudekteeuudehtdelteevgfduvddvjefhfedulefgudevgeeghefg udefiedtveetnecuvehluhhsthgvrhfuihiivgepfeenucfrrghrrghmpehmrghilhhfrh homhepshgrmhhuvghlsehshhholhhlrghnugdrohhrgh X-ME-Proxy: Feedback-ID: i0ad843c9:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 31 Jul 2022 23:05:30 -0400 (EDT) From: Samuel Holland To: Chen-Yu Tsai , Jernej Skrabec Cc: Samuel Holland , Arnd Bergmann , Hans de Goede , Icenowy Zheng , Krzysztof Kozlowski , Maxime Ripard , Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev Subject: [PATCH 6/9] soc: sunxi: sram: Return void from the release function Date: Sun, 31 Jul 2022 22:05:06 -0500 Message-Id: <20220801030509.21966-7-samuel@sholland.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220801030509.21966-1-samuel@sholland.org> References: <20220801030509.21966-1-samuel@sholland.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220731_200533_418524_85072407 X-CRM114-Status: GOOD ( 12.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org There is no point in returning an error here, as the caller can do nothing about it. In fact, all callers already ignore the return value. Signed-off-by: Samuel Holland --- drivers/soc/sunxi/sunxi_sram.c | 8 +++----- include/linux/soc/sunxi/sunxi_sram.h | 2 +- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/soc/sunxi/sunxi_sram.c b/drivers/soc/sunxi/sunxi_sram.c index 09754cd1d57d..9622fd45f5e5 100644 --- a/drivers/soc/sunxi/sunxi_sram.c +++ b/drivers/soc/sunxi/sunxi_sram.c @@ -261,25 +261,23 @@ int sunxi_sram_claim(struct device *dev) } EXPORT_SYMBOL(sunxi_sram_claim); -int sunxi_sram_release(struct device *dev) +void sunxi_sram_release(struct device *dev) { const struct sunxi_sram_data *sram_data; struct sunxi_sram_desc *sram_desc; if (!dev || !dev->of_node) - return -EINVAL; + return; sram_data = sunxi_sram_of_parse(dev->of_node, NULL); if (IS_ERR(sram_data)) - return -EINVAL; + return; sram_desc = to_sram_desc(sram_data); spin_lock(&sram_lock); sram_desc->claimed = false; spin_unlock(&sram_lock); - - return 0; } EXPORT_SYMBOL(sunxi_sram_release); diff --git a/include/linux/soc/sunxi/sunxi_sram.h b/include/linux/soc/sunxi/sunxi_sram.h index c5f663bba9c2..60e274d1b821 100644 --- a/include/linux/soc/sunxi/sunxi_sram.h +++ b/include/linux/soc/sunxi/sunxi_sram.h @@ -14,6 +14,6 @@ #define _SUNXI_SRAM_H_ int sunxi_sram_claim(struct device *dev); -int sunxi_sram_release(struct device *dev); +void sunxi_sram_release(struct device *dev); #endif /* _SUNXI_SRAM_H_ */ -- 2.35.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel