From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E5632C00140 for ; Wed, 3 Aug 2022 01:32:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=PQQAe1wkFBHixchD4+2FamBrvJgapamuvvB8XcPvFPM=; b=KAEBw5AEPHPdG1 sTL5ilC1FVcEhLtTB75n12ylhjcGcyqEV070tzwutVde98tVGZxSS5fBhX3dqFfvXM1Hw3c78i3zD Jq9Yd4n7s+GRRvRDVZ7+CAI9/veHH2A0eqPzDB0fhY+DzkoZORfrPUNTpyHACtyh38feq2E1DcPJa TQGMfzItZ1FwLQWepjFMx2pCFWoZMnmwLzCCpuw10L7bk9BuXsip7FkCBsOss3bKW19bwmqaacke0 9zVZXO4WR5ZZlb0vhJUSs68AZ9ndsGVX0t2qSIHKEmOCvNGkSFj22tK+Zn4l4UhbrmWz+8od951Zj gpVewzNqiLS1eFEi9g0Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oJ3Ec-001KPP-Ne; Wed, 03 Aug 2022 01:31:43 +0000 Received: from mail-pj1-x1031.google.com ([2607:f8b0:4864:20::1031]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oJ3EW-001KM1-Dm for linux-arm-kernel@lists.infradead.org; Wed, 03 Aug 2022 01:31:38 +0000 Received: by mail-pj1-x1031.google.com with SMTP id b4so5003786pji.4 for ; Tue, 02 Aug 2022 18:31:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc; bh=WhzCt7ZgW+LKbQwQvPVI6t++DQIekCJZ1n72lgrdeEc=; b=UfMtI5F0A32q8jVuYnhDA27lKBMWQ/8qOiUvDdoMk8XTjT+AHwCj3UumiD5U9MMxOv twpE3WsfikZnc9kUv3KbPA277def1HlItmhTT/aBAgvEG9aglUxpecD3TprBvxE0+zNN ZQaR+epa7rC0VZG5uR645bscnWRAQKSrkINuC7wpAkw8XpzGr+4H6NXOYcZUPuOP4tAX 5G3W7jNS9EHcm0v4AE7tQXPoXF9244qIdi40twGjxb3Dr46RDYMqv8smNHsMhfX1dKmB 3/GaoEfOGdC4w2y58ksD+sG7fmgTWD/1bFOAR+bTZnvc+tlAq64GJtsTn+nyWlmlmkpA CV1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc; bh=WhzCt7ZgW+LKbQwQvPVI6t++DQIekCJZ1n72lgrdeEc=; b=0YaltQhliV2oZF/THjDE94vMtB/pz7ReUvs85MdN4TIzoPTfN8QYp0ANWz73MiuAGZ E5nmDi/hsbE7LQmOluT+eqIMWjmPlB0DiUpP7iqcDRal9HI/98tp/3hk43145SZK017W TxFBJFZxU828j6MEfnIhScABLPhgh7qnT3xQyd8yCNmWqrNm/UsXyHYIuNXyv1HzSKwA N32Oo9LpBw3NTjIp4aKOx9M7WlaPHo/WD93OV1sKHro/wqVsThvud4RcIRZbiJ8VyFfR MFFw6S/KjZx3QiOaMU95r4oQaAdX9eV7XYxFe8mLZ4lYhSA7vsNjSQu7RNLgZdHg5qdv rBvA== X-Gm-Message-State: ACgBeo3lF4rJOsq1JoYN+D/hSveNmGhJxzt5NfC4JrFwRDIvfyoXzeEf gQjzHT6R1UwQ5mgPRNAK9wE= X-Google-Smtp-Source: AA6agR6XMDZHANAU7kA10nIDngUNjppbpRgEcfvum+qrO6pwYM9MdYrvKAGxNN2NIifQGCGyLZIi/A== X-Received: by 2002:a17:90a:a401:b0:1f2:19a0:2874 with SMTP id y1-20020a17090aa40100b001f219a02874mr2383446pjp.146.1659490291131; Tue, 02 Aug 2022 18:31:31 -0700 (PDT) Received: from sebin-inspiron.bbrouter ([103.148.20.125]) by smtp.gmail.com with ESMTPSA id x3-20020a1709027c0300b0016edb59f670sm369240pll.6.2022.08.02.18.31.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Aug 2022 18:31:30 -0700 (PDT) From: Sebin Sebastian To: Cc: mailmesebin00@gmail.com, Alessandro Zummo , Alexandre Belloni , Michal Simek , linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH -next] rtc: synqmp: uninitialized variable error Date: Wed, 3 Aug 2022 07:01:17 +0530 Message-Id: <20220803013117.318611-1-mailmesebin00@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220802_183137_293537_392A1264 X-CRM114-Status: GOOD ( 14.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org fract_tick is uninitialized and can lead to uninitialized read which can result in any arbitrary value from previous computations. If the code flow doesnt execute the `if (fract_offset > (tick_mult / RTC_FR_MAX_TICKS)) { ` block, fract_tick is left uninitialized. Initializing with zero fixes the issue. Signed-off-by: Sebin Sebastian --- drivers/rtc/rtc-zynqmp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-zynqmp.c b/drivers/rtc/rtc-zynqmp.c index 1dd389b891fe..c9b85c838ebe 100644 --- a/drivers/rtc/rtc-zynqmp.c +++ b/drivers/rtc/rtc-zynqmp.c @@ -203,7 +203,7 @@ static int xlnx_rtc_set_offset(struct device *dev, long offset) struct xlnx_rtc_dev *xrtcdev = dev_get_drvdata(dev); unsigned long long rtc_ppb = RTC_PPB; unsigned int tick_mult = do_div(rtc_ppb, xrtcdev->freq); - unsigned char fract_tick; + unsigned char fract_tick = 0; unsigned int calibval; short int max_tick; int fract_offset; -- 2.34.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel