From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C1B38C19F2A for ; Thu, 4 Aug 2022 17:29:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=oafUw/qr28+Mwrfy68AfvuOX0B/u+hjJkujEm5bXuFY=; b=3a8ummZNHp2wcU gq3mxL7Wa5/h8rjsfwFUmXHU5pj0R0P3c8USfe/+uqQuqRE1OV9RMh3ADEHqpdmLgBL++V3Bs7yQp 4jNgQ9lVK2Kp5T7MjwNNfpQCSYiUkBnje5vAt43Xgn3wjuZllR7oMkvte4sLhLHRKSCjg1m0tB7Yx 0ftk7you1QPiOuraFsDLTSqzw+nKLzXVfnQ76RKnese5SqIWs5iPQ28+DgMU+pXSDvP4KCIXHLaae R7VEaG0lIggl/83b+WKF+c3B1LPbPAjMlRZS66KJ+3SqgcTWV0dFw6BymV30P1lggc3WM1AxqI7yT ra82BuZPD992AEu6ZFHA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oJedg-007pTH-6S; Thu, 04 Aug 2022 17:28:04 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oJedc-007pRI-8I; Thu, 04 Aug 2022 17:28:01 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DFC8E61540; Thu, 4 Aug 2022 17:27:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 118A4C433D6; Thu, 4 Aug 2022 17:27:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1659634078; bh=dmSrkl/IWyIBVuUL9KetxyU+zq8M3qYRMqtV+KA7yh0=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=S8roUZAIbKjf8HZdyuWka8Q18Md0NJxc9hBf/nnvAtP7nK0VLdaIMmPPf47hurRqE /aepD4y2ZkGYe9PFB6o/y5+olcyDOnTyJUmRrujHRrdLkS4UMSq8q+vR/OKZbSKCrx zqpnT2jFplije8gd4zRpYULc9nRpw8b6qaZCuG6UGe9vypfer2F4LTJWDWRyVhCKFl atLy71cdUoItchEZBhgV8johMg0HCwM7migQv8kgVg/K/XwV6k5Nvx8PIXHc2K9uWA ZyQ47wixHJCNZeLiZ9+i4sa9ZCdYS+b6Uma04mf96CZjnZxv7PVvxd55Z77hBhiEXL Rhgw1lHx/RaLQ== Date: Thu, 4 Aug 2022 12:27:56 -0500 From: Bjorn Helgaas To: Jim Quinlan Cc: Cyril Brulebois , linux-pci , Nicolas Saenz Julienne , Bjorn Helgaas , Lorenzo Pieralisi , Florian Fainelli , bcm-kernel-feedback-list , Jim Quinlan , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , open list , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , Rob Herring Subject: Re: [PATCH v3 0/7] PCI: brcmstb: Re-submit reverted patchset Message-ID: <20220804172756.GA944222@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220804_102800_393517_C3F1D174 X-CRM114-Status: GOOD ( 46.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Aug 04, 2022 at 01:05:04PM -0400, Jim Quinlan wrote: > On Mon, Aug 1, 2022 at 6:19 PM Bjorn Helgaas wrote: > > On Tue, Jul 26, 2022 at 04:41:09PM -0700, Florian Fainelli wrote: > > > On 7/26/22 15:03, Bjorn Helgaas wrote: > > > > On Mon, Jul 25, 2022 at 11:12:49AM -0400, Jim Quinlan wrote: > > > >> ... > > > >> Jim Quinlan (7): > > > >> PCI: brcmstb: Remove unnecessary forward declarations > > > >> PCI: brcmstb: Split brcm_pcie_setup() into two funcs > > > >> PCI: brcmstb: Gate config space access on link status > > > >> PCI: brcmstb: Add mechanism to turn on subdev regulators > > > >> PCI: brcmstb: Add control of subdevice voltage regulators > > > >> PCI: brcmstb: Do not turn off WOL regulators on suspend > > > >> PCI: brcmstb: Have .map_bus function names end with 'map_bus' > > > >> > > > >> drivers/pci/controller/pcie-brcmstb.c | 476 ++++++++++++++++++-------- > > > >> 1 file changed, 341 insertions(+), 135 deletions(-) > > > > > > > > I reworked these and put them on pci/ctrl/brcm for v5.20. This is a > > > > proposal, not something set in stone. But time is of the essence to > > > > figure out how we want to proceed. > > > > > > > > I changed a lot of stuff and it's likely I broke something in the > > > > process, so please take a look and test this out. Here's an outline > > > > of what I changed: > > > > > > > > - Moved the config access "link up" check earlier because it's not > > > > related to the power regulator patches. > > > > > > > > - Changed config access "link up" checks to use PCIE_ECAM_REG() > > > > instead of hard-coding 0xfff masks. The 32-bit accessors already > > > > mask out the low two bits, so we don't need to do that here. > > > > > > > > - Squashed pci_subdev_regulators_add_bus() directly into > > > > brcm_pcie_add_bus() for readability. Similarly for > > > > pci_subdev_regulators_remove_bus(). > > > > > > > > - This makes a clear split between: > > > > > > > > * A patch that adds get/enable of regulators, and starting the > > > > link after enabling regulators, and > > > > > > > > * A patch that disables/enables regulators for suspend/resume. > > > > > > > > - Since we only support one set of subregulator info (for one Root > > > > Port, and brcm_pcie_suspend_noirq() depends on this since it uses > > > > the pcie->sr pointer), use pcie->sr always instead of > > > > dev->driver_data. > > > > > > > > - Squashed wakeup device checking into the suspend/resume patch so > > > > there's not a time when suspend might turn off power to a wakeup > > > > device. > > > > > > > > - Renamed brcm_pcie_map_bus32() to brcm7425_pcie_map_bus() so it > > > > ends in "_map_bus()" like other drivers. Also, > > > > brcm7425_pcie_map_bus() doesn't actually depend on the 32-bitness. > > > > > > Attached is the diff between Jim's and your branch just so it is easier to see what moved around. > > > > > > Initial testing on an ARCH_BRCMSTB system with PCIe appears to be good, we don't have any regulator on that board so the dummy ones get picked up which is expected. Same thing with a Raspberry Pi 4B system. > > > > > > I could unbind and bind again and there were no reference count leaks on the regulators, so this looks good to me. > > > > > > Tested-by: Florian Fainelli > > > > > > of course, we should have Jim's test results as well as Cyril's ideally to make sure there are no regressions on the CM4 board. > > > > Cyril, any chance you could test this to be sure it fixes the problem > > you reported? This is in -next and hopefully headed for v5.20/v6.0 > > soon. > > Cyril sent me an email about a week ago saying that he probably > wouldn't have the bandwidth to test this. > I immediately ordered an overpriced CM4 via Ebay and it recently > arrived. I'm happy to say that this > patchset tests successfully, w/ or w/o a device in the slot. Great, thanks a lot for testing this! > That being said, there is an old device, when paired with the CM4, > works with RPi Linux but not with upstream Linux. It is unrelated > to this patchset; i.e. it fails w/ or w/o this patchset applied. I > know the reason for this failure: the current driver > assumes clkreq# asserted, which is true for all STB boards. I can add > a patch for this now or in the next release > cycle, your choice. It's too late for v5.20-rc1, but if this would fix a regression or otherwise exceptional bug, Lorenzo might still consider it for the v5.20. Bjorn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel