From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 19D80C19F21 for ; Thu, 4 Aug 2022 20:07:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:To:Cc:From:Subject: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OT2LLe7AseNjzCAFTrhHaZ783p5WQGsCaQQJK+U1luE=; b=tQUJ7Re/35Fz9x scYwjWvIl9gPZ5bWUsccuQ39k5S/AAUxn3GSRDZ/0iEX2FKCycaAJ4G9nhYm0QyW2Reyb9RB0G2Fp 5QOoqjNyGhjzgvDeCryxSoP1ifVbYEWhyiXZstW0qFSSMJJmhdIaYTdxDspKN6Z4Xsq0bJKpSZwo2 3YPPef06IjJhe9j505aq+Jr5QkAAYSFG6huaTBhL+W6mGTHEuyPLWP3/iscBlO4IIeiHGnGwuWNBK Kf7LFl2PLN4h3FkrQT3NaVQFNdEZ5JyC0BB7+7mzUfCFcereyqZ5Zqr9mVEbNgJNY+C/6y+Z/dGJ+ bzqGxh2IMYzEKmZt1KgA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oJh6X-008pGb-Nu; Thu, 04 Aug 2022 20:06:02 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oJh6P-008pDv-20 for linux-arm-kernel@lists.infradead.org; Thu, 04 Aug 2022 20:05:55 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id BB862B82431; Thu, 4 Aug 2022 20:05:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 60512C433C1; Thu, 4 Aug 2022 20:05:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1659643549; bh=DR5dO2HhWSe0IcUJOiD/fg0ANKhZCMxKZk0PtAJCVIE=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=ASDi46ygtgSS3Hd63mUk69Ip0+B6d8iPklvvrBFp7dK1MDB9txrTrDce8RR7Om83f VOtLQyfHm6vN+Jvl9dDxzsbJO7477LdDd1dhWchfqUt5pZ5w54r8qbrgm1uIln/zjO 1efVbVUaCoKX9s32agmUMURLeCnPKuhjMQOeWjjanJJnVcG4t/JCt/32kr34hi9OK3 GT0HZCbtDIn7WdhtQx2ETZiInLZKja3l9iXYW/X/va3cayacLrdkSKO7RBkVKfS4fc U9IgMn9zPNjxUM/P46K3k+ET9Q7mcqR632iBzdYXWfvK5w+7PEc/U2GPiWOPRY7+HM JWWCCDLkUTP2A== MIME-Version: 1.0 In-Reply-To: References: <20220711123519.217219-1-tmaimon77@gmail.com> <20220711123519.217219-5-tmaimon77@gmail.com> <20220711195544.70A30C34115@smtp.kernel.org> <20220718191454.5B5D3C341C0@smtp.kernel.org> <20220723030226.8E43CC341C6@smtp.kernel.org> <20220729225603.12528C433D6@smtp.kernel.org> Subject: Re: [PATCH v8 04/16] clk: npcm8xx: add clock controller From: Stephen Boyd Cc: Arnd Bergmann , Avi Fishman , Benjamin Fair , Biju Das , Bjorn Andersson , Catalin Marinas , Daniel Lezcano , Geert Uytterhoeven , Greg KH , Jonathan =?utf-8?q?Neusch=C3=A4fer?= , Jiri Slaby , Joel Stanley , Krzysztof Kozlowski , Guenter Roeck , Lubomir Rintel , Marcel Ziswiler , Michael Turquette , Nobuhiro Iwamatsu , Olof Johansson , Philipp Zabel , Robert Hancock , Rob Herring , Shawn Guo , Tali Perry , Thomas G leixner , Patrick Venture , Vinod Koul , Will Deacon , Wim Van Sebroeck , Nancy Yuen , devicetree , Linux Kernel Mailing List , linux-clk , SERIAL DRIVERS , LINUXWATCHDOG , Linux ARM To: Tomer Maimon Date: Thu, 04 Aug 2022 13:05:47 -0700 User-Agent: alot/0.10 Message-Id: <20220804200549.60512C433C1@smtp.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220804_130553_453748_0DADA06A X-CRM114-Status: GOOD ( 19.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Tomer Maimon (2022-08-04 07:01:30) > On Sat, 30 Jul 2022 at 01:56, Stephen Boyd wrote: > > > > Because it is jumbled in some range? > Yes. > > > > > > > > I do see a way to combine the clock and the reset driver, the NPCM > > > reset driver is serving other NPCM BMC's. > > > Should we use regmap to handle the clock registers instead of ioremap? > > > > Sure? Using regmap or not looks like a parallel discussion. How does it > > help use platform APIs? > I mean to use regmap API instead of platform API for handing the clock > and reset registers. > the regmap API gives only one user access to R/W (lock). > I will be happy to get more suggestions, on how should we solve this situation. > Using platform APIs means using platform_*() functions, not of_*() functions, which are open-firmware/DT related. Regmap can be used to operate on registers mapped as __iomem, which is different from platform APIs. Is having a lock even necessary? Do the reset and clk controls live within a shared register where we would need to prevent one driver from accessing that register at the same time as the other? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel