From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A0828C25B06 for ; Thu, 4 Aug 2022 23:40:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9LpIFnyX8HKgrYpQLfIeKH8QCD166TmqXdN148q9J18=; b=ZmWefdblEAnEUG Jo6TVL6knSpT64QsOpldSeDvI/DFn4II/eOIUj4ft3c2zsBSFkNyhRwhK0ZT2anXbJeoYIy96CPeY LJPQsgrqHP67OUvWbF8kQz8wZ0sereJfsMoGr3s2ISCQb2T24Z/D430D+J8BY2AHETdZ2XYOrYI7c p852sXmYJMZ+LZwGBHi2sFdqd8j5PIlZGj7hoUvggVOq4vyJU7sVBsHCxaLmdl9CXbxB7yKbCyz+C VnhvYjBNOID2fjTDGJ5NEnx0A10mo+gfnACEp/pwudNMCr/XIMbW5dxECrgpl1Iv+bKIcg5aP8jeN P9uKE0xrwV2ZYHwVPvTw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oJkQt-00A6Vm-FM; Thu, 04 Aug 2022 23:39:15 +0000 Received: from madras.collabora.co.uk ([46.235.227.172]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oJkQo-00A6Rx-PM; Thu, 04 Aug 2022 23:39:13 +0000 Received: from notapiano (pool-98-113-53-228.nycmny.fios.verizon.net [98.113.53.228]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madras.collabora.co.uk (Postfix) with ESMTPSA id A914B6601BF8; Fri, 5 Aug 2022 00:39:06 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1659656348; bh=d6Yj8quN+qhReF+CXCReEHbUa8q5Q9aLROw+IgGnAOo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ffw04upiyLlesxOxtKFs7rT4WrInmPhkgXCQZrlk1dDiSneFjp5ya+4MpdDWUzZH9 BH5aSxDIKmkYgV4wi9LOWgKLwbd2pEG7lfrb9vtXVzp6rHbSVmrOPz5Z/vXQPWhvlz 7eWbrir8r1+bMZM8xLfMGG6S/fAE3p0AdHiJW62uo4LZaqrjrFvtuCPscoU7XoD+lG GC48y/JAIppPY6gsLQzNFmY+lkwZB396XRnksov+DOvp52SrJ4C5n0/DHVRw8a89mV EPRm8I8hktbdt+Siizdqob9O97f6vSg8ZKCl2KFHGtf1/hdelCef8ZVG8Wa8UBF5NN JZckzzepo2G6Q== Date: Thu, 4 Aug 2022 19:39:02 -0400 From: =?utf-8?B?TsOtY29sYXMgRi4gUi4gQS4=?= Prado To: bchihi@baylibre.com Cc: rafael@kernel.org, rui.zhang@intel.com, daniel.lezcano@linaro.org, amitk@kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, khilman@baylibre.com, mka@chromium.org, robh+dt@kernel.org, krzk+dt@kernel.org, matthias.bgg@gmail.com, p.zabel@pengutronix.de, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, james.lo@mediatek.com, fan.chen@mediatek.com, louis.yu@mediatek.com, rex-bc.chen@mediatek.com, abailon@baylibre.com Subject: Re: [PATCH v8.1, 4/7] thermal: mediatek: Add LVTS driver for mt8192 thermal zones Message-ID: <20220804233902.h3hjpm56kzk663un@notapiano> References: <20220804130912.676043-1-bchihi@baylibre.com> <20220804130912.676043-5-bchihi@baylibre.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220804130912.676043-5-bchihi@baylibre.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220804_163911_122192_257F11FD X-CRM114-Status: GOOD ( 17.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Aug 04, 2022 at 03:09:09PM +0200, bchihi@baylibre.com wrote: > From: Michael Kao > = > Add a LVTS V4 (Low Voltage Thermal Sensor) driver to report junction > temperatures in MediaTek SoC mt8192 and register the maximum temperature > of sensors and each sensor as a thermal zone. > = > Signed-off-by: Yu-Chia Chang > Signed-off-by: Michael Kao > Signed-off-by: Ben Tseng > Signed-off-by: Alexandre Bailon > Signed-off-by: Balsam CHIHI You should have a Co-developed-by tag for each person that wrote the code [= 1]. [1] https://www.kernel.org/doc/html/latest/process/submitting-patches.html#= when-to-use-acked-by-cc-and-co-developed-by > --- [..] > --- /dev/null > +++ b/drivers/thermal/mediatek/lvts_thermal.c [..] > +static int prepare_calibration_data(struct lvts_data *lvts_data) > +{ [..] > + lvts_data->coeff.golden_temp =3D cal_data->golden_temp; > + dev_dbg(dev, "golden_temp =3D %d\n", cal_data->golden_temp); > + offset =3D snprintf(buffer, sizeof(buffer), "[lvts_cal] num:g_count:g_c= ount_rc "); > + for (i =3D 0; i < lvts_data->num_sensor; i++) > + offset +=3D snprintf(buffer + offset, sizeof(buffer) - offset, "%d:%d:= %d ", > + i, cal_data->count_r[i], cal_data->count_rc[i]); Like Angelo already mentioned [2], you're not using this string for anythin= g, so just remove the code. [2] https://lore.kernel.org/linux-mediatek/82f6cd96-65e2-57f7-b7c5-05c11187= 4087@collabora.com/ > + > + return 0; > +} [..] > +int lvts_device_read_count_rc_n_v4(struct lvts_data *lvts_data) > +{ [..] > + offset =3D snprintf(buffer, sizeof(buffer), "[COUNT_RC_NOW] "); > + for (i =3D 0; i < lvts_data->num_sensor; i++) > + offset +=3D snprintf(buffer + offset, sizeof(buffer) - offset, "%d:%d = ", i, > + cal_data->count_rc_now[i]); Again, just formatting a string and throwing it away, please just drop the = code. > + > + return 0; > +} [..] > +int lvts_resume(struct platform_device *pdev) > +{ > + struct lvts_data *lvts_data; > + int ret; > + > + lvts_data =3D (struct lvts_data *)platform_get_drvdata(pdev); > + ret =3D lvts_init(lvts_data); > + if (ret) > + return ret; > + > + return 0; > +} You have a bug in your resume path somewhere. I get this error during resum= e on mt8192-asurada-spherion: <1>[ 237.487428] Unable to handle kernel write to read-only memory at virt= ual address ffffc15096e491c0 <1>[ 237.496663] Mem abort info: <1>[ 237.499794] ESR =3D 0x000000009600004e <1>[ 237.504334] EC =3D 0x25: DABT (current EL), IL =3D 32 bits <1>[ 237.509982] SET =3D 0, FnV =3D 0 <1>[ 237.513444] EA =3D 0, S1PTW =3D 0 <1>[ 237.516911] FSC =3D 0x0e: level 2 permission fault <1>[ 237.522041] Data abort info: <1>[ 237.525263] ISV =3D 0, ISS =3D 0x0000004e <1>[ 237.529458] CM =3D 0, WnR =3D 1 <1>[ 237.532739] swapper pgtable: 4k pages, 48-bit VAs, pgdp=3D00000000417= 82000 <1>[ 237.539754] [ffffc15096e491c0] pgd=3D100000023ffff003, p4d=3D10000002= 3ffff003, pud=3D100000023fffe003, pmd=3D0060000041200f81 <0>[ 237.550821] Internal error: Oops: 9600004e [#1] PREEMPT SMP <4>[ 237.556669] Modules linked in: af_alg mtk_vcodec_dec_hw snd_soc_hdmi_= codec panel_edp mtk_vcodec_dec v4l2_vp9 v4l2_h264 mtk_vcodec_enc btusb mtk_= vcodec_common btrtl videobuf2_dma_contig uvcvideo btintel videobuf2_vmalloc= mtk_vpu btmtk videobuf2_memops v4l2_mem2mem mt7921e btbcm cdc_ether usbnet= videobuf2_v4l2 mt7921_common bluetooth crct10dif_ce videobuf2_common r8152= mt76_connac_lib videodev ecdh_generic ecc mc mt76 mac80211 sbs_battery cro= s_usbpd_charger cros_usbpd_logger cros_ec_chardev libarc4 pwm_cros_ec anx76= 25 snd_soc_rt5682_i2c elan_i2c snd_soc_rt5682 cros_ec_typec snd_soc_rl6231 = drm_dp_aux_bus typec drm_display_helper panfrost mediatek_drm drm_cma_helpe= r rtc_mt6397 drm_shmem_helper phy_mtk_mipi_dsi_drv gpu_sched mt8192_mt6359_= rt1015_rt5682 drm_kms_helper pwm_mtk_disp pwm_bl snd_soc_rt1015p snd_soc_mt= 8192_afe snd_soc_dmic snd_soc_mtk_common cfg80211 rfkill drm fuse backlight= ip_tables x_tables ipv6 <4>[ 237.637538] CPU: 1 PID: 533 Comm: bash Tainted: G W 5= .19.0-rc8-next-20220725+ #254 <4>[ 237.646781] Hardware name: Google Spherion (rev0 - 3) (DT) <4>[ 237.652539] pstate: 60400009 (nZCv daif +PAN -UAO -TCO -DIT -SSBS BTY= PE=3D--) <4>[ 237.659778] pc : lvts_device_enable_and_init+0xdc/0xf0 <4>[ 237.665198] lr : lvts_device_enable_and_init+0xc8/0xf0 <4>[ 237.670609] sp : ffff8000098eb9b0 <4>[ 237.674188] x29: ffff8000098eb9b0 x28: 0000000000000000 x27: 00000000= 00000003 <4>[ 237.681609] x26: ffff41b141151010 x25: ffffc15097260c50 x24: 00000000= 00000000 <4>[ 237.689028] x23: 0000000000000038 x22: 0000000000000001 x21: 00000000= 8502fc00 <4>[ 237.696448] x20: ffffc15096e49188 x19: 0000000000000003 x18: 00000000= 00000000 <4>[ 237.703867] x17: 0000000000000001 x16: ffffc15095cc9838 x15: 00000000= 000001ca <4>[ 237.711287] x14: 0000000000000002 x13: 0000000000000000 x12: 00000000= 0000045d <4>[ 237.718706] x11: 0000000000000000 x10: 00000000000027d0 x9 : ffffc150= 95d81d18 <4>[ 237.726126] x8 : ffffc150974eb008 x7 : ffff41b15fdc2f80 x6 : ffffc150= 95ce58c0 <4>[ 237.733545] x5 : 0000000000000000 x4 : ffff8000098eb6f0 x3 : 00000000= 00000000 <4>[ 237.740963] x2 : 7ec5fa8849bae900 x1 : 7ec5fa8849bae900 x0 : 00000000= 00000014 <4>[ 237.748383] Call trace: <4>[ 237.751091] lvts_device_enable_and_init+0xdc/0xf0 <4>[ 237.756155] lvts_init+0x180/0x520 <4>[ 237.759824] lvts_resume+0x1c/0x78 <4>[ 237.763494] platform_pm_resume+0x5c/0x80 <4>[ 237.767777] dpm_run_callback+0x80/0x2e8 <4>[ 237.771972] device_resume+0x90/0x1c0 <4>[ 237.775904] dpm_resume+0x110/0x470 <4>[ 237.779663] dpm_resume_end+0x20/0x38 <4>[ 237.783596] suspend_devices_and_enter+0x1e4/0xb90 <4>[ 237.788662] pm_suspend+0x270/0x318 <4>[ 237.792419] state_store+0x94/0x120 <4>[ 237.796176] kobj_attr_store+0x18/0x30 <4>[ 237.800198] sysfs_kf_write+0x54/0x80 <4>[ 237.804131] kernfs_fop_write_iter+0x128/0x1c0 <4>[ 237.808845] vfs_write+0x39c/0x510 <4>[ 237.812517] ksys_write+0x74/0x100 <4>[ 237.816187] __arm64_sys_write+0x24/0x30 <4>[ 237.820380] invoke_syscall+0x4c/0x110 <4>[ 237.824401] el0_svc_common.constprop.0+0x68/0x128 <4>[ 237.829464] do_el0_svc+0x34/0xc0 <4>[ 237.833048] el0_svc+0x4c/0xc0 <4>[ 237.836371] el0t_64_sync_handler+0xb8/0xc0 <4>[ 237.840824] el0t_64_sync+0x18c/0x190 <0>[ 237.844759] Code: 11000673 6b13001f 54fffaa8 52800280 (b9003a80) <4>[ 237.851129] ---[ end trace 0000000000000000 ]--- Thanks, N=EDcolas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel