Re: [PATCH v2 3/3] arm64: dts: rockchip: Add initial support for Pine64 PinePhone Pro

Krzysztof Kozlowski
2022-08-08T11:43:32Z

On 08/08/2022 14:12, Ondřej Jirman wrote:
> Hello,
>
> On Mon, Aug 08, 2022 at 09:35:55AM +0300, Krzysztof Kozlowski wrote:
>> On 06/08/2022 01:44, Tom Fitzhenry wrote:
>>
>> [...]
>>
>>> +
>>> + /* Power tree */
>>> + /* Root power source */
>>> + vcc_sysin: vcc-sysin {
>>
>> regulator-vcc-sysin
>
> Interestingly, most DTS files in rockchip/ use a -regulator
> suffix and none use regulator- prefix. And this is inconsistent
> across the larger DTS tree, because outside of rockchip/ most
> DTS use a prefix.
>
> Checked by grep -R 'regulator.*{' | grep -v state-me

Can be a suffix. Just pick one pattern.

Best regards,
Krzysztof