Re: [PATCH v2 3/3] arm64: dts: rockchip: Add initial support for Pine64 PinePhone Pro

Ondřej Jirman
2022-08-08T11:14:00Z

Hello,

On Mon, Aug 08, 2022 at 09:35:55AM +0300, Krzysztof Kozlowski wrote:
> On 06/08/2022 01:44, Tom Fitzhenry wrote:
>
> [...]
>
> > +
> > + /* Power tree */
> > + /* Root power source */
> > + vcc_sysin: vcc-sysin {
>
> regulator-vcc-sysin

Interestingly, most DTS files in rockchip/ use a -regulator
suffix and none use regulator- prefix. And this is inconsistent
across the larger DTS tree, because outside of rockchip/ most
DTS use a prefix.

Checked by grep -R 'regulator.*{' | grep -v state-me

regards,
o.

> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
>
> > + compatible = "regulator-fixed";
> > + regulator-name = "vcc_sysin";
> > + regulator-always-on;
> > + regulator-boot-on;
> > + };
> > +
> > + /* Main 3.3v supply */
> > + vcc3v3_sys: wifi_bat: vcc3v3-sys {
>
> regulator-.....
>
> > + compatible = "regulator-fixed";
> > + regulator-name = "vcc3v3_sys";
> > + regulator-always-on;
> > + regulator-boot-on;
> > + regulator-min-microvolt = <3300000>;
> > + regulator-max-microvolt = <3300000>;
> > + vin-supply = <&vcc_sysin>;
> > + };
> > +
> > + vcca1v8_s3: vcc1v8-s3 {
>
> regulator-.....
>
> > + compatible = "regulator-fixed";
> > + regulator-name = "vcca1v8_s3";
> > + regulator-min-microvolt = <1800000>;
> > + regulator-max-microvolt = <1800000>;
> > + vin-supply = <&vcc3v3_sys>;
> > + regulator-always-on;
> > + regulator-boot-on;
> > + };
> > +};
> > +
> Best regards,
> Krzysztof