From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B002BC19F2D for ; Tue, 9 Aug 2022 18:03:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:To:Cc:From:Subject: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uG0gC34vNh1ILlp64MpSxarKzKlAsulQrmLnaEB2FLo=; b=3G6L2oVcrlTV8Z OnpJYAdMO01ilO+1iHGTaDCJ0APjNcHCckVtBDL+RnnsvgdMoUuSMVq16N/E99GAk+z9f8XxvyftS ckXXOS/bMsO9bYD/GJJjtDUElGeJZcixevxw8QQN2Hr1aan4Pl0gfkmIP2oVztmsxwxfo4Xs0zGO7 7DG/y7UiXbQ6ZFZ1gtZhMETerwGe1BKY//ruvMB8iOESUbZDmlbgt9paYiWz2wE/Ry1CA+XXm5wtV YoyNokIvyJEOsDWM6EBkC9QCDxcgCuiA5bDwAMVxdnAm1/2+910je6WFBi13GgD1d5n4Wf0MC+zIC PZWOjcjmyikdBq1yGeBA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oLTYn-005Pog-3g; Tue, 09 Aug 2022 18:02:33 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oLTYj-005PnV-91 for linux-arm-kernel@lists.infradead.org; Tue, 09 Aug 2022 18:02:30 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8352461052; Tue, 9 Aug 2022 18:02:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 22D78C433D7; Tue, 9 Aug 2022 18:02:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1660068148; bh=lJgNFnKBAD3W6+nMLS3KtRGHN5jjeaSLik2catrtBLQ=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=EVR37ynfgVxGgjgEcwtYqTtzrPixXH1kEcatTawE2JTaQLXiYyQYFS0BBFgeu+h8v EZPPjLlL/PYOBVCfiH6txoSdeeTnHfasPst7YWKv2JM/YJ4GYmcU3rR37gYXoG6T8G tP3gn/ge/WhxnN44ArX0nXU7HFUhS3tkP4Zx6HylJl5+wXPeC49Wp/ofPrRlTGdNNQ CUQ1VOZ0EcrHZIDDngG6IXDCLZo9KD7Y73NN7nfVNkqbmKCVH7EvYpfFwnsb1DQ10F j2JbGFZ3NV0Bqz36vvyXli++/yhGzj4O+GzL4xloblwzImWisqCTTFFhT3W0ST4dWB IuAaqtX+CtyuQ== MIME-Version: 1.0 In-Reply-To: References: <20220711123519.217219-1-tmaimon77@gmail.com> <20220718191454.5B5D3C341C0@smtp.kernel.org> <20220723030226.8E43CC341C6@smtp.kernel.org> <20220729225603.12528C433D6@smtp.kernel.org> <20220804200549.60512C433C1@smtp.kernel.org> Subject: Re: [PATCH v8 04/16] clk: npcm8xx: add clock controller From: Stephen Boyd Cc: Arnd Bergmann , Avi Fishman , Benjamin Fair , Biju Das , Bjorn Andersson , Catalin Marinas , Daniel Lezcano , Geert Uytterhoeven , Greg KH , Jonathan =?utf-8?q?Neusch=C3=A4fer?= , Jiri Slaby , Joel Stanley , Krzysztof Kozlowski , Guenter Roeck , Lubomir Rintel , Marcel Ziswiler , Michael Turquette , Nobuhiro Iwamatsu , Olof Johansson , Philipp Zabel , Robert Hancock , Rob Herring , Shawn Guo , Tali Perry , Thomas G leixner , Patrick Venture , Vinod Koul , Will Deacon , Wim Van Sebroeck , Nancy Yuen , devicetree , Linux Kernel Mailing List , linux-clk , SERIAL DRIVERS , LINUXWATCHDOG , Linux ARM To: Tomer Maimon Date: Tue, 09 Aug 2022 11:02:26 -0700 User-Agent: alot/0.10 Message-Id: <20220809180228.22D78C433D7@smtp.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220809_110229_414191_2D96FCEC X-CRM114-Status: GOOD ( 16.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Tomer Maimon (2022-08-08 06:08:08) > On Mon, 8 Aug 2022 at 15:37, Tomer Maimon wrote: > > > Using platform APIs means using platform_*() functions, not of_*() > > > functions, which are open-firmware/DT related. Regmap can be used to > > > operate on registers mapped as __iomem, which is different from platform > > > APIs. > > I will use platform_get_resource() and devm_ioremap_resource() > > functions in the next version. > I will use platform_get_resource() and ioremap() function next > veriosn, is it fine? As stated earlier it will work for now but eventually you'll get patches from janitors trying to convert to a devm based API that reserves the register region. Can you ioremap the register once and register an auxiliary device and driver for the reset (or clk) part so that the driver can be moved out to the drivers/reset/ path? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel