From: Christoph Hellwig <hch@lst.de>
To: Mike Leach <mike.leach@linaro.org>
Cc: Christoph Hellwig <hch@lst.de>,
"Suzuki K. Poulose" <suzuki.poulose@arm.com>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Coresight ML <coresight@lists.linaro.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v4 7/7] configfs: Fix LOCKDEP nesting issues with fragment semaphores
Date: Thu, 11 Aug 2022 17:09:39 +0200 [thread overview]
Message-ID: <20220811150939.GA11253@lst.de> (raw)
In-Reply-To: <CAJ9a7VjhGYuJZFVJhdmeoNBvNJG1YngAdBcBgF0b8E3=w8oK1w@mail.gmail.com>
On Fri, Aug 05, 2022 at 03:15:53PM +0100, Mike Leach wrote:
> You are correct - in this patchset we are adding the use of a binary
> attribute to load and unload Coresight configurations and features -
> which action has a side effect of adding and removing entries in
> particular sub-directories in our configfs sub-system.
I don't think configfs was designed to be that dynamic. Especially
the fact that a write to a binary attribute, which is intended to
be just for passthrough to hardware is a bit concerning.
From your further description it sounds like this binary attribute
is loading structured data interpreted by the kernel, which really
isn't how binary attributes in configfs or sysfs are intended to
be used.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-08-11 15:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220706214338.19812-1-mike.leach@linaro.org>
[not found] ` <20220706214338.19812-8-mike.leach@linaro.org>
[not found] ` <20220728210158.GA25083@lst.de>
[not found] ` <CAJ9a7VhA=sCjzsT7PVrAs2v=Y4t5SRzxraUuyCAfP+z-oB3n=g@mail.gmail.com>
[not found] ` <20220729132435.GA28515@lst.de>
2022-08-05 14:15 ` [PATCH v4 7/7] configfs: Fix LOCKDEP nesting issues with fragment semaphores Mike Leach
2022-08-11 15:09 ` Christoph Hellwig [this message]
2022-08-31 12:15 ` Mike Leach
2022-07-04 15:42 [PATCH v4 0/7] coresight: syscfg: Extend configfs for config load Mike Leach
2022-07-04 15:42 ` [PATCH v4 7/7] configfs: Fix LOCKDEP nesting issues with fragment semaphores Mike Leach
2022-07-06 7:19 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220811150939.GA11253@lst.de \
--to=hch@lst.de \
--cc=coresight@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).