* [PATCH] Revert "soc: imx: imx8m-blk-ctrl: set power device name"
@ 2022-07-08 9:08 Marco Felsch
2022-07-26 9:16 ` Marco Felsch
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Marco Felsch @ 2022-07-08 9:08 UTC (permalink / raw)
To: shawnguo, l.stach, peng.fan; +Cc: kernel, linux-imx, festevam, linux-arm-kernel
This reverts commit 8239d67f59cf522dd4f7135392a2f9a3a25f9cff.
This change confuses the sysfs cleanup path since the rename is done
after the device registration.
Fixes: 8239d67f59cf ("soc: imx: imx8m-blk-ctrl: set power device name")
Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
---
drivers/soc/imx/imx8m-blk-ctrl.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/soc/imx/imx8m-blk-ctrl.c b/drivers/soc/imx/imx8m-blk-ctrl.c
index 07b60d125698..409b9dfebb20 100644
--- a/drivers/soc/imx/imx8m-blk-ctrl.c
+++ b/drivers/soc/imx/imx8m-blk-ctrl.c
@@ -271,7 +271,6 @@ static int imx8m_blk_ctrl_probe(struct platform_device *pdev)
ret = PTR_ERR(domain->power_dev);
goto cleanup_pds;
}
- dev_set_name(domain->power_dev, "%s", data->name);
domain->genpd.name = data->name;
domain->genpd.power_on = imx8m_blk_ctrl_power_on;
--
2.30.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] Revert "soc: imx: imx8m-blk-ctrl: set power device name"
2022-07-08 9:08 [PATCH] Revert "soc: imx: imx8m-blk-ctrl: set power device name" Marco Felsch
@ 2022-07-26 9:16 ` Marco Felsch
2022-08-11 9:08 ` Lucas Stach
2022-08-17 8:36 ` Shawn Guo
2 siblings, 0 replies; 4+ messages in thread
From: Marco Felsch @ 2022-07-26 9:16 UTC (permalink / raw)
To: shawnguo, l.stach, peng.fan; +Cc: linux-arm-kernel, festevam, linux-imx, kernel
Hi,
gentle ping.
Regards,
Marco
On 22-07-08, Marco Felsch wrote:
> This reverts commit 8239d67f59cf522dd4f7135392a2f9a3a25f9cff.
>
> This change confuses the sysfs cleanup path since the rename is done
> after the device registration.
>
> Fixes: 8239d67f59cf ("soc: imx: imx8m-blk-ctrl: set power device name")
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> ---
> drivers/soc/imx/imx8m-blk-ctrl.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/soc/imx/imx8m-blk-ctrl.c b/drivers/soc/imx/imx8m-blk-ctrl.c
> index 07b60d125698..409b9dfebb20 100644
> --- a/drivers/soc/imx/imx8m-blk-ctrl.c
> +++ b/drivers/soc/imx/imx8m-blk-ctrl.c
> @@ -271,7 +271,6 @@ static int imx8m_blk_ctrl_probe(struct platform_device *pdev)
> ret = PTR_ERR(domain->power_dev);
> goto cleanup_pds;
> }
> - dev_set_name(domain->power_dev, "%s", data->name);
>
> domain->genpd.name = data->name;
> domain->genpd.power_on = imx8m_blk_ctrl_power_on;
> --
> 2.30.2
>
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] Revert "soc: imx: imx8m-blk-ctrl: set power device name"
2022-07-08 9:08 [PATCH] Revert "soc: imx: imx8m-blk-ctrl: set power device name" Marco Felsch
2022-07-26 9:16 ` Marco Felsch
@ 2022-08-11 9:08 ` Lucas Stach
2022-08-17 8:36 ` Shawn Guo
2 siblings, 0 replies; 4+ messages in thread
From: Lucas Stach @ 2022-08-11 9:08 UTC (permalink / raw)
To: Marco Felsch, shawnguo, peng.fan
Cc: linux-arm-kernel, festevam, linux-imx, kernel
Am Freitag, dem 08.07.2022 um 11:08 +0200 schrieb Marco Felsch:
> This reverts commit 8239d67f59cf522dd4f7135392a2f9a3a25f9cff.
>
> This change confuses the sysfs cleanup path since the rename is done
> after the device registration.
>
> Fixes: 8239d67f59cf ("soc: imx: imx8m-blk-ctrl: set power device name")
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
> ---
> drivers/soc/imx/imx8m-blk-ctrl.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/soc/imx/imx8m-blk-ctrl.c b/drivers/soc/imx/imx8m-blk-ctrl.c
> index 07b60d125698..409b9dfebb20 100644
> --- a/drivers/soc/imx/imx8m-blk-ctrl.c
> +++ b/drivers/soc/imx/imx8m-blk-ctrl.c
> @@ -271,7 +271,6 @@ static int imx8m_blk_ctrl_probe(struct platform_device *pdev)
> ret = PTR_ERR(domain->power_dev);
> goto cleanup_pds;
> }
> - dev_set_name(domain->power_dev, "%s", data->name);
>
> domain->genpd.name = data->name;
> domain->genpd.power_on = imx8m_blk_ctrl_power_on;
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] Revert "soc: imx: imx8m-blk-ctrl: set power device name"
2022-07-08 9:08 [PATCH] Revert "soc: imx: imx8m-blk-ctrl: set power device name" Marco Felsch
2022-07-26 9:16 ` Marco Felsch
2022-08-11 9:08 ` Lucas Stach
@ 2022-08-17 8:36 ` Shawn Guo
2 siblings, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2022-08-17 8:36 UTC (permalink / raw)
To: Marco Felsch
Cc: l.stach, peng.fan, kernel, linux-imx, festevam, linux-arm-kernel
On Fri, Jul 08, 2022 at 11:08:53AM +0200, Marco Felsch wrote:
> This reverts commit 8239d67f59cf522dd4f7135392a2f9a3a25f9cff.
>
> This change confuses the sysfs cleanup path since the rename is done
> after the device registration.
>
> Fixes: 8239d67f59cf ("soc: imx: imx8m-blk-ctrl: set power device name")
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
Applied, thanks!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-08-17 8:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-08 9:08 [PATCH] Revert "soc: imx: imx8m-blk-ctrl: set power device name" Marco Felsch
2022-07-26 9:16 ` Marco Felsch
2022-08-11 9:08 ` Lucas Stach
2022-08-17 8:36 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).