From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C21A8C25B08 for ; Wed, 17 Aug 2022 19:56:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LkqKZY6eLxjQkx9M4Is0z/7fZtOQa+vW6T0V5C84QM8=; b=b+odBvDM2Irb39 6JfQSqolwcG1qM8rMKh0oom2ZKXYsV8WfvzMa8LF5J9Vr/Htztom2CzLE4C3XwIYBxR0w85H1w98y peeLZFRb1+nISLvAljkIrk92SIUQ0fuXNeZfVSTGGy7evqfTxPhrymdTnopF2FpdrZKWWakYMZb7X Gee8co9T3Py5NYzX02V0BIttPaJo5Q7pYvBuzCTpS59j+eORpDkeywRaKYm9d4F9p36RPdx/eBVaU 7qpzfQK+N5ZQJXF01+eF5o/ZAFbHwgfn75gOc3yzZycmtS3csnx8KMvQHfI8mZQNfu8+fiNrfWYCo zSh+YvropG1WzEPPVgmA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oOP8G-0060Nu-Ok; Wed, 17 Aug 2022 19:55:16 +0000 Received: from madras.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e5ab]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oOP8D-0060JT-QH; Wed, 17 Aug 2022 19:55:15 +0000 Received: from notapiano (unknown [70.107.189.129]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madras.collabora.co.uk (Postfix) with ESMTPSA id 43C6F66019FB; Wed, 17 Aug 2022 20:55:05 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1660766106; bh=HyKYDfF8C/EjS61VvfNy5zCttuH25Xk3EwKzKCsv2mU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DAVuz1nTEiUf8s45bB89PTn3EzZBWzGhrbmAfbSXSDAWAyQwwxE+3lWCkUG1Baxck xS+pUdIZU/7Nr6uN9zdmHxVu0g5d4OOCN81VVaTr8ndDis7WGCwSedV2IOD/jR95bD 8OBuhX1r8g6BI3bCF5HmdTuHn9IMSuq/uLxtQftGOIRdaNFNPmJRgPgPmzQgKnyscH xM+/NEi1ZWt01Gf/fWLg5vfGJmOlnRT3F4F9haSW/ol3Fds3YSakSeQvLc+34G5ykN hYm920WJjKTBQ2DggQ3XeIS93BcBYKltJ/b7ZV/r4DwjyIPU4s1VaCmpivQig7Tor2 N0w999/ahh/yQ== Date: Wed, 17 Aug 2022 15:55:00 -0400 From: =?utf-8?B?TsOtY29sYXMgRi4gUi4gQS4=?= Prado To: Hui Liu Cc: linus.walleij@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com, Project_Global_Chrome_Upstream_Group@mediatek.com, jianguo.zhang@mediatek.com, zhiyong.tao@mediatek.com, sean.wang@mediatek.com, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 2/2] pinctrl: mediatek: add mt8188 driver Message-ID: <20220817195500.d6roam5gyghburjs@notapiano> References: <20220801095215.10876-1-hui.liu@mediatek.com> <20220801095215.10876-3-hui.liu@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220801095215.10876-3-hui.liu@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220817_125514_028863_1F879431 X-CRM114-Status: GOOD ( 10.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Hui, On Mon, Aug 01, 2022 at 05:52:15PM +0800, Hui Liu wrote: > From: "Hui.Liu" > = > Add pinctrl driver support for MediaTek SoC mt8188. > = > Signed-off-by: Hui.Liu > --- [..] > --- /dev/null > +++ b/drivers/pinctrl/mediatek/pinctrl-mt8188.c [..] > +static const struct mtk_pin_field_calc mt8188_pin_mode_range[] =3D { > + PIN_FIELD(0, 177, 0x0300, 0x10, 0, 4), > +}; Missing blank line after declaration. > +static const struct mtk_pin_field_calc mt8188_pin_dir_range[] =3D { > + PIN_FIELD(0, 177, 0x0000, 0x10, 0, 1), > +}; Ditto. > +static const struct mtk_pin_field_calc mt8188_pin_di_range[] =3D { > + PIN_FIELD(0, 177, 0x0200, 0x10, 0, 1), > +}; Ditto. > +static const struct mtk_pin_field_calc mt8188_pin_do_range[] =3D { > + PIN_FIELD(0, 177, 0x0100, 0x10, 0, 1), > +}; Ditto. > +static const struct mtk_pin_field_calc mt8188_pin_smt_range[] =3D { [..] > +static const struct mtk_pin_reg_calc mt8188_reg_cals[PINCTRL_PIN_REG_MAX= ] =3D { > + [PINCTRL_PIN_REG_MODE] =3D MTK_RANGE(mt8188_pin_mode_range), > + [PINCTRL_PIN_REG_DIR] =3D MTK_RANGE(mt8188_pin_dir_range), > + [PINCTRL_PIN_REG_DI] =3D MTK_RANGE(mt8188_pin_di_range), > + [PINCTRL_PIN_REG_DO] =3D MTK_RANGE(mt8188_pin_do_range), > + [PINCTRL_PIN_REG_SMT] =3D MTK_RANGE(mt8188_pin_smt_range), > + [PINCTRL_PIN_REG_IES] =3D MTK_RANGE(mt8188_pin_ies_range), > + [PINCTRL_PIN_REG_TDSEL] =3D MTK_RANGE(mt8188_pin_tdsel_range), > + [PINCTRL_PIN_REG_RDSEL] =3D MTK_RANGE(mt8188_pin_rdsel_range), > + [PINCTRL_PIN_REG_PUPD] =3D MTK_RANGE(mt8188_pin_pupd_range), > + [PINCTRL_PIN_REG_R0] =3D MTK_RANGE(mt8188_pin_r0_range), > + [PINCTRL_PIN_REG_R1] =3D MTK_RANGE(mt8188_pin_r1_range), > + [PINCTRL_PIN_REG_PU] =3D MTK_RANGE(mt8188_pin_pu_range), > + [PINCTRL_PIN_REG_PD] =3D MTK_RANGE(mt8188_pin_pd_range), > + [PINCTRL_PIN_REG_DRV] =3D MTK_RANGE(mt8188_pin_drv_range), > + [PINCTRL_PIN_REG_DRV_ADV] =3D MTK_RANGE(mt8188_pin_drv_adv_range), > + [PINCTRL_PIN_REG_RSEL] =3D MTK_RANGE(mt8188_pin_rsel_range), Please use just space around the =3D instead of tabs. Like is done on mt818= 3, mt8186, mt8192 and mt8195. > +}; [..] > +static const struct mtk_pin_soc mt8188_data =3D { > + .reg_cal =3D mt8188_reg_cals, > + .pins =3D mtk_pins_mt8188, > + .npins =3D ARRAY_SIZE(mtk_pins_mt8188), > + .ngrps =3D ARRAY_SIZE(mtk_pins_mt8188), > + .eint_hw =3D &mt8188_eint_hw, > + .nfuncs =3D 8, > + .gpio_m =3D 0, > + .base_names =3D mt8188_pinctrl_register_base_name, > + .nbase_names =3D ARRAY_SIZE(mt8188_pinctrl_register_base_name), > + .bias_set_combo =3D mtk_pinconf_bias_set_combo, > + .pull_type =3D mt8188_pull_type, > + .pin_rsel =3D mt8188_pin_rsel_val_range, > + .npin_rsel =3D ARRAY_SIZE(mt8188_pin_rsel_val_range), > + .bias_get_combo =3D mtk_pinconf_bias_get_combo, Keep this one together with bias_set_combo. > + .drive_set =3D mtk_pinconf_drive_set_rev1, > + .drive_get =3D mtk_pinconf_drive_get_rev1, > + .adv_drive_set =3D mtk_pinconf_adv_drive_set_raw, > + .adv_drive_get =3D mtk_pinconf_adv_drive_get_raw, And also use spaces instead of tabs for all entries here. With those changes, Reviewed-by: N=EDcolas F. R. A. Prado Thanks, N=EDcolas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel