From: Arnd Bergmann <arnd@kernel.org>
To: linux-arm-kernel@lists.infradead.org, Bin Liu <b-liu@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Arnd Bergmann <arnd@arndb.de>,
Stefan Wahren <stefan.wahren@i2se.com>,
Felipe Balbi <balbi@ti.com>, Tony Lindgren <tony@atomide.com>
Cc: Randy Dunlap <rdunlap@infradead.org>,
Conor Dooley <conor.dooley@microchip.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 11/11] musb: fix USB_MUSB_TUSB6010 dependency
Date: Thu, 18 Aug 2022 15:57:20 +0200 [thread overview]
Message-ID: <20220818135737.3143895-10-arnd@kernel.org> (raw)
In-Reply-To: <20220818135737.3143895-1-arnd@kernel.org>
From: Arnd Bergmann <arnd@arndb.de>
Turning on NOP_USB_XCEIV as builtin broke the TUSB6010 driver because
of an older issue with the depencency.
It is not necessary to forbid NOP_USB_XCEIV=y in combination with
USB_MUSB_HDRC=m, but only the reverse, which causes the link failure
from the original Kconfig change.
Use the correct dependency to still allow NOP_USB_XCEIV=n or
NOP_USB_XCEIV=y but forbid NOP_USB_XCEIV=m when USB_MUSB_HDRC=m
to fix the multi_v7_defconfig for tusb.
Fixes: ab37a7a890c1 ("ARM: multi_v7_defconfig: Make NOP_USB_XCEIV driver built-in")
Fixes: c0442479652b ("usb: musb: Fix randconfig build issues for Kconfig options")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/usb/musb/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/musb/Kconfig b/drivers/usb/musb/Kconfig
index f906dfd360d3..6c8f7763e75e 100644
--- a/drivers/usb/musb/Kconfig
+++ b/drivers/usb/musb/Kconfig
@@ -86,7 +86,7 @@ config USB_MUSB_TUSB6010
tristate "TUSB6010"
depends on HAS_IOMEM
depends on ARCH_OMAP2PLUS || COMPILE_TEST
- depends on NOP_USB_XCEIV = USB_MUSB_HDRC # both built-in or both modules
+ depends on NOP_USB_XCEIV!=m || USB_MUSB_HDRC=m
config USB_MUSB_OMAP2PLUS
tristate "OMAP2430 and onwards"
--
2.29.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-08-18 14:21 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220818135522.3143514-1-arnd@kernel.org>
2022-08-18 13:57 ` [PATCH 02/11] ARM: defconfig: clean up multi_v4t and multi_v5 configs Arnd Bergmann
2022-08-18 13:57 ` [PATCH 03/11] ARM: defconfig: drop CONFIG_NET_VENDOR_ASIX=y Arnd Bergmann
2022-08-18 13:57 ` [PATCH 04/11] ARM: defconfig: drop CONFIG_SERIAL_OMAP references Arnd Bergmann
2022-08-22 5:46 ` Tony Lindgren
2022-08-18 13:57 ` [PATCH 05/11] ARM: defconfig: drop CONFIG_DRM_RCAR_LVDS Arnd Bergmann
2022-08-18 13:57 ` [PATCH 06/11] ARM: defconfig: drop CONFIG_PTP_1588_CLOCK=y Arnd Bergmann
2022-08-18 15:10 ` Richard Cochran
2022-08-18 13:57 ` [PATCH 07/11] ARM: defconfig: drop CONFIG_SND_SOC_FSL_SAI Arnd Bergmann
2022-08-18 13:57 ` [PATCH 08/11] ARM: defconfig: drop CONFIG_USB_FSL_USB2 Arnd Bergmann
2022-08-18 14:09 ` Greg Kroah-Hartman
2022-08-18 13:57 ` [PATCH 09/11] ARM: defconfig: drop CONFIG_MICROCHIP_PIT64B Arnd Bergmann
2022-08-19 7:31 ` Claudiu.Beznea
2022-08-18 13:57 ` [PATCH 10/11] ARM: defconfig: fix CONFIG_SND_SOC_AC97_CODEC name Arnd Bergmann
2022-08-18 13:57 ` Arnd Bergmann [this message]
2022-08-18 14:08 ` [PATCH 11/11] musb: fix USB_MUSB_TUSB6010 dependency Greg Kroah-Hartman
2022-08-18 14:27 ` Arnd Bergmann
2022-08-18 14:33 ` Greg Kroah-Hartman
2022-08-25 13:40 ` [PATCH 02/11] ARM: defconfig: clean up multi_v4t and multi_v5 configs Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220818135737.3143895-10-arnd@kernel.org \
--to=arnd@kernel.org \
--cc=arnd@arndb.de \
--cc=b-liu@ti.com \
--cc=balbi@ti.com \
--cc=conor.dooley@microchip.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=stefan.wahren@i2se.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).