From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Michael Walle <michael@walle.cc>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Shawn Guo <shawnguo@kernel.org>, Leo Li <leoyang.li@nxp.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH devicetree 0/3] NXP LS1028A DT changes for multiple switch CPU ports
Date: Thu, 18 Aug 2022 14:55:56 +0000 [thread overview]
Message-ID: <20220818145556.ieg37btfny3o2i4q@skbuf> (raw)
In-Reply-To: <8d3d96cdede2f1e40ed9ae5742a0468d@walle.cc>
On Thu, Aug 18, 2022 at 04:49:49PM +0200, Michael Walle wrote:
> Is it used automatically or does the userspace has to configure something?
DSA doesn't yet support multiple CPU ports, but even when it will, the
second DSA master still won't be used automatically. If you want more
details about the proposed UAPI to use the second CPU port, see here:
https://patchwork.kernel.org/project/netdevbpf/cover/20220523104256.3556016-1-olteanv@gmail.com/
> > Care has been taken that this change does not produce regressions when
> > using updated device trees with old kernels that do not support multiple
> > DSA CPU ports. The only difference for old kernels will be the
> > appearance of a new net device (for &enetc_port3) which will not be very
> > useful for much of anything.
>
> Mh, I don't understand. Does it now cause regressions or not? I mean
> besides that there is a new unused interface?
It didn't cause regressions until kernel 5.13 when commit adb3dccf090b
("net: dsa: felix: convert to the new .change_tag_protocol DSA API")
happened, then commit 00fa91bc9cc2 ("net: dsa: felix: fix tagging
protocol changes with multiple CPU ports") fixed that regression and was
backported to the linux-5.15.y stable branch AFAIR. So at least kernels
5.15 and newer should work properly with the new device trees.
> I was just thinking of that systemready stuff where the u-boot might
> supply its (newer) device tree to an older kernel, i.e. an older debian
> or similar.
>
> -michael
Yeah, I hear you, I'm doing my best to make the driver work with a
one-size-fits-all device tree, both ways around.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-08-18 14:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-18 14:05 [PATCH devicetree 0/3] NXP LS1028A DT changes for multiple switch CPU ports Vladimir Oltean
2022-08-18 14:05 ` [PATCH devicetree 1/3] arm64: dts: ls1028a: move DSA CPU port property to the common SoC dtsi Vladimir Oltean
2022-08-18 14:45 ` Michael Walle
2022-08-18 14:05 ` [PATCH devicetree 2/3] arm64: dts: ls1028a: mark enetc port 3 as a DSA master too Vladimir Oltean
2022-08-18 14:44 ` Michael Walle
2022-08-18 14:45 ` Vladimir Oltean
2022-08-18 15:08 ` Michael Walle
2022-08-22 3:53 ` Shawn Guo
2022-08-18 14:05 ` [PATCH devicetree 3/3] arm64: dts: ls1028a: enable swp5 and eno3 for all boards Vladimir Oltean
2022-08-18 15:06 ` Michael Walle
2022-08-18 14:49 ` [PATCH devicetree 0/3] NXP LS1028A DT changes for multiple switch CPU ports Michael Walle
2022-08-18 14:55 ` Vladimir Oltean [this message]
2022-08-18 15:05 ` Michael Walle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220818145556.ieg37btfny3o2i4q@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@walle.cc \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox