From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5E12BC00140 for ; Thu, 18 Aug 2022 21:30:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:To:Cc:From:Subject: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bQXW2tr+kiDWiSIVyucgCEdocnRAt1jIqpH6sews5L0=; b=U3qgdCRlPoEBmY A1yfq9JxQCYSxxmh1YbrD4ofyII3Y3STdw0f31prmNQmoFTbExPVJmqonGAShkW+BO9dN58S4a77v WvgwZ+vMGFCygRjhxM/LgoJChuUscQOhbPyvY/Wc1WNP/ktNPcpOkzcy85VAgITEEhKWLach1rFpf 8Nx1QhbrLRMlpL/fqyEQxze+lbc5ZMP8e9SwxLHRs9LFnDn44gPOBnPU46Lo/la/tpkU9pZ1kFWBw gjmlrbx0SEbk5hhmPTy2JForHCAGEYicS7y0MvmajXXjhoQlJkxnNlqWf0EJPBg5lsrbb+Y10hmag 6mjDYFkXbsyZcHmKNnVA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oOn4o-009qb6-01; Thu, 18 Aug 2022 21:29:18 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oOn4l-009qZZ-NS; Thu, 18 Aug 2022 21:29:16 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 31CDC616A1; Thu, 18 Aug 2022 21:29:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7FC43C433D6; Thu, 18 Aug 2022 21:29:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1660858153; bh=FipX6TVhrxxHlLkeH5ciwQ7iKPbNA0jvMsmy8hdNRVs=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=NXopHnykGh+XHvpPSsAr1PicYgKojNMOjbNGWZ2RLkbOutAOlwZlGtBHjKiDClZ/h mFdGpx625eZyQcJ7gtko3p0RysfP8L8LHRcAeKpwCXoV8gNlYblZq0tyYC/DEc9sEe ApZedc47hAVg4FG/QM00AaJpXnrLOsgN+q2cbNQgVOPpXDE9/RCA10cCWzqLXUqiBX AyXijggm84IOZPXK+wloH42vbZL/uMhbqnSiKEsL2p65FJhp8eTc+9O2umwqgSitm0 W0sGhKd/LNZyJ+dmbUfi9mzd33atwR6qbTy60Yl/5agGESK5MPCs/ekf/3Mrfer0eU 5FR7MMDmo65ww== MIME-Version: 1.0 In-Reply-To: <20220818124132.125304-11-jagan@edgeble.ai> References: <20220818124132.125304-1-jagan@edgeble.ai> <20220818124132.125304-11-jagan@edgeble.ai> Subject: Re: [PATCH v3 10/19] dt-bindings: clock: rockchip: Document RV1126 CRU From: Stephen Boyd Cc: linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, Jagan Teki , linux-clk@vger.kernel.org, Michael Turquette , Krzysztof Kozlowski To: Heiko Stuebner , Jagan Teki , Kever Yang , Krzysztof Kozlowski , Rob Herring Date: Thu, 18 Aug 2022 14:29:11 -0700 User-Agent: alot/0.10 Message-Id: <20220818212913.7FC43C433D6@smtp.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220818_142915_821760_73DD87AE X-CRM114-Status: UNSURE ( 9.63 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Jagan Teki (2022-08-18 05:41:23) > + > + clocks: > + maxItems: 1 > + > + clock-names: > + const: xin24m > + > + rockchip,grf: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: > + Phandle to the syscon managing the "general register files" (GRF), > + if missing pll rates are not changeable, due to the missing pll > + lock status. > + > +required: > + - compatible > + - reg > + - "#clock-cells" > + - "#reset-cells" Why aren't clocks required? > + > +additionalProperties: false > + > +examples: > + - | > + cru: clock-controller@ff490000 { > + compatible = "rockchip,rv1126-cru"; > + reg = <0xff490000 0x1000>; > + rockchip,grf = <&grf>; > + #clock-cells = <1>; > + #reset-cells = <1>; Can you add 'clocks' property to the binding? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel