From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DFF7AC00140 for ; Thu, 18 Aug 2022 21:48:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EQ8DbTxOV0cf+YYcSrytUxip4IJPXCm+SuoBnW2gU3I=; b=LR0Eza0NHcTK9A DMDk4nGPkPT0fqD9QYThvabThNV8MbLP0AsEcNwBLaNVQ+11W6a+EvEeA4jpGO7RL/cSdaQN5enYL Mb16eM+jh313/kgK0X/0QG01YsSKeOrX0pLikpE+g5gN0GwA9EnwyhkMm11hdwHlkwsO1X9q284g7 UqYvxYxyydu59+0hGU7fHy77aOP5Fo4NouxuI53/zovlOoY/QkCOAI1BBGWrZA0Mg6tvcRSHuUHLB CyWgkwelFhIyiZ0CUJZvZbQgASKUg/mrm7BuTHUbl19KJmAB1A3MtTzo81EfTM2W9bWR0rEdG7Owy 1NjvlcYmYUiYndeXWahQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oOnMQ-00A1tq-2K; Thu, 18 Aug 2022 21:47:30 +0000 Received: from madras.collabora.co.uk ([46.235.227.172]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oOnMN-00A1pm-06; Thu, 18 Aug 2022 21:47:28 +0000 Received: from notapiano (unknown [70.107.189.129]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madras.collabora.co.uk (Postfix) with ESMTPSA id D240C66019FB; Thu, 18 Aug 2022 22:47:19 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1660859242; bh=4gpnxl75xpqaey0GgS05hQ2JXOenf1aNFuT3t037TNI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EBmaQbanWlisUZo1v/tUYoK4/8bd1j2jFm+u8dfqyZyuoSE/phFCvdoPoFPZhKznK nPeMwAmGGLT5K17WA4PUxXe0K1C348e+lgDNFTWzgzFIM9aVaP9DzGGaWCova5fRSw p4DLeWH/351NFNk74MtG0Pp+P6P+JGvL4vePwP79wuPrh9+HdDpPPAJXlBnQHW3joR WfLEjwp6fINYl9EkAFnP+iMaFp318UG778MjeJ/iBvJr4xqscK80dGDR47Id72M6OF 3nQzJxx9bIMXimOoL56w8Lt+vvTtpq8SvlxQRYDIKjC2dKF9bEHyy3ghx6TFTQ5gPO 97/mIlif/FRJA== Date: Thu, 18 Aug 2022 17:47:15 -0400 From: =?utf-8?B?TsOtY29sYXMgRi4gUi4gQS4=?= Prado To: "Nancy.Lin" Cc: Rob Herring , Matthias Brugger , Chun-Kuang Hu , Philipp Zabel , wim@linux-watchdog.org, AngeloGioacchino Del Regno , linux@roeck-us.net, David Airlie , Daniel Vetter , Nathan Chancellor , Nick Desaulniers , "jason-jh . lin" , Yongqiang Niu , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, dri-devel@lists.freedesktop.org, llvm@lists.linux.dev, singo.chang@mediatek.com, Project_Global_Chrome_Upstream_Group@mediatek.com Subject: Re: [PATCH v25 07/10] soc: mediatek: mmsys: add mmsys for support 64 reset bits Message-ID: <20220818214715.spbyic34szubx3gi@notapiano> References: <20220711075245.10492-1-nancy.lin@mediatek.com> <20220711075245.10492-8-nancy.lin@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220711075245.10492-8-nancy.lin@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220818_144727_214075_92DABDAB X-CRM114-Status: GOOD ( 12.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Nancy, On Mon, Jul 11, 2022 at 03:52:42PM +0800, Nancy.Lin wrote: [..] > static const struct mtk_mmsys_driver_data mt2701_mmsys_driver_data =3D { > .clk_driver =3D "clk-mt2701-mm", > .routes =3D mmsys_default_routing_table, > @@ -86,6 +88,7 @@ static const struct mtk_mmsys_driver_data mt8173_mmsys_= driver_data =3D { > .routes =3D mmsys_default_routing_table, > .num_routes =3D ARRAY_SIZE(mmsys_default_routing_table), > .sw0_rst_offset =3D MT8183_MMSYS_SW0_RST_B, > + .num_resets =3D 32, > }; > = > static const struct mtk_mmsys_match_data mt8173_mmsys_match_data =3D { > @@ -100,6 +103,7 @@ static const struct mtk_mmsys_driver_data mt8183_mmsy= s_driver_data =3D { > .routes =3D mmsys_mt8183_routing_table, > .num_routes =3D ARRAY_SIZE(mmsys_mt8183_routing_table), > .sw0_rst_offset =3D MT8183_MMSYS_SW0_RST_B, > + .num_resets =3D 32, > }; > = > static const struct mtk_mmsys_match_data mt8183_mmsys_match_data =3D { > @@ -114,6 +118,7 @@ static const struct mtk_mmsys_driver_data mt8186_mmsy= s_driver_data =3D { > .routes =3D mmsys_mt8186_routing_table, > .num_routes =3D ARRAY_SIZE(mmsys_mt8186_routing_table), > .sw0_rst_offset =3D MT8186_MMSYS_SW0_RST_B, > + .num_resets =3D 32, > }; [..] > @@ -351,18 +362,6 @@ static int mtk_mmsys_probe(struct platform_device *p= dev) > return ret; > } > = > - spin_lock_init(&mmsys->lock); > - > - mmsys->rcdev.owner =3D THIS_MODULE; > - mmsys->rcdev.nr_resets =3D 32; The number of resets was previously always set to 32, and now you're instead setting it based on num_resets from each machine. The issue is, you're forgetting a bunch of them. mt8192 didn't get a num_reset, so this commit breaks the display on mt8192 = based devices. But mt8192 isn't the only one, there are other platforms missing t= his property. Please set num_resets to 32 in every single one of them, otherwise there will be display regressions. Thanks, N=EDcolas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel