From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 98050C32771 for ; Fri, 19 Aug 2022 14:27:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TtrDBroarNATQ5IC2auj728NXJOhloPGm3O1/3ZFIAE=; b=X0Qd/R3WkygNR0 C+MJolx+VOkJ1qc0Ce4s1R65CqXFZr3NwPOooIW8nV1c2oNXe71Ar+6mQESK2Cum/WmTHh1IIrWdB xOfs8jOJJupeVDJJ+Rj0H8B/3L/S6nUJZPpwz/dRPUDjiUXwqn0ygiEmZO8HS4HYHWZhrS5lWimgC HALFPXVGipOzcuS55UTZk4fFWLLz5z+ncgWpt1D4D2+hWOZOthi3cGMI1r8xtnSjqB1JFwZfmurne AYa2sv3seUcxTwKXG0b5xeyCiIcfyaFT9wu6Em+Vn8L0JPJVSJtD5wpb+OkrZkekRTsVS5MJ5YulG AyzvVBGrH5ksg4bPbCwA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oP2wK-009TkH-Vh; Fri, 19 Aug 2022 14:25:37 +0000 Received: from madras.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e5ab]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oP2wG-009Tho-O3; Fri, 19 Aug 2022 14:25:34 +0000 Received: from notapiano (unknown [70.107.189.129]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madras.collabora.co.uk (Postfix) with ESMTPSA id 64F796601DC3; Fri, 19 Aug 2022 15:25:26 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1660919128; bh=LVvo/H0yD5IHtK3BCe8kCRuEpXJ/0WbPUX2JGtIkvgQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BRORHC1ycbpuGPFg/CMbY1HXG9CbZw4mD7QI+HegRtsRqLIKpA/blhXZFcCxxTwSe CFPxPAyaltAW76paK8ntAjomzoOPjkNOtVVBeAi2QyofZ2hjkE0B6ZFtIoL8KXYC5H 9Uwy6/Vbl5vdJpybntjkT4r/XtG+b10BHFnRmqYHar17voYPOQO+atkovGyYsHZTCQ I/mrcDhrSCILIKryUZfcVvlp/9NgDGzRHqEtcXYzq9B1XoGhk/ugm6JiJ6a7L5fGo9 oLDayXKm/kpvfkJ10EN22YLo7a7r7rVTCnpSVRxwt+qj1PZ26gwehcF1fc0feVsogX x24TsgoxwUDQw== Date: Fri, 19 Aug 2022 10:25:22 -0400 From: =?utf-8?B?TsOtY29sYXMgRi4gUi4gQS4=?= Prado To: "Nancy.Lin" Cc: Rob Herring , Matthias Brugger , Chun-Kuang Hu , Philipp Zabel , wim@linux-watchdog.org, AngeloGioacchino Del Regno , linux@roeck-us.net, David Airlie , Daniel Vetter , Nathan Chancellor , Nick Desaulniers , "jason-jh . lin" , Yongqiang Niu , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, dri-devel@lists.freedesktop.org, llvm@lists.linux.dev, singo.chang@mediatek.com, Project_Global_Chrome_Upstream_Group@mediatek.com Subject: Re: [PATCH v25 07/10] soc: mediatek: mmsys: add mmsys for support 64 reset bits Message-ID: <20220819142522.c4o3nrkxfj2r3zd7@notapiano> References: <20220711075245.10492-1-nancy.lin@mediatek.com> <20220711075245.10492-8-nancy.lin@mediatek.com> <20220818214715.spbyic34szubx3gi@notapiano> <12062a2e2957113d40b4bf3c1c62d18418b51a12.camel@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <12062a2e2957113d40b4bf3c1c62d18418b51a12.camel@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220819_072533_163929_EC21337B X-CRM114-Status: GOOD ( 30.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 19, 2022 at 12:13:23PM +0800, Nancy.Lin wrote: > Hi Nicolas, > = > = > On Fri, 2022-08-19 at 10:09 +0800, Nancy.Lin wrote: > > Hi Nicolas, > > = > > Thanks for the review. > > = > > On Thu, 2022-08-18 at 17:47 -0400, N=EDcolas F. R. A. Prado wrote: > > > Hi Nancy, > > > = > > > On Mon, Jul 11, 2022 at 03:52:42PM +0800, Nancy.Lin wrote: > > > [..] > > > > static const struct mtk_mmsys_driver_data > > > > mt2701_mmsys_driver_data > > > > =3D { > > > > .clk_driver =3D "clk-mt2701-mm", > > > > .routes =3D mmsys_default_routing_table, > > > > @@ -86,6 +88,7 @@ static const struct mtk_mmsys_driver_data > > > > mt8173_mmsys_driver_data =3D { > > > > .routes =3D mmsys_default_routing_table, > > > > .num_routes =3D ARRAY_SIZE(mmsys_default_routing_table), > > > > .sw0_rst_offset =3D MT8183_MMSYS_SW0_RST_B, > > > > + .num_resets =3D 32, > > > > }; > > > > = > > > > static const struct mtk_mmsys_match_data mt8173_mmsys_match_data > > > > =3D > > > > { > > > > @@ -100,6 +103,7 @@ static const struct mtk_mmsys_driver_data > > > > mt8183_mmsys_driver_data =3D { > > > > .routes =3D mmsys_mt8183_routing_table, > > > > .num_routes =3D ARRAY_SIZE(mmsys_mt8183_routing_table), > > > > .sw0_rst_offset =3D MT8183_MMSYS_SW0_RST_B, > > > > + .num_resets =3D 32, > > > > }; > > > > = > > > > static const struct mtk_mmsys_match_data mt8183_mmsys_match_data > > > > =3D > > > > { > > > > @@ -114,6 +118,7 @@ static const struct mtk_mmsys_driver_data > > > > mt8186_mmsys_driver_data =3D { > > > > .routes =3D mmsys_mt8186_routing_table, > > > > .num_routes =3D ARRAY_SIZE(mmsys_mt8186_routing_table), > > > > .sw0_rst_offset =3D MT8186_MMSYS_SW0_RST_B, > > > > + .num_resets =3D 32, > > > > }; > > > = > > > [..] > > > > @@ -351,18 +362,6 @@ static int mtk_mmsys_probe(struct > > > > platform_device *pdev) > > > > return ret; > > > > } > > > > = > > > > - spin_lock_init(&mmsys->lock); > > > > - > > > > - mmsys->rcdev.owner =3D THIS_MODULE; > > > > - mmsys->rcdev.nr_resets =3D 32; > > > = > > > The number of resets was previously always set to 32, and now > > > you're > > > instead > > > setting it based on num_resets from each machine. The issue is, > > > you're > > > forgetting a bunch of them. > > > = > > > mt8192 didn't get a num_reset, so this commit breaks the display on > > > mt8192 based > > > devices. But mt8192 isn't the only one, there are other platforms > > > missing this > > > property. Please set num_resets to 32 in every single one of them, > > > otherwise > > > there will be display regressions. > > > = > > > Thanks, > > > N=EDcolas > > = > > It's my mistake. I will set num_resets to 32 for every mmsys driver. > > = > > Thanks, > > Nancy > = > After review the code, I think only the mmsys driver with the > sw0_rst_offset setting should set num_resets to 32, otherwise it would > set wrong addr in the mtk_mmsys_reset_update() function. Those mmsys > without sw0_rst_offset set should not set num_resets to 32. I don't think that's the case. num_resets and sw0_rst_offset are completely unrelated in the code. sw0_rst_offset just gives the offset from the base mmsys memory to the register that manages resets; it can be 0 in which case= the reset register would be right at the start of the mmsys iospace. nr_resets, which is set by num_resets, on the other hand, seems to be used = in a single place: of_reset_simple_xlate() in drivers/reset/core.c. And the logic there is really simple: if you pass a reset id greater than nr_resets, you = will get an error. So when you leave num_resets unset (0) for any of the platfor= ms, you're making all reset registrations in the DT fail. So I'm really confident that we need num_resets =3D 32 on *all* platforms (= except the ones that have 64 of course, we just can't leave them empty). Thanks, N=EDcolas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel