From: Davidlohr Bueso <dave@stgolabs.net>
To: Ira Weiny <ira.weiny@intel.com>
Cc: linux-arch@vger.kernel.org, dan.j.williams@intel.com,
peterz@infradead.org, mark.rutland@arm.com, dave.jiang@intel.com,
Jonathan.Cameron@huawei.com, a.manzanares@samsung.com,
bwidawsk@kernel.org, alison.schofield@intel.com,
linux-cxl@vger.kernel.org, nvdimm@lists.linux.dev,
x86@kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] arch/cacheflush: Introduce flush_all_caches()
Date: Sat, 20 Aug 2022 08:10:48 -0700 [thread overview]
Message-ID: <20220820151048.cfpkqhut5z6wa6yk@offworld> (raw)
In-Reply-To: <YwAo1Ec13hjiBOat@iweiny-desk3>
On Fri, 19 Aug 2022, Ira Weiny wrote:
>Did you mean "must"?
Yep.
>> + * such as those which caches are in a consistent state. The
>> + * caller can verify the situation early on.
>> + */
>> +#ifndef flush_all_caches
>> +# define flush_all_caches_capable() false
>> +static inline void flush_all_caches(void)
>> +{
>> + WARN_ON_ONCE("cache invalidation required\n");
>> +}
>
>With the addition of flush_all_caches_capable() will flush_all_caches() ever be
>called?
No, it should not. Hence you get a splat if you call it bogusly.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-08-20 15:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-19 17:10 [PATCH v2] arch/cacheflush: Introduce flush_all_caches() Davidlohr Bueso
2022-08-20 0:20 ` Ira Weiny
2022-08-20 15:10 ` Davidlohr Bueso [this message]
2022-08-22 6:38 ` Christoph Hellwig
2022-08-22 13:37 ` Davidlohr Bueso
2022-08-22 18:16 ` Dan Williams
2022-08-23 15:37 ` Davidlohr Bueso
2022-08-23 17:36 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220820151048.cfpkqhut5z6wa6yk@offworld \
--to=dave@stgolabs.net \
--cc=Jonathan.Cameron@huawei.com \
--cc=a.manzanares@samsung.com \
--cc=alison.schofield@intel.com \
--cc=bwidawsk@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=ira.weiny@intel.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nvdimm@lists.linux.dev \
--cc=peterz@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox