From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 001BAC28D13 for ; Mon, 22 Aug 2022 08:35:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=+Xk+CFIOw8MiEV5gkoDKEZr3NtiQ7NzCE7Hg6B2eLeE=; b=2nBpUVDfIWtaKv uPigu/imwRJqwtJUIGFNY2V0j2TTpicbiNpr5QtSsrxmwjf6yYWgIt4psiLrnw35m5T1hu8vt9/n5 kYrMnt92M17F7ayQBy8ExLslVZ3Ppry6jq5mtv5UqxUtT+57CYM33uWeaQ9hI3/u0/M5LuDyUr/fU Vu45gWMxOfO7psqvIkUsnoIrSwSVxue4ihyQ9gsyQxeG34umZXCt+kctzTok3tDp2Q5lpx906LOI4 HeT4i+3sHaBmerDxpXBsEfKCEq1z2bcCYu4iRxtyta8XuqdgeJl1nfDSPdbllCaNvSH75sWO0km/j PaAaH05DD5RtTDNbH2Tg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oQ2sZ-006Vrj-SP; Mon, 22 Aug 2022 08:33:52 +0000 Received: from smtpbgbr2.qq.com ([54.207.22.56]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oQ2em-006O3Y-F4; Mon, 22 Aug 2022 08:19:41 +0000 X-QQ-mid: bizesmtp79t1661156333tn1skwkr Received: from localhost.localdomain ( [123.114.60.34]) by bizesmtp.qq.com (ESMTP) with id ; Mon, 22 Aug 2022 16:18:52 +0800 (CST) X-QQ-SSF: 01400000002000D0U000B00A0000000 X-QQ-FEAT: abDNkBO9wxGSSTXraPu2eHWuksMIwlUpD0v3GkNTcQZh7Wdc/Fr0iBTHZKnOE NXeDfgC69XIwvzXui9ShjI/mipkDaSqfvKmfaGM4CISezq40clj1tmVOENDzf9j+1mlXo7f Qi/ngMCE4t/2piN6qAueBA/fNKLqN1B/wILObQCby95uuG+rs4KL0VBAL6z9urAJCRBP4LZ lmD/1RJEDyipWN/5IrJ42lY6+RGmitY1n3M9vd8qTYw5u4LefxeROAmT0GQhi/2qB5th4cp XrY4vTzaHSffTYBrJ0LY+1xHef+vQ6p53zD4Vxi71Z5AgnNJwbkVmwW7bvHg63TdaGPiHVd QlYaFEJUY78MbAzsygTxNn7+QscQfipg7EqoSO+3klEAD6fB+XR9Vi7CK1VTw== X-QQ-GoodBg: 2 From: zhaoxiao To: thierry.reding@gmail.com, heiko@sntech.de Cc: u.kleine-koenig@pengutronix.de, linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, zhaoxiao Subject: [PATH v5] pwm: rockchip: Convert to use dev_err_probe() Date: Mon, 22 Aug 2022 16:18:48 +0800 Message-Id: <20220822081848.5126-1-zhaoxiao@uniontech.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:uniontech.com:qybglogicsvr:qybglogicsvr1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220822_011937_431140_7EAF5177 X-CRM114-Status: GOOD ( 10.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org It's fine to call dev_err_probe() in ->probe() when error code is known. Convert the driver to use dev_err_probe(). Signed-off-by: zhaoxiao --- v5: delete the redundant ret and %d. drivers/pwm/pwm-rockchip.c | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/pwm/pwm-rockchip.c b/drivers/pwm/pwm-rockchip.c index f3647b317152..a5af859217c1 100644 --- a/drivers/pwm/pwm-rockchip.c +++ b/drivers/pwm/pwm-rockchip.c @@ -328,22 +328,16 @@ static int rockchip_pwm_probe(struct platform_device *pdev) else pc->pclk = pc->clk; - if (IS_ERR(pc->pclk)) { - ret = PTR_ERR(pc->pclk); - if (ret != -EPROBE_DEFER) - dev_err(&pdev->dev, "Can't get APB clk: %d\n", ret); - return ret; - } + if (IS_ERR(pc->pclk)) + return dev_err_probe(&pdev->dev, PTR_ERR(pc->pclk), "Can't get APB clk\n"); ret = clk_prepare_enable(pc->clk); - if (ret) { - dev_err(&pdev->dev, "Can't prepare enable PWM clk: %d\n", ret); - return ret; - } + if (ret) + return dev_err_probe(&pdev->dev, ret, "Can't prepare enable PWM clk\n"); ret = clk_prepare_enable(pc->pclk); if (ret) { - dev_err(&pdev->dev, "Can't prepare enable APB clk: %d\n", ret); + dev_err_probe(&pdev->dev, ret, "Can't prepare enable APB clk\n"); goto err_clk; } @@ -360,7 +354,7 @@ static int rockchip_pwm_probe(struct platform_device *pdev) ret = pwmchip_add(&pc->chip); if (ret < 0) { - dev_err(&pdev->dev, "pwmchip_add() failed: %d\n", ret); + dev_err_probe(&pdev->dev, ret, "pwmchip_add() failed\n"); goto err_pclk; } -- 2.20.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel