From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 83C4FC28D13 for ; Mon, 22 Aug 2022 11:31:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lsg3ltVgXivBOmYeTXHyQPpzypy47OB3ELc5eR+f/Vc=; b=1q4nIk3/lhFN4J sryn82DT5EDm5eIejNiLJ6J4bqVZ3P4odTzPYkbeO52mG+PPfjSQWLGZPYmTtKN8u8vYLpC8BSNTG g+Hr8pQVulVKkm1XBnZFqCYSl6nE460J8GiUeGlPE8NqHqJiEWPjj4cpHu1mCi19Otegl2XgeQ3MC +JX2ivPePIewZyRnuw6wOw9RL3ee5KgppHuALrKkhH/lAM1WsQXBH7T4bC0bLhju6EGl7Jx1Z4wuD 8zFGr1RE4fGKa3sZaq23ax+AMt8Nw56cMHpLyGIFH1qRv7KxZbTJeMGku+j4A49cs6EW3kszf/PKX EJ5a9yDsWOQwAkMcoFCw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oQ5dH-008Fd3-Iw; Mon, 22 Aug 2022 11:30:15 +0000 Received: from mail-ed1-x52c.google.com ([2a00:1450:4864:20::52c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oQ5d8-008FWW-8u for linux-arm-kernel@lists.infradead.org; Mon, 22 Aug 2022 11:30:07 +0000 Received: by mail-ed1-x52c.google.com with SMTP id s11so13408808edd.13 for ; Mon, 22 Aug 2022 04:30:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc; bh=Xlmus60sqK8GeXhd6q9NENg7b74le0wdQoVj4za8BkE=; b=W22n9DZSOQzBWhxvg9uaQDvwGdkLpDtbnuKeDZPqUgw1psI7Bh8DAmds/AcK6rHLnf UK85rgUvcGXYBYry65MhhQJUoQdLB/1cWhdtbv/KbbSYSTArEdTsFyNFjH2ccnovAEpk y9PAd9CuVI3aGPW5LKD+7J4HGaSopRqQxIN5g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=Xlmus60sqK8GeXhd6q9NENg7b74le0wdQoVj4za8BkE=; b=hEf0+XrpVrShXzJ8D85jFEVXK53MYaK7+ZDKH3RMHCeFEUc7XcaAA3YF3QngFrD8xn 85RdqY1OWusgciEhA7MLmyGV3vVxKOcOvYqArIjj6Syo9iahYmg4UNxi+CyPPX7vxvcX B5zC3hlk+l2tzqPG9+pKwXJ0iAKiZrJxP52wxIDpR+0iIgS/NXPkyn9BDfQvfciDxtFL Idn9v5oa/lp0pJreqpQXa8yMLCYTBPZMzjaW4s7NwQ1z0D29MKdBbk9uI5UqMa0EQ/6l UzCRlMMC60Lxpf1jGDAfLUup3jjnxLQ4nywvilQ48IDV7Wp8bgD2QhnGdE4e+2CdHBra KZZw== X-Gm-Message-State: ACgBeo2boeILoksDlG1m8Brl/2xdOWgCGLHR4g21vty8GN8ZFUN4Pljx wqwAxb1YssHoyHIPqvNoN5NZeg== X-Google-Smtp-Source: AA6agR4Dk6XIdvRO93LKvp6U+BMj/bECACWyCvfC/JBkAJHvokftn0ynCiHWPGR5yQE+8KJcyZyfaA== X-Received: by 2002:a05:6402:c45:b0:442:c549:8e6b with SMTP id cs5-20020a0564020c4500b00442c5498e6bmr15765394edb.123.1661167804008; Mon, 22 Aug 2022 04:30:04 -0700 (PDT) Received: from tom-ThinkPad-T14s-Gen-2i (net-188-217-57-252.cust.vodafonedsl.it. [188.217.57.252]) by smtp.gmail.com with ESMTPSA id kz13-20020a17090777cd00b0073d6234ceebsm3475065ejc.160.2022.08.22.04.30.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Aug 2022 04:30:03 -0700 (PDT) Date: Mon, 22 Aug 2022 13:30:01 +0200 From: Tommaso Merciai To: Ming Qian Cc: mchehab@kernel.org, hverkuil-cisco@xs4all.nl, shawnguo@kernel.org, robh+dt@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, xiahong.bao@nxp.com, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 3/4] media: amphion: decoder add support for contiguous planes Message-ID: <20220822113001.GB17530@tom-ThinkPad-T14s-Gen-2i> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220822_043006_351758_C170F5C2 X-CRM114-Status: GOOD ( 18.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Ming, On Tue, Aug 09, 2022 at 02:50:40PM +0800, Ming Qian wrote: > decoder add support for contiguous formats > V4L2_PIX_FMT_NV12_8L128 and V4L2_PIX_FMT_NV12_10BE_8L128 > > Signed-off-by: Ming Qian > --- > drivers/media/platform/amphion/vdec.c | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/drivers/media/platform/amphion/vdec.c b/drivers/media/platform/amphion/vdec.c > index 48ab664fa7ef..9c3324717cbc 100644 > --- a/drivers/media/platform/amphion/vdec.c > +++ b/drivers/media/platform/amphion/vdec.c > @@ -72,12 +72,28 @@ static const struct vpu_format vdec_formats[] = { > .mem_planes = 2, > .comp_planes = 2, > .type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE, > + .sibling = V4L2_PIX_FMT_NV12_8L128, > + }, > + { > + .pixfmt = V4L2_PIX_FMT_NV12_8L128, > + .mem_planes = 1, > + .comp_planes = 2, > + .type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE, > + .sibling = V4L2_PIX_FMT_NV12M_8L128, > }, > { > .pixfmt = V4L2_PIX_FMT_NV12M_10BE_8L128, > .mem_planes = 2, > .comp_planes = 2, > .type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE, > + .sibling = V4L2_PIX_FMT_NV12_10BE_8L128, > + }, > + { > + .pixfmt = V4L2_PIX_FMT_NV12_10BE_8L128, > + .mem_planes = 1, > + .comp_planes = 2, > + .type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE, > + .sibling = V4L2_PIX_FMT_NV12M_10BE_8L128 > }, > { > .pixfmt = V4L2_PIX_FMT_H264, > -- > 2.37.1 > Looks good to me. Unfortunately I don't have hw for testing more. I tried to build and reviewed the code seems ok for me. Reviewed-by: Tommaso Merciai Tommaso -- Tommaso Merciai Embedded Linux Engineer tommaso.merciai@amarulasolutions.com __________________________________ Amarula Solutions SRL Via Le Canevare 30, 31100 Treviso, Veneto, IT T. +39 042 243 5310 info@amarulasolutions.com www.amarulasolutions.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel