From: Tommaso Merciai <tommaso.merciai@amarulasolutions.com>
To: Ming Qian <ming.qian@nxp.com>
Cc: mchehab@kernel.org, hverkuil-cisco@xs4all.nl,
shawnguo@kernel.org, robh+dt@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
xiahong.bao@nxp.com, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 4/4] media: amphion: encoder add support for contiguous planes
Date: Mon, 22 Aug 2022 13:31:52 +0200 [thread overview]
Message-ID: <20220822113152.GC17530@tom-ThinkPad-T14s-Gen-2i> (raw)
In-Reply-To: <c375506c02e6664580a2eb1cac559ab8dfd02552.1660027440.git.ming.qian@nxp.com>
Hi Ming,
On Tue, Aug 09, 2022 at 02:50:41PM +0800, Ming Qian wrote:
> encoder add support for contiguous formats NV12
>
> Signed-off-by: Ming Qian <ming.qian@nxp.com>
> ---
> drivers/media/platform/amphion/venc.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/media/platform/amphion/venc.c b/drivers/media/platform/amphion/venc.c
> index 060a1ee78b17..3cbe8ce637e5 100644
> --- a/drivers/media/platform/amphion/venc.c
> +++ b/drivers/media/platform/amphion/venc.c
> @@ -72,6 +72,14 @@ static const struct vpu_format venc_formats[] = {
> .mem_planes = 2,
> .comp_planes = 2,
> .type = V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE,
> + .sibling = V4L2_PIX_FMT_NV12,
> + },
> + {
> + .pixfmt = V4L2_PIX_FMT_NV12,
> + .mem_planes = 1,
> + .comp_planes = 2,
> + .type = V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE,
> + .sibling = V4L2_PIX_FMT_NV12M,
> },
> {
> .pixfmt = V4L2_PIX_FMT_H264,
> --
> 2.37.1
>
Looks good.
Reviewed-by: Tommaso Merciai <tommaso.merciai@amarulasolutions.com>
--
Tommaso Merciai
Embedded Linux Engineer
tommaso.merciai@amarulasolutions.com
__________________________________
Amarula Solutions SRL
Via Le Canevare 30, 31100 Treviso, Veneto, IT
T. +39 042 243 5310
info@amarulasolutions.com
www.amarulasolutions.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2022-08-22 11:33 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-09 6:50 [PATCH v4 0/4] media: amphion: add support for contiguous format Ming Qian
2022-08-09 6:50 ` [PATCH v4 1/4] media: add nv12_8l128 and nv12_10be_8l128 video format Ming Qian
2022-08-11 15:18 ` Tommaso Merciai
2022-08-12 1:25 ` [EXT] " Ming Qian
2022-08-12 7:11 ` Tommaso Merciai
2022-08-16 14:42 ` Nicolas Dufresne
2022-08-09 6:50 ` [PATCH v4 2/4] media: amphion: tell and handle contiguous and non contiguous format Ming Qian
2022-08-12 7:14 ` Tommaso Merciai
2022-08-12 7:19 ` [EXT] " Ming Qian
2022-08-12 9:42 ` Tommaso Merciai
2022-08-12 9:49 ` Tommaso Merciai
2022-08-12 23:26 ` Ming Qian
2022-08-22 7:25 ` Tommaso Merciai
2022-08-22 11:16 ` Tommaso Merciai
2022-08-22 11:56 ` [EXT] " Ming Qian
2022-08-22 12:03 ` Tommaso Merciai
2022-08-09 6:50 ` [PATCH v4 3/4] media: amphion: decoder add support for contiguous planes Ming Qian
2022-08-22 11:30 ` Tommaso Merciai
2022-08-09 6:50 ` [PATCH v4 4/4] media: amphion: encoder " Ming Qian
2022-08-22 11:31 ` Tommaso Merciai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220822113152.GC17530@tom-ThinkPad-T14s-Gen-2i \
--to=tommaso.merciai@amarulasolutions.com \
--cc=festevam@gmail.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=ming.qian@nxp.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=xiahong.bao@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox