From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F205CC32774 for ; Tue, 23 Aug 2022 08:34:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tR1l4BbmOczFzBqyrh1l5RYjgTz9PuS2yBVN667Pq9U=; b=1tNlQQeNcDtOG6 zH3md6VwY/hwKP97ISQ+jOgynxMoTJ40gZveb27N4PSFJBEY2sLeS5w6BZvS4SrFXUHtlpkGYZvxl WD8PlTU9QM+QPHppzjc96g2V1g+ybibiNdbMwsdtSXaWSHxhCNoQP34OHB6TYS6NNR0WdFkPb9oVD ysjcO9aDod+rWaSWLMxFToJc0nWPQ400h7agUP7QKO7QDjoIPEgHB/RAkyE5YF7Ak97JW+h0j8Cdt E1S7t2137nXePa2zgDeZNH0wAKDJQ4pVGa6R53FQ29g+JTcFM3rI2u8eCqkf/w1n3R7hFUNypD2qo rYHhEJoaZF8xM5xGG/EA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oQPLJ-00420Q-8Q; Tue, 23 Aug 2022 08:33:03 +0000 Received: from mail-lj1-x22e.google.com ([2a00:1450:4864:20::22e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oQPL8-0041tf-3F for linux-arm-kernel@lists.infradead.org; Tue, 23 Aug 2022 08:32:54 +0000 Received: by mail-lj1-x22e.google.com with SMTP id w23so7692236ljj.7 for ; Tue, 23 Aug 2022 01:32:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc; bh=ZoiEZ2owYFRd9VZ4KOglg27OSgrpz66JCF4aBuAtJKk=; b=XOq1D3p40qntGScT26U+WRfQkKGoZxGas4gsBYkW/tlkirRYU1vMzrPsYNj7ApNwFg yKcin3ahiyq3dt2/3VQVxsTKwFrRiK2Mq8FAQ45mWJZ7Jx9ZiOX1Wzv6TIhCBWC7dD0c Acw/ckgnEivCfCEe8UU8ztCo5rzvuYzqRWvkLJb9dSHrc6+zg1mpuOo2DTl0e2tfJuzw hoAtsafvBXIStxBM6F3Oir2LCvFUgHpBndT1DyWnc3nOGU5t7DzIaoss1Mvh0WLv4rDW e3GwJfDPGN29b7m0OF0tm3kxv+gC08kZbAK4advmaoUk7b16JRuEMasHAp16vbfFZjvB m8HQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=ZoiEZ2owYFRd9VZ4KOglg27OSgrpz66JCF4aBuAtJKk=; b=YKtdPfcNnCWrwDZFYOjbJ1jawnXOEq8NuLoJMNI3pL39ZGFaekB1/BLZlmyGQC6oF2 JjwS6vTmSyR3yIbPal3Xw0Gf0jUKDCcEcj+CPRj4zluwg61tbZuSfb83jTVIxayjUhbt KdDD/75ptiaRhY2wwUaq22QyRtrxhRHyczk5+a8O/xb6JwSZga6S+HdphDIwK7xVt1iu yGyjFDy+hzqej9C/vOL6W+41vNXENkQ/Uzp0Nkhrpqdi1okZTf3HvN8dY/ig4TcMpka3 Xp+LBFMXIsHr02egmFXuA6Z7p0Jmc/e0IY/Et/9A0wlTSd9jhaTdcZBhhYbDeyfL7rIZ KGCQ== X-Gm-Message-State: ACgBeo349bANMx8w4spb66mSj1GssInnPrcedk7m+xIrbTr4mCxewt91 njYLbtd9no9LRRSmGjSdQ0Q= X-Google-Smtp-Source: AA6agR5wYA3CsYSm/1lKwrkaVPJFswM19gUmuH7KYsJP6ehf6Jt3Cy2E6d4WejY2LgMSRG4PvC8y/A== X-Received: by 2002:a05:651c:158c:b0:250:a23d:2701 with SMTP id h12-20020a05651c158c00b00250a23d2701mr7259412ljq.475.1661243566343; Tue, 23 Aug 2022 01:32:46 -0700 (PDT) Received: from mobilestation ([95.79.140.178]) by smtp.gmail.com with ESMTPSA id z20-20020a05651c11d400b0025dfd2f66d6sm1448143ljo.95.2022.08.23.01.32.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Aug 2022 01:32:45 -0700 (PDT) Date: Tue, 23 Aug 2022 11:32:43 +0300 From: Serge Semin To: Krzysztof Kozlowski Cc: Serge Semin , Rob Herring , Michal Simek , Borislav Petkov , Mauro Carvalho Chehab , Tony Luck , Rob Herring , Manish Narani , Alexey Malahov , Michail Ivanov , Pavel Parkhomenko , Punnaiah Choudary Kalluri , Dinh Nguyen , James Morse , Robert Richter , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 16/20] dt-bindings: memory: snps: Detach Zynq DDRC controller support Message-ID: <20220823083243.aovlgu22j7uv73qv@mobilestation> References: <20220822190730.27277-1-Sergey.Semin@baikalelectronics.ru> <20220822190730.27277-17-Sergey.Semin@baikalelectronics.ru> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220823_013250_527021_92E47B1F X-CRM114-Status: GOOD ( 25.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Aug 23, 2022 at 11:17:23AM +0300, Krzysztof Kozlowski wrote: > On 22/08/2022 22:07, Serge Semin wrote: > > The Zynq A05 DDRC controller has nothing in common with DW uMCTL2 DDRC: > > the CSRs layout is absolutely different and it doesn't has IRQ unlike DW > > uMCTL2 DDR controller of all versions (v1.x, v2.x and v3.x). Thus there is > > no any reason to have these controllers described by the same bindings. > > Thus let's split them up. > > > > While at it rename the original Synopsys uMCTL2 DT-schema file to a more > > descriptive - snps,dw-umctl2-ddrc.yaml and add a more detailed title and > > description of the device bindings. > > Filename should be based on compatible, so if renaming then > snps,ddrc-3.80a.yaml or snps,ddrc.yaml... which leads to original > filename anyway. Therefore nack for rename. New requirement? I've submitted not a single patch to the DT-bindings sources and didn't get any comment from Rob about that. In addition There are DT bindings with names different from what is defined in the compatible name. Moreover there are tons of bindings with various compatible names. What name to choose then? Finally the current name is too generic to use for actual DW uMCTL2 DDRC controller. -Sergey > > BTW, if you perform renames, generate patches with proper -M/-C/-B > arguments so this is detected. > > > > > > Signed-off-by: Serge Semin > > ---> .../snps,dw-umctl2-ddrc.yaml | 51 +++++++++++++ > > This is a mess. I did not get any cover letters, any other patches any > description of relation between this and your other one. > > It seems you make independent and conflicting changes to the same file, > so this has to be properly organized. > > Send entire patchset with cover letter with description of all > dependencies to all maintainers. > > This is unreviewable now, so a no. > > Best regards, > Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel