From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2F149C32772 for ; Tue, 23 Aug 2022 20:07:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=K8K9SBi37vFWoq9hjmPdJhcpvTKsFf9l9CsHDMgP5iE=; b=GnIZGJ8J9R+Um1 io74Dn44kcugZLB6MNDjJzbHGTcaYG38FuBLslOAXjbU+FQYV7gOdg0drWYdsWTwqPlSMKGHrHeze edyzlr2mcBzzljNsZpOydtzEjLxDlJTUfKsMdP6YzieEutdn9umtxeNug5E3KEid9PjqCYJzpmFPH geyvP98tn6p1NeG8XVK+RmLAtxoaafWnjWIOg4JNVXyK75Dfn6DWdNqIXFz5VUBpGainYue5oYJG5 +ZE73XGq1LoMEgqrb0mScGHraLrjnCRR6bZ/OlpN6w6Tb6QSiMNqcMw2bj/7EDFhykwoq6Jmbi0dY eo/gFs2dsvobFSF/NEzQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oQaAl-008eYC-Ja; Tue, 23 Aug 2022 20:06:51 +0000 Received: from mail-pj1-x1029.google.com ([2607:f8b0:4864:20::1029]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oQaAi-008eXV-Su for linux-arm-kernel@lists.infradead.org; Tue, 23 Aug 2022 20:06:50 +0000 Received: by mail-pj1-x1029.google.com with SMTP id f21so14978386pjt.2 for ; Tue, 23 Aug 2022 13:06:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc; bh=CbkIBCLoHbH9nNnU/J2Hb+7ZqJOjL/seN2XSe7TVevU=; b=LyQZ8mpGnO62wtqueQ9ShrFp+nlxifSg/kxiyCwFOBEtJNosbOZLvblQHuIE6N2hjt V/oQePAHGmvEulJfpi7dcrOIYh/b9yyhDrE2XuKRqv8E0nfyTkN1+ziMmIjvW9Y/K2Dm gpTm9CNd1Wa+6RHT/+oUNI98z9jaJkAAVSirYcJZ3o3eK8zT4E3clJxiu5DdGcfxgW+Y lM3TMLUTtYTY1/CQPIfgl4ghw4+cy8bi6wQ79Zf9HfOm/onkXJ3UYQ4B8AerTI/HwaMu qAmBr35p0DqTJ+wFeG8lzBa+vgTnVmmOBu0a5bFySbiwtvL/ObBHWeWo0dUXpa5Nz96r gPng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=CbkIBCLoHbH9nNnU/J2Hb+7ZqJOjL/seN2XSe7TVevU=; b=VBrwFZsZJsB5orwivV7pbIeBUGrV0kohUyvgaYmbYRsQGZdjbHpdg4iDNgrY5WlJq5 6pxG/35hztU6ZhRN3H1wxNJmdQAo4mBI9z6HUL1UwGk4cZETORtgqL/LdtLCIw4UUwTy Bj7fQk+rFFem4mVzWIeOq6DyF6KxyLm6uHTPPc9HSX0fIaX1WeWR3YuBoJoTm8oyCvO4 IPCF1KvvTozyA6W/3uFq4BprbmA3vCX05EXJIcwBlQwuxMRPqMfv4MvyP30FBAB7p/1V pt9SMgVEwVC8+1iWtYrkI12KmyvhNd1A8thr6ChZ9d2Q9d80AkJHMk6DuxQL/R9Q4Dxa zPOA== X-Gm-Message-State: ACgBeo026Q7Uwrl41aOqxOfkJNpPHtXmwaZFupflmt9LCuK8P1FeIPEe 1DPe6p3b/Tqt6M7QMkC+mBlLWg== X-Google-Smtp-Source: AA6agR5p/BTbRDFoEOMWG8yU+S+cOrL/qtvtS7f5dviOX2iNU2ka8UU1HiT4GwoLDdpIYoSb0zf/pw== X-Received: by 2002:a17:902:cec7:b0:172:5b09:161c with SMTP id d7-20020a170902cec700b001725b09161cmr25181780plg.60.1661285207566; Tue, 23 Aug 2022 13:06:47 -0700 (PDT) Received: from p14s (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id t127-20020a625f85000000b005362baf16e4sm8574434pfb.141.2022.08.23.13.06.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Aug 2022 13:06:46 -0700 (PDT) Date: Tue, 23 Aug 2022 14:06:44 -0600 From: Mathieu Poirier To: Shengjiu Wang Cc: bjorn.andersson@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-remoteproc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] remoteproc: imx_dsp_rproc: fix argument 2 of rproc_mem_entry_init Message-ID: <20220823200644.GC1781852@p14s> References: <1660567398-24495-1-git-send-email-shengjiu.wang@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1660567398-24495-1-git-send-email-shengjiu.wang@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220823_130648_954852_F45F3B1C X-CRM114-Status: GOOD ( 18.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Aug 15, 2022 at 08:43:18PM +0800, Shengjiu Wang wrote: > There are sparse warning: > drivers/remoteproc/imx_dsp_rproc.c:602:49: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected void *va @@ got void [noderef] __iomem *[assigned] cpu_addr @@ > drivers/remoteproc/imx_dsp_rproc.c:602:49: sparse: expected void *va > drivers/remoteproc/imx_dsp_rproc.c:602:49: sparse: got void [noderef] __iomem *[assigned] cpu_addr > drivers/remoteproc/imx_dsp_rproc.c:638:49: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected void *va @@ got void [noderef] __iomem *[assigned] cpu_addr @@ > drivers/remoteproc/imx_dsp_rproc.c:638:49: sparse: expected void *va > drivers/remoteproc/imx_dsp_rproc.c:638:49: sparse: got void [noderef] __iomem *[assigned] cpu_addr > > Fixes: ec0e5549f358 ("remoteproc: imx_dsp_rproc: Add remoteproc driver for DSP on i.MX") > Reported-by: kernel test robot > Signed-off-by: Shengjiu Wang > --- > drivers/remoteproc/imx_dsp_rproc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/remoteproc/imx_dsp_rproc.c b/drivers/remoteproc/imx_dsp_rproc.c > index ca0817f8e41e..899aa8dd12f0 100644 > --- a/drivers/remoteproc/imx_dsp_rproc.c > +++ b/drivers/remoteproc/imx_dsp_rproc.c > @@ -599,7 +599,7 @@ static int imx_dsp_rproc_add_carveout(struct imx_dsp_rproc *priv) > } > > /* Register memory region */ > - mem = rproc_mem_entry_init(dev, cpu_addr, (dma_addr_t)att->sa, > + mem = rproc_mem_entry_init(dev, (void __force *)cpu_addr, (dma_addr_t)att->sa, > att->size, da, NULL, NULL, "dsp_mem"); > > if (mem) > @@ -635,7 +635,7 @@ static int imx_dsp_rproc_add_carveout(struct imx_dsp_rproc *priv) > } > > /* Register memory region */ > - mem = rproc_mem_entry_init(dev, cpu_addr, (dma_addr_t)rmem->base, > + mem = rproc_mem_entry_init(dev, (void __force *)cpu_addr, (dma_addr_t)rmem->base, > rmem->size, da, NULL, NULL, it.node->name); Applied. Thanks, Mathieu > > if (mem) > -- > 2.34.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel