Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Maxime Ripard <maxime@cerno.tech>
To: Charles Mirabile <cmirabil@redhat.com>
Cc: "Stefan Wahren" <stefan.wahren@i2se.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	"Peter Robinson" <pbrobinson@gmail.com>,
	"Serge Schneider" <serge@raspberrypi.org>,
	"Nicolas Saenz Julienne" <nicolassaenzj@gmail.com>,
	"Mattias Brugger" <mbrugger@suse.com>,
	linux-rpi-kernel@lists.infradead.org,
	"Linux ARM" <linux-arm-kernel@lists.infradead.org>,
	rh-kdlp@googlegroups.com, "Joel Slebodnick" <jslebodn@redhat.com>,
	"Joel Savitz" <jsavitz@redhat.com>,
	"Noralf Trønnes" <noralf@tronnes.org>
Subject: Re: [PATCH v10 0/6] Raspberry Pi Sense HAT driver
Date: Wed, 24 Aug 2022 17:30:51 +0200	[thread overview]
Message-ID: <20220824153051.bx6kfcih76kh3exc@houat> (raw)
In-Reply-To: <CABe3_aFJ0gkLDFB9k5FEn1SmupbLEKxAn8y=WTt-Rc0xUEK4Dw@mail.gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 1226 bytes --]

On Wed, Aug 24, 2022 at 08:06:59AM -0400, Charles Mirabile wrote:
> On Tue, Aug 23, 2022 at 5:30 PM Stefan Wahren <stefan.wahren@i2se.com> wrote:
> > >    drivers/auxdisplay: sensehat: Raspberry Pi Sense HAT display driver
> > We don't have an Ack for this display driver. Maybe we should ask Maxime
> > Ripard and Noralf Trønnes especially Pavel Machek had concerns about the
> > right subsystem?
>
> I just looked back at the comments from Pavel on v9. I had meant to
> reply to him, and I actually drafted something but it got lost in the
> shuffle and I never sent it (also my bad).
>
> The driver is an fbdev in the raspberry pi tree, and that is where we
> started when upstreaming, but right from the outset we were told that
> it couldn't be an fbdev since that subsystem is being deprecated
> the replacement is the DRM subsystem

Indeed

> but (as Matthias Brugger suggests) that is probably overkill for an
> 8x8 display. Does that settle the subsystem question?

If you were aiming for an fbdev driver, a KMS driver these days would be
notably simpler.

We've added simpler and simpler devices, such as the SSD1306 recently,
so I can't see anything wrong with using KMS either.

Maxime

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-08-24 15:32 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-23 17:41 [PATCH v10 0/6] Raspberry Pi Sense HAT driver Charles Mirabile
2022-08-23 17:41 ` [PATCH 1/5] drivers/mfd: sensehat: Add Raspberry Pi Sense HAT to simple_mfd_i2c Charles Mirabile
2022-09-05 13:58   ` Lee Jones
2022-09-06  2:28   ` Bagas Sanjaya
2022-08-23 17:41 ` [PATCH 2/5] drivers/auxdisplay: sensehat: Raspberry Pi Sense HAT display driver Charles Mirabile
2022-08-24 11:26   ` Matthias Brugger
2022-09-06  2:31   ` Bagas Sanjaya
2022-09-08 15:26   ` Wander Lairson Costa
2022-08-23 17:41 ` [PATCH 3/5] dt-bindings: mfd: sensehat: Add Raspberry Pi Sense HAT schema Charles Mirabile
2022-08-24 12:13   ` Matthias Brugger
2022-09-06  2:47   ` Bagas Sanjaya
2022-08-23 17:41 ` [PATCH 4/5] MAINTAINERS: Add sensehat driver authors to MAINTAINERS Charles Mirabile
2022-09-06  2:48   ` Bagas Sanjaya
2022-08-23 17:41 ` [PATCH 5/5] DO NOT MERGE: full sensehat device tree overlay for raspberry pi 4 Charles Mirabile
2022-09-06  2:52   ` Bagas Sanjaya
2022-09-06 10:52     ` Matthias Brugger
2022-08-23 21:30 ` [PATCH v10 0/6] Raspberry Pi Sense HAT driver Stefan Wahren
2022-08-24 12:06   ` Charles Mirabile
2022-08-24 15:30     ` Maxime Ripard [this message]
2022-08-24 18:21     ` Stefan Wahren
2022-08-24 11:28 ` Matthias Brugger
2022-08-24 12:17   ` Charles Mirabile
2022-09-06  2:21 ` Bagas Sanjaya
2022-09-06 10:53   ` Matthias Brugger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220824153051.bx6kfcih76kh3exc@houat \
    --to=maxime@cerno.tech \
    --cc=cmirabil@redhat.com \
    --cc=jsavitz@redhat.com \
    --cc=jslebodn@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=mbrugger@suse.com \
    --cc=nicolassaenzj@gmail.com \
    --cc=noralf@tronnes.org \
    --cc=pbrobinson@gmail.com \
    --cc=rh-kdlp@googlegroups.com \
    --cc=serge@raspberrypi.org \
    --cc=stefan.wahren@i2se.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox