From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BFC98C04AA5 for ; Thu, 25 Aug 2022 13:24:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UCuPwVGBSw9mXro/H1xaipwbLEVBXIL8i+Mw5ZHDTIs=; b=blBqht18h4AroS 0r5xDheIF2bG/L1iIqkxubm/ACPlFjqVuxbf+5gvMRKhj6eUyzSSgPpzyBBLdAd33warKFHpMPBqw CT3QlHvAFiw15sHRH6tSQrpnPwit4FUgJ10qWaItUf8cZ/J7IN7ZheffcVHAYHgPGd3iJWjoEuo6Y uWLzQQkP8hz89fBoLFRadY6s2dqUcypcR1428uHwhDfY+zPZi75vsmZFuqeez2KaX9vB9WSdlfc9n V5LtK0FFy5W2gNc1DfhSpdob1uhfOBLl8bEA++/uMvH1vDMMRlRxoExUkUQUobFc2sjezPMoLi4Ww yj771VATujziPWxfCWIA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oRCpl-00ElVF-OI; Thu, 25 Aug 2022 13:23:46 +0000 Received: from mail-lf1-x12d.google.com ([2a00:1450:4864:20::12d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oRCpi-00ElS3-2K for linux-arm-kernel@lists.infradead.org; Thu, 25 Aug 2022 13:23:43 +0000 Received: by mail-lf1-x12d.google.com with SMTP id m5so17558199lfj.4 for ; Thu, 25 Aug 2022 06:23:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc; bh=6LhGjtWIW9co1/2gs66rsVEFtLVzBG4QOkw2+wFNu3c=; b=pPPpzZ45RGXaqlXi8hum48NG1uQB4nXdUDPMYgvTTQtsRrOHiVqto00m6MXd9s4O9j wPglL+1RN0amf4snG38/0fA85YH9oBBVoIq5MoCERAdMboZbVErLUerT+PsG7HecAwR9 bV3IkmP5bZVH3hwAe0y5ujSup4dil+Y+YzlnBJWbclaHpuD5YxrRDCHfBU1HpmxypqLU Krb2A5KbjVfSAwY/oGJZuLLdzgGG/8ujaktIzgaPmwNVi8Ym+B8nNlWFkobYIVEnCBIc LOkrlfIrHoCMaLxe0Dxn69ATpClotpkRmrscKObF3yQWAx0Fd+xLNFaRtW35Ad1O0t40 z3oQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=6LhGjtWIW9co1/2gs66rsVEFtLVzBG4QOkw2+wFNu3c=; b=ivv/gwGrLSIsY7bAyfbVdI3/yIz8mdETftwfxFuSzLDNHzyxEd+nCZ0Ei/I1hmdYl9 tYed+FoMMkncgTIVwuh4ueqjXq6oKKh3FS3fUjuGcdbnfsdtIiSWz46UXYNofAyEsBnK WMqonRCEFmW+EmD3xDOVYABXuP+KjO44WldizbN+O3n47PuUXqOTs3QOtaCNoW5Df/3H zOqw73pmQ7smejhRs/MGONmznzpZ8GbLcF62ikUBCO9MWHjiqJ2sAA0qvbcPnBxnkAde fNG8moDWvmblKeeS8NiKj3i23tRprHENMmNTT1l77ellwQd8ORhq0fM8+ZCwylQtFgr6 rWPg== X-Gm-Message-State: ACgBeo0ofJLvFlvYb8haKPKslrP1EytjdDrG6GvCsberzRFRpCf5kjYD jxbITZ6U5WcVV6kvSqgeWCY= X-Google-Smtp-Source: AA6agR49lHBZ9hF6YLntUa9KLE3iJhihwzflelrNicDUZ7cENiTbU1B0ArinDwRISS9DiDl3F+++Eg== X-Received: by 2002:ac2:4c4a:0:b0:492:c912:c166 with SMTP id o10-20020ac24c4a000000b00492c912c166mr1117140lfk.543.1661433818330; Thu, 25 Aug 2022 06:23:38 -0700 (PDT) Received: from mobilestation ([95.79.140.178]) by smtp.gmail.com with ESMTPSA id p8-20020a056512312800b00492e69be4d6sm505324lfd.27.2022.08.25.06.23.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Aug 2022 06:23:37 -0700 (PDT) Date: Thu, 25 Aug 2022 16:23:35 +0300 From: Serge Semin To: Krzysztof Kozlowski Cc: Serge Semin , Rob Herring , Michal Simek , Borislav Petkov , Mauro Carvalho Chehab , Tony Luck , Rob Herring , Manish Narani , Alexey Malahov , Michail Ivanov , Pavel Parkhomenko , Punnaiah Choudary Kalluri , Dinh Nguyen , James Morse , Robert Richter , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 16/20] dt-bindings: memory: snps: Detach Zynq DDRC controller support Message-ID: <20220825132335.f7mxjyomz6a5zybf@mobilestation> References: <20220822190730.27277-1-Sergey.Semin@baikalelectronics.ru> <20220822190730.27277-17-Sergey.Semin@baikalelectronics.ru> <20220823083243.aovlgu22j7uv73qv@mobilestation> <166c0198-17c4-3b19-77fe-632d65f17cb0@linaro.org> <20220823114516.4mcufkbmzy5gjdcr@mobilestation> <6661dcc1-cc93-efbb-b248-0d93f681a1bf@linaro.org> <20220824172724.ny2xpryn76h6ftv6@mobilestation> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220825_062342_134008_D8860FCF X-CRM114-Status: GOOD ( 34.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Aug 25, 2022 at 09:06:42AM +0300, Krzysztof Kozlowski wrote: > On 24/08/2022 20:27, Serge Semin wrote: > > > > > Note what Rob said concerned the generic compatible "fallback" case, > > not the generic compatible string in general. It's ok to have a > > generic device name defined irrespective to the platform vendor. > > Moreover it's applicable in case of the DW uMCTL2 DDRC IP-core since > > first IP-core version is auto-detectable starting from v3.20a and > > second I managed to implement auto-detection solutions for almost > > all the DDR/ECC-specific parameters. So I am more inclined to the > > solution 1) suggested by me in the previous email message: > > - deprecate "snps,ddrc-3.80a" string. > > - add new generic "snps,dw-umctl2-ddrc" compatible string. > > - rename the DT-bindings file. > > Sounds ok. Agreed then. > > > > >> > >> Here the Linux driver also binds to generic synopsys compatible, so I > >> would assume it has a meaning and use case on its own. > > > > Please see my messages above regarding the current Synopsys DW uMCTL2 > > EDAC driver implementation. > > > >> > >>> > >>> What do you think? > >>> > >>> * Note I've got it you'd prefer the renaming being performed in a > >>> separate patch. > >> > >> The rename could be in the split patch as here, but then I assume the > >> rename part to be detected by git and be a pure rename. However: > >> 1. The git did not mark it as rename (you might need to use custom > >> arguments to -M/-B/-C), > > > > Of course git hasn't detected it as rename, because aside with renaming > > I've split the bindings up. Splitting these two updates up into two > > patches will give us what you said. So to speak I suggest the next > > updates for v2: > > PATCH X. Detach the Zynq A05 DDRC DT-bindings to a separate schema. > > PATCH X + 1. Rename the Synopsys DW uMCTL2 DDRC bindings file and add a more > > descriptive generic compatible string name. > > > > What do you think? > > Regardless of the split the rename can be and should be detected by Git. > That's why we have these options. If it is not detected, you changed too > much during rename, so it is not a rename anymore. Relatively small > amount of changes would still be detected. Right. I'll make sure the renaming is detected. -Sergey > > > > >> 2. There were also changes in the process (allOf:if:then). > > > > Right. But this is in another patchset. I'll address your notes in there. > > > Best regards, > Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel