From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D4DC1ECAAD2 for ; Mon, 29 Aug 2022 14:08:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OePMBWTyY3jCNDYvHqyyhaEts+kJ9XUh8GbFct+saJE=; b=KH6esUmeFZaVm3 2g4gq/gxYvFQuL0YPwqpstJBH9cmV4evPJazQzXht1m3iJ3yNKyKQ940oq7ag/TRS/3J1Khdx4y3a ZNKG7Qnj/oeelhgbH4AlWRcEBBfwB+qKBYg55/9KK7GvLXU0eylH96bY4albInrRSHWv6w6xaSkjX 4QHn+SVNe7pE/WgPtPiQH5Xm1v0lnkR1o48GWEmFzKuvdRJrOOCq9k8WHU/+0+2l+iGfxER5lDcYt M8heJP2b7qbcxaaT7gEbwwCMns5SHgquI4uoN2EJfeFzE0KBqjGnfJWrXDRBDb7IxOlWGgx4LfCoa D9GywSjfH814S8pFq5yA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oSfPq-00AxUU-LI; Mon, 29 Aug 2022 14:07:04 +0000 Received: from mail-pf1-x431.google.com ([2607:f8b0:4864:20::431]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oSfCx-00Ar7U-Cp for linux-arm-kernel@lists.infradead.org; Mon, 29 Aug 2022 13:53:45 +0000 Received: by mail-pf1-x431.google.com with SMTP id 142so8238884pfu.10 for ; Mon, 29 Aug 2022 06:53:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc; bh=ENR6zXlzprDZixSeKqPFK+t4TDIeg7JZE6a8SVGK308=; b=AWq+ofH1oIUg8rs4W95LjB2cXM5FY8EUmeMiY0qYklZnsdd07ZYpo8K8WstNc4XzYR 9+HdvZbOnuGit7LFpT++pBAMTAj8geXLb50DDLDrI/ajmVZaveD13FT0dKcFb1ZTLdoI mzvfPWrSNePUTV9AcCFs7iODJeTZol49M7xI7BuwTd3QtL7Ui5zyAfwkTl7L4i5l08qF kKGCk1E14eAe2Xqd5zn+nGxU4e9Lec+XvSA4sSqyTvcCIi4y+5wXmpeF2FAfusE01NWL WYwASqFjUaUQU+vjZVdIAYFpEk7yroAtGWPEotsnuR0Yu+8L4zIX7kXaJmlFQ2ZJVB9j e4Gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc; bh=ENR6zXlzprDZixSeKqPFK+t4TDIeg7JZE6a8SVGK308=; b=L/iyleYjnGC5hhTZF8hws3my7hkD9Pcs0W2S00Yyw5TRtzgACfDrzXeEiL0N94Int1 +FSt1wKH/FALwXJB6WlYW/BYaI9F2VubkcExQgWktw9orS1PkjqpodHyzu4dM4qCdO3W ///d3VWigyzfrb0UQpBWWm1c3nIk0DL+3qmo1y6KWLYfxBa1GZvneXYNUHWbeOFVpCPU 3v5ZGJj+CruZ9IVxC/neAczEvezbkRKfqGO5KLdUdpjhvd5BSr4I5sAR84qmRK85d/un 5NIZK69BiaJowKRWEAtfw7a6wZgXwTjfEgd9VUbjIH0Zmvr4Xg630Hm9pECsiWtovxue Js8w== X-Gm-Message-State: ACgBeo07bvWSkXgd5dv1eAyPyIiXIsXr/DqfvEYOOqDK+UsCula/qu4i EGnPDKKF3pfEdw41Wz3ksJQ= X-Google-Smtp-Source: AA6agR75x82sSQ1XzmeJ6rgPwMc/ySBDjGhGNtf9HiwPGJGdolFJkT7h2+H3BNLmp+SYhltmGNeC0Q== X-Received: by 2002:a63:4547:0:b0:41d:ba0a:870a with SMTP id u7-20020a634547000000b0041dba0a870amr14272003pgk.216.1661781219647; Mon, 29 Aug 2022 06:53:39 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id k13-20020a170902c40d00b001743ba85d39sm7612123plk.110.2022.08.29.06.53.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Aug 2022 06:53:39 -0700 (PDT) Date: Mon, 29 Aug 2022 06:53:38 -0700 From: Guenter Roeck To: Christophe JAILLET Cc: Jean Delvare , Lars Povlsen , Steen Hegelund , UNGLinuxDriver@microchip.com, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] hwmon: (sparx5) Use devm_clk_get_enabled() helper Message-ID: <20220829135338.GA229655@roeck-us.net> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220829_065343_592086_2D5510EF X-CRM114-Status: GOOD ( 22.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Aug 24, 2022 at 12:25:13PM +0200, Christophe JAILLET wrote: > The devm_clk_get_enabled() helper: > - calls devm_clk_get() > - calls clk_prepare_enable() and registers what is needed in order to > call clk_disable_unprepare() when needed, as a managed resource. > > This simplifies the code, the error handling paths and avoid the need of > a dedicated function used with devm_add_action_or_reset(). > > Based on my test with allyesconfig, this reduces the .o size from: > text data bss dec hex filename > 2419 1472 0 3891 f33 drivers/hwmon/sparx5-temp.o > down to: > 2155 1472 0 3627 e2b drivers/hwmon/sparx5-temp.o > > Signed-off-by: Christophe JAILLET Applied to hwmon-next. Thanks, Guenter > --- > devm_clk_get_enabled() is new and is part of 6.0-rc1 > --- > drivers/hwmon/sparx5-temp.c | 19 +------------------ > 1 file changed, 1 insertion(+), 18 deletions(-) > > diff --git a/drivers/hwmon/sparx5-temp.c b/drivers/hwmon/sparx5-temp.c > index 98be48e3a22a..04fd8505e5d6 100644 > --- a/drivers/hwmon/sparx5-temp.c > +++ b/drivers/hwmon/sparx5-temp.c > @@ -26,13 +26,6 @@ struct s5_hwmon { > struct clk *clk; > }; > > -static void s5_temp_clk_disable(void *data) > -{ > - struct clk *clk = data; > - > - clk_disable_unprepare(clk); > -} > - > static void s5_temp_enable(struct s5_hwmon *hwmon) > { > u32 val = readl(hwmon->base + TEMP_CFG); > @@ -113,7 +106,6 @@ static int s5_temp_probe(struct platform_device *pdev) > { > struct device *hwmon_dev; > struct s5_hwmon *hwmon; > - int ret; > > hwmon = devm_kzalloc(&pdev->dev, sizeof(*hwmon), GFP_KERNEL); > if (!hwmon) > @@ -123,19 +115,10 @@ static int s5_temp_probe(struct platform_device *pdev) > if (IS_ERR(hwmon->base)) > return PTR_ERR(hwmon->base); > > - hwmon->clk = devm_clk_get(&pdev->dev, NULL); > + hwmon->clk = devm_clk_get_enabled(&pdev->dev, NULL); > if (IS_ERR(hwmon->clk)) > return PTR_ERR(hwmon->clk); > > - ret = clk_prepare_enable(hwmon->clk); > - if (ret) > - return ret; > - > - ret = devm_add_action_or_reset(&pdev->dev, s5_temp_clk_disable, > - hwmon->clk); > - if (ret) > - return ret; > - > s5_temp_enable(hwmon); > > hwmon_dev = devm_hwmon_device_register_with_info(&pdev->dev, _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel