From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 43AFDECAAD2 for ; Mon, 29 Aug 2022 14:04:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yfS1t0Nd14Kp1VZXJTC10/VDCoEp6Zuie8T09fy1OGc=; b=WLnpuC8ZtOkgA+ E7dbQQBxYUXkE3j0s6LxtLRl6xKpH/xRx695nKVIERfcIaBRgc4bUiLmIm7pTmQwi50mrfDSAgYtZ 66D3f998lbMqvugG47EnXFYw/p6XnmCWKfKGzcHhRh3QWfZsRRqn+t7AQji2HLPnh8HX1Ip4dkOxq r6irzy7ONOrnEZhxZmQz/osHHBryZ6DidxWDfXaDYZoaP+kPjXXwDA5lU14j5UErBj3jkOsMdkRqA Cdcyiq7fjXfFNHLNIvQ3Q3FbdxcTu6/bQFiFzk5tKDuV9SYX5K8Sv7eOdko2KNSDuFpbB5bhaxy7g YM5rKCYxrnK7CEBxTd/Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oSfMG-00Avfp-Jy; Mon, 29 Aug 2022 14:03:21 +0000 Received: from relay3-d.mail.gandi.net ([217.70.183.195]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oSf81-00ApXn-6R for linux-arm-kernel@lists.infradead.org; Mon, 29 Aug 2022 13:48:40 +0000 Received: (Authenticated sender: maxime.chevallier@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 3CA3D60005; Mon, 29 Aug 2022 13:48:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1661780911; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Z2m4rearj/dPqMVh35stfnUCu34jNVDpj9BgSbwCobk=; b=cpXFf8wJUloAz4AAGoNGaIWIp4VrUAQGNigvSUVKi3Vwf/94zpYwHxmhp/61KGjFgxcoYV 7uZoBBYgyMgYT6OzhdOECeGJy+sgLNoguJFXkxPJ7XZJBHDVqQuX91BDgxIlnjutlPt2xC VGfxDbpcsVXKujKBs21hYFcnHpuKNAJmq9tQ08qIPmOMALcx41guL3kNadh6bvKeyJYe/W HNfJTEPLh51zonCCa3oDKwCRRzrCgYP+VermwY7uKrkPX376W1TnVEA4rHvyk7xanzMF3H R1uQtiwjdvhOT4u7Xoh9V7CqTmbJFdQjd/rCJFc80tewzac7kvU+bH6Bw6A1gw== Date: Mon, 29 Aug 2022 15:48:26 +0200 From: Maxime Chevallier To: Andrew Lunn Cc: davem@davemloft.net, Rob Herring , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, thomas.petazzoni@bootlin.com, Florian Fainelli , Heiner Kallweit , Russell King , linux-arm-kernel@lists.infradead.org, Vladimir Oltean , Luka Perkov , Robert Marko Subject: Re: [PATCH net-next v3 1/5] net: ipqess: introduce the Qualcomm IPQESS driver Message-ID: <20220829154826.270b693e@pc-10.home> In-Reply-To: References: <20220826154650.615582-1-maxime.chevallier@bootlin.com> <20220826154650.615582-2-maxime.chevallier@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 4.1.0 (GTK 3.24.34; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220829_064837_467251_144A4A57 X-CRM114-Status: GOOD ( 14.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Andrew, and thanks for the review On Sat, 27 Aug 2022 21:28:21 +0200 Andrew Lunn wrote: > > +static void ipqess_get_strings(struct net_device *netdev, u32 > > stringset, > > + u8 *data) > > +{ > > + u8 *p = data; > > + u32 i; > > + > > + switch (stringset) { > > + case ETH_SS_STATS: > > + for (i = 0; i < ARRAY_SIZE(ipqess_stats); i++) { > > + memcpy(p, ipqess_stats[i].string, > > + min((size_t)ETH_GSTRING_LEN, > > + strlen(ipqess_stats[i].string) > > + 1)); > > That looks pretty similar to strlcpy(). Indeed... and after digging I even found ethtool_sprintf() which seems to fit even better :) > > +static int ipqess_get_settings(struct net_device *netdev, > > + struct ethtool_link_ksettings *cmd) > > > > It would be traditional to have the k in the name. > > > +{ > > + struct ipqess *ess = netdev_priv(netdev); > > + > > + return phylink_ethtool_ksettings_get(ess->phylink, cmd); > > +} > > + > > +static int ipqess_set_settings(struct net_device *netdev, > > + const struct ethtool_link_ksettings > > *cmd) +{ > > Here too. Agreed, I'll address that. Thanks ! Maxime > Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel